From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org
Cc: Richard Henderson <richard.henderson@linaro.org>
Subject: [PULL 2/4] tests/functional/aarch64/test_device_passthrough: Fix warnings from pylint
Date: Tue, 11 Nov 2025 11:21:56 +0100 [thread overview]
Message-ID: <20251111102158.92091-3-thuth@redhat.com> (raw)
In-Reply-To: <20251111102158.92091-1-thuth@redhat.com>
From: Thomas Huth <thuth@redhat.com>
Remove unused imports, write constants with capital letters and make
sure that the code uses the right indentation / formatting.
Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-ID: <20251030143203.297692-1-thuth@redhat.com>
---
.../aarch64/test_device_passthrough.py | 26 ++++++++++++-------
1 file changed, 16 insertions(+), 10 deletions(-)
diff --git a/tests/functional/aarch64/test_device_passthrough.py b/tests/functional/aarch64/test_device_passthrough.py
index 05a3f52d5e2..10c73728f36 100755
--- a/tests/functional/aarch64/test_device_passthrough.py
+++ b/tests/functional/aarch64/test_device_passthrough.py
@@ -10,13 +10,13 @@
# SPDX-License-Identifier: GPL-2.0-or-later
from os.path import join
+from random import randbytes
from qemu_test import QemuSystemTest, Asset
-from qemu_test import exec_command, wait_for_console_pattern
-from qemu_test import exec_command_and_wait_for_pattern
-from random import randbytes
+from qemu_test import wait_for_console_pattern
+
-guest_script = '''
+GUEST_SCRIPT = '''
#!/usr/bin/env bash
set -euo pipefail
@@ -56,7 +56,7 @@
-device vfio-pci,host=$pci_iommufd,iommufd=iommufd0
'''
-nested_guest_script = '''
+NESTED_GUEST_SCRIPT = '''
#!/usr/bin/env bash
set -euo pipefail
@@ -75,6 +75,7 @@
echo device_passthrough_test_ok
'''
+
class Aarch64DevicePassthrough(QemuSystemTest):
# https://github.com/pbo-linaro/qemu-linux-stack/tree/device_passthrough
@@ -86,7 +87,7 @@ class Aarch64DevicePassthrough(QemuSystemTest):
ASSET_DEVICE_PASSTHROUGH_STACK = Asset(
('https://github.com/pbo-linaro/qemu-linux-stack/'
'releases/download/build/device_passthrough-a9612a2.tar.xz'),
- 'f7d2f70912e7231986e6e293e1a2c4786dd02bec113a7acb6bfc619e96155455')
+ 'f7d2f70912e7231986e6e293e1a2c4786dd02bec113a7acb6bfc619e96155455')
# This tests the device passthrough implementation, by booting a VM
# supporting it with two nvme disks attached, and launching a nested VM
@@ -108,10 +109,14 @@ def test_aarch64_device_passthrough(self):
guest_cmd = join(stack, 'guest.sh')
nested_guest_cmd = join(stack, 'nested_guest.sh')
# we generate two random disks
- with open(disk_vfio, "wb") as d: d.write(randbytes(512))
- with open(disk_iommufd, "wb") as d: d.write(randbytes(1024))
- with open(guest_cmd, 'w') as s: s.write(guest_script)
- with open(nested_guest_cmd, 'w') as s: s.write(nested_guest_script)
+ with open(disk_vfio, "wb") as d:
+ d.write(randbytes(512))
+ with open(disk_iommufd, "wb") as d:
+ d.write(randbytes(1024))
+ with open(guest_cmd, 'w', encoding='utf-8') as s:
+ s.write(GUEST_SCRIPT)
+ with open(nested_guest_cmd, 'w', encoding='utf-8') as s:
+ s.write(NESTED_GUEST_SCRIPT)
self.vm.add_args('-cpu', 'max')
self.vm.add_args('-m', '2G')
@@ -139,5 +144,6 @@ def test_aarch64_device_passthrough(self):
wait_for_console_pattern(self, 'device_passthrough_test_ok',
failure_message='Kernel panic')
+
if __name__ == '__main__':
QemuSystemTest.main()
--
2.51.1
next prev parent reply other threads:[~2025-11-11 10:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-11 10:21 [PULL 0/4] Functional test patches (fixes for pylint issues) Thomas Huth
2025-11-11 10:21 ` [PULL 1/4] tests/functional: Fix problems in testcase.py reported by pylint Thomas Huth
2025-11-11 10:21 ` Thomas Huth [this message]
2025-11-11 10:21 ` [PULL 3/4] tests/functional/mips64el: Silence issues " Thomas Huth
2025-11-11 10:21 ` [PULL 4/4] tests/functional/m68k/test_nextcube: Fix " Thomas Huth
2025-11-12 10:46 ` [PULL 0/4] Functional test patches (fixes for pylint issues) Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251111102158.92091-3-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).