From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PATCH v3 00/10] chardev: Improve @docstring and clarify qemu_chr_write() uses
Date: Wed, 12 Nov 2025 14:41:33 +0100 [thread overview]
Message-ID: <20251112134143.27194-1-philmd@linaro.org> (raw)
v3:
- Addressed Marc-André & Daniel comments
- Document qemu_chr_fe_write()
- Rename replay arguments
v2:
- Document ChardevClass::chr_write() and qemu_chr_write[_all]()
Few chardev fixes:
- preserve %errno
- allow partial writes in qemu_chr_write()
Improve chardev methods documentation.
While @c for frontend and @s for backend is accepted, it
confuses me, so I prefer to document for my own mental health.
Based-on: <20251022074612.1258413-1-marcandre.lureau@redhat.com>
Philippe Mathieu-Daudé (10):
chardev/char-fe: Improve @docstrings
chardev/char-io: Add @docstrings for io_channel_send[_full]()
chardev/char: Improve ChardevClass::chr_write() docstring
chardev/char: Document qemu_chr_write[_all]()
chardev/char-pty: Do not ignore chr_write() failures
chardev/char: Allow partial writes in qemu_chr_write()
chardev/char: Preserve %errno in qemu_chr_write()
chardev/char: Document qemu_chr_fe_write()'s return value
hw/char: Simplify when qemu_chr_fe_write() could not write
system/replay: Rename some method parameters
include/chardev/char-fe.h | 33 ++++++++++++++++++++++++++-----
include/chardev/char-io.h | 20 +++++++++++++++++++
include/chardev/char.h | 41 ++++++++++++++++++++++++++++++++++++++-
include/system/replay.h | 16 +++++++--------
chardev/char-pty.c | 2 +-
chardev/char.c | 11 +++++++++++
hw/char/cadence_uart.c | 2 +-
hw/char/ibex_uart.c | 2 +-
hw/char/sifive_uart.c | 2 +-
replay/replay-char.c | 14 ++++++-------
stubs/replay-tools.c | 10 +++++-----
11 files changed, 123 insertions(+), 30 deletions(-)
--
2.51.0
next reply other threads:[~2025-11-12 13:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-12 13:41 Philippe Mathieu-Daudé [this message]
2025-11-12 13:41 ` [PATCH v3 01/10] chardev/char-fe: Improve @docstrings Philippe Mathieu-Daudé
2025-11-12 13:58 ` Daniel P. Berrangé
2025-11-13 11:31 ` Marc-André Lureau
2025-11-12 13:41 ` [PATCH v3 02/10] chardev/char-io: Add @docstrings for io_channel_send[_full]() Philippe Mathieu-Daudé
2025-11-13 11:32 ` Marc-André Lureau
2025-11-12 13:41 ` [PATCH v3 03/10] chardev/char: Improve ChardevClass::chr_write() docstring Philippe Mathieu-Daudé
2025-11-12 13:41 ` [PATCH v3 04/10] chardev/char: Document qemu_chr_write[_all]() Philippe Mathieu-Daudé
2025-11-12 13:41 ` [PATCH v3 05/10] chardev/char-pty: Do not ignore chr_write() failures Philippe Mathieu-Daudé
2025-11-12 13:41 ` [PATCH v3 06/10] chardev/char: Allow partial writes in qemu_chr_write() Philippe Mathieu-Daudé
2025-11-13 11:30 ` Marc-André Lureau
2025-11-12 13:41 ` [PATCH v3 07/10] chardev/char: Preserve %errno " Philippe Mathieu-Daudé
2025-11-12 13:41 ` [PATCH v3 08/10] chardev/char: Document qemu_chr_fe_write()'s return value Philippe Mathieu-Daudé
2025-11-13 11:32 ` Marc-André Lureau
2025-11-12 13:41 ` [PATCH v3 09/10] hw/char: Simplify when qemu_chr_fe_write() could not write Philippe Mathieu-Daudé
2025-11-12 13:41 ` [PATCH v3 10/10] system/replay: Rename some method parameters Philippe Mathieu-Daudé
2025-11-12 13:44 ` [PATCH v3 00/10] chardev: Improve @docstring and clarify qemu_chr_write() uses Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251112134143.27194-1-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).