qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, kwolf@redhat.com, berrange@redhat.com,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>
Subject: [PATCH v3 08/13] chardev: Reuse channel's cached local address
Date: Wed, 12 Nov 2025 19:11:33 -0600	[thread overview]
Message-ID: <20251113011625.878876-23-eblake@redhat.com> (raw)
In-Reply-To: <20251113011625.878876-15-eblake@redhat.com>

Directly accessing the fd member of a QIOChannelSocket is an
undesirable leaky abstraction.  What's more, grabbing that fd merely
to force an eventual call to getsockname() can be wasteful, since the
channel is often able to return its cached local name.

Reported-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Eric Blake <eblake@redhat.com>

---
v3: new patch
---
 chardev/char-socket.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/chardev/char-socket.c b/chardev/char-socket.c
index 62852e3caf5..ec4116ade4d 100644
--- a/chardev/char-socket.c
+++ b/chardev/char-socket.c
@@ -1255,7 +1255,7 @@ static int qmp_chardev_open_socket_server(Chardev *chr,
     }

     qapi_free_SocketAddress(s->addr);
-    s->addr = socket_local_address(s->listener->sioc[0]->fd, errp);
+    s->addr = qio_channel_socket_get_local_address(s->listener->sioc[0], errp);

 skip_listen:
     update_disconnected_filename(s);
-- 
2.51.1



  parent reply	other threads:[~2025-11-13  1:18 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-13  1:11 [PATCH v3 for-10.2 00/13] Fix deadlock with bdrv_open of self-served NBD Eric Blake
2025-11-13  1:11 ` [PATCH v3 01/13] iotests: Drop execute permissions on vvfat.out Eric Blake
2025-11-13  1:11 ` [PATCH v3 02/13] qio: Add trace points to net_listener Eric Blake
2025-11-13  1:11 ` [PATCH v3 03/13] qio: Unwatch before notify in QIONetListener Eric Blake
2025-11-13  1:11 ` [PATCH v3 04/13] qio: Remember context of qio_net_listener_set_client_func_full Eric Blake
2025-11-13  1:11 ` [PATCH v3 05/13] qio: Protect NetListener callback with mutex Eric Blake
2025-11-13  1:11 ` [PATCH v3 06/13] qio: Minor optimization when callback function is unchanged Eric Blake
2025-11-13  1:11 ` [PATCH v3 07/13] qio: Factor out helpers qio_net_listener_[un]watch Eric Blake
2025-11-13  1:11 ` Eric Blake [this message]
2025-11-13  1:11 ` [PATCH v3 09/13] qio: Provide accessor around QIONetListener->sioc Eric Blake
2025-11-13  1:11 ` [PATCH v3 10/13] qio: Prepare NetListener to use AioContext Eric Blake
2025-11-13  1:11 ` [PATCH v3 11/13] qio: Add QIONetListener API for using AioContext Eric Blake
2025-11-13  1:11 ` [PATCH v3 12/13] nbd: Avoid deadlock in client connecting to same-process server Eric Blake
2025-11-13  1:11 ` [PATCH v3 13/13] iotests: Add coverage of recent NBD qio deadlock fix Eric Blake
2025-11-13  9:07 ` [PATCH v3 for-10.2 00/13] Fix deadlock with bdrv_open of self-served NBD Daniel P. Berrangé
2025-11-13 13:36   ` Eric Blake
     [not found] <20251112224032.864420-15-eblake@redhat.com>
     [not found] ` <20251112224032.864420-23-eblake@redhat.com>
2025-11-13  9:01   ` [PATCH v3 08/13] chardev: Reuse channel's cached local address Daniel P. Berrangé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251113011625.878876-23-eblake@redhat.com \
    --to=eblake@redhat.com \
    --cc=berrange@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).