From: Max Chou <max.chou@sifive.com>
To: qemu-devel@nongnu.org, qemu-riscv@nongnu.org
Cc: Palmer Dabbelt <palmer@dabbelt.com>,
Alistair Francis <alistair.francis@wdc.com>,
Weiwei Li <liwei1518@gmail.com>,
Daniel Henrique Barboza <dbarboza@ventanamicro.com>,
Liu Zhiwei <zhiwei_liu@linux.alibaba.com>,
Anton Blanchard <antonb@tenstorrent.com>,
Max Chou <max.chou@sifive.com>,
Nutty Liu <liujingqi@lanxincomputing.com>
Subject: [PATCH v3 3/3] target/riscv: vadc and vsbc are vm=0 instructions
Date: Fri, 14 Nov 2025 01:16:04 +0800 [thread overview]
Message-ID: <20251113171604.3034161-4-max.chou@sifive.com> (raw)
In-Reply-To: <20251113171604.3034161-1-max.chou@sifive.com>
From: Anton Blanchard <antonb@tenstorrent.com>
We were marking vadc and vsbc as vm=1 instructions, which meant
vext_check_input_eew wouldn't detect mask vs source register
overlaps.
Signed-off-by: Anton Blanchard <antonb@tenstorrent.com>
Reviewed-by: Max Chou <max.chou@sifive.com>
Reviewed-by: Nutty Liu <liujingqi@lanxincomputing.com>
Signed-off-by: Max Chou <max.chou@sifive.com>
---
target/riscv/insn32.decode | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/target/riscv/insn32.decode b/target/riscv/insn32.decode
index b341832e41f..3647ec7f941 100644
--- a/target/riscv/insn32.decode
+++ b/target/riscv/insn32.decode
@@ -459,14 +459,14 @@ vwsubu_wv 110110 . ..... ..... 010 ..... 1010111 @r_vm
vwsubu_wx 110110 . ..... ..... 110 ..... 1010111 @r_vm
vwsub_wv 110111 . ..... ..... 010 ..... 1010111 @r_vm
vwsub_wx 110111 . ..... ..... 110 ..... 1010111 @r_vm
-vadc_vvm 010000 0 ..... ..... 000 ..... 1010111 @r_vm_1
-vadc_vxm 010000 0 ..... ..... 100 ..... 1010111 @r_vm_1
-vadc_vim 010000 0 ..... ..... 011 ..... 1010111 @r_vm_1
+vadc_vvm 010000 0 ..... ..... 000 ..... 1010111 @r_vm_0
+vadc_vxm 010000 0 ..... ..... 100 ..... 1010111 @r_vm_0
+vadc_vim 010000 0 ..... ..... 011 ..... 1010111 @r_vm_0
vmadc_vvm 010001 . ..... ..... 000 ..... 1010111 @r_vm
vmadc_vxm 010001 . ..... ..... 100 ..... 1010111 @r_vm
vmadc_vim 010001 . ..... ..... 011 ..... 1010111 @r_vm
-vsbc_vvm 010010 0 ..... ..... 000 ..... 1010111 @r_vm_1
-vsbc_vxm 010010 0 ..... ..... 100 ..... 1010111 @r_vm_1
+vsbc_vvm 010010 0 ..... ..... 000 ..... 1010111 @r_vm_0
+vsbc_vxm 010010 0 ..... ..... 100 ..... 1010111 @r_vm_0
vmsbc_vvm 010011 . ..... ..... 000 ..... 1010111 @r_vm
vmsbc_vxm 010011 . ..... ..... 100 ..... 1010111 @r_vm
vand_vv 001001 . ..... ..... 000 ..... 1010111 @r_vm
--
2.43.0
prev parent reply other threads:[~2025-11-13 17:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-13 17:16 [PATCH v3 0/3] Fix some more RVV source overlap issues Max Chou
2025-11-13 17:16 ` [PATCH v3 1/3] target/riscv: rvv: Apply vext_check_input_eew to vector int/fp compare instructions Max Chou
2025-11-13 17:16 ` [PATCH v3 2/3] target/riscv: rvv: Apply vext_check_input_eew to vector reduction instructions Max Chou
2025-11-13 17:16 ` Max Chou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251113171604.3034161-4-max.chou@sifive.com \
--to=max.chou@sifive.com \
--cc=alistair.francis@wdc.com \
--cc=antonb@tenstorrent.com \
--cc=dbarboza@ventanamicro.com \
--cc=liujingqi@lanxincomputing.com \
--cc=liwei1518@gmail.com \
--cc=palmer@dabbelt.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).