From: phind.uet@gmail.com
To: Cameron Esfahani <dirty@apple.com>,
Roman Bolshakov <rbolshakov@ddn.com>,
Phil Dennis-Jordan <phil@philjordan.eu>,
Wei Liu <wei.liu@kernel.org>
Cc: Nguyen Dinh Phi <phind.uet@gmail.com>, qemu-devel@nongnu.org
Subject: [PATCH] Make sure fetch_instruction exist before calling it
Date: Fri, 14 Nov 2025 16:29:15 +0800 [thread overview]
Message-ID: <20251114082915.71884-2-phind.uet@gmail.com> (raw)
From: Nguyen Dinh Phi <phind.uet@gmail.com>
Currently, this function is only available in MSHV. If a different accelerator
is used, and the code jumps to this section, a segfault will occur.
(I ran into this with HVF)
Signed-off-by: Nguyen Dinh Phi <phind.uet@gmail.com>
---
target/i386/emulate/x86_decode.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/target/i386/emulate/x86_decode.c b/target/i386/emulate/x86_decode.c
index 97bd6f1a3b..d037ed1142 100644
--- a/target/i386/emulate/x86_decode.c
+++ b/target/i386/emulate/x86_decode.c
@@ -77,7 +77,11 @@ static inline uint64_t decode_bytes(CPUX86State *env, struct x86_decode *decode,
memcpy(&val, decode->stream->bytes + decode->len, size);
} else {
target_ulong va = linear_rip(env_cpu(env), env->eip) + decode->len;
- emul_ops->fetch_instruction(env_cpu(env), &val, va, size);
+ if (emul_ops->fetch_instruction) {
+ emul_ops->fetch_instruction(env_cpu(env), &val, va, size);
+ } else {
+ emul_ops->read_mem(env_cpu(env), &val, va, size);
+ }
}
decode->len += size;
--
2.50.1 (Apple Git-155)
next reply other threads:[~2025-11-14 8:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-14 8:29 phind.uet [this message]
2025-11-14 11:24 ` [PATCH] Make sure fetch_instruction exist before calling it Paolo Bonzini
2025-11-14 12:36 ` Philippe Mathieu-Daudé
2025-11-14 16:10 ` Richard Henderson
2025-11-21 5:54 ` Michael Tokarev
2025-11-21 5:59 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251114082915.71884-2-phind.uet@gmail.com \
--to=phind.uet@gmail.com \
--cc=dirty@apple.com \
--cc=phil@philjordan.eu \
--cc=qemu-devel@nongnu.org \
--cc=rbolshakov@ddn.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).