From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Alexander Graf" <agraf@csgraf.de>,
qemu-arm@nongnu.org, "Phil Dennis-Jordan" <phil@philjordan.eu>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Peter Collingbourne" <pcc@google.com>,
"Cameron Esfahani" <dirty@apple.com>,
"Mohamed Mediouni" <mohamed@unpredictable.fr>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Akihiko Odaki" <odaki@rsg.ci.i.u-tokyo.ac.jp>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Roman Bolshakov" <rbolshakov@ddn.com>,
"Mads Ynddal" <mads@ynddal.dk>
Subject: [PATCH v5 02/19] target/i386/hvf: Use host page alignment in ept_emulation_fault()
Date: Fri, 14 Nov 2025 21:04:04 +0100 [thread overview]
Message-ID: <20251114200422.4280-3-philmd@linaro.org> (raw)
In-Reply-To: <20251114200422.4280-1-philmd@linaro.org>
While on x86 the host page size is fixed to 4KB, it is
better to call qemu_real_host_page_size() for consistency.
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
target/i386/hvf/hvf.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/target/i386/hvf/hvf.c b/target/i386/hvf/hvf.c
index 16febbac48f..9a1bf026a4a 100644
--- a/target/i386/hvf/hvf.c
+++ b/target/i386/hvf/hvf.c
@@ -76,7 +76,7 @@
#include "qemu/main-loop.h"
#include "qemu/accel.h"
#include "target/i386/cpu.h"
-#include "exec/target_page.h"
+#include "exec/cpu-common.h"
static Error *invtsc_mig_blocker;
@@ -137,9 +137,12 @@ static bool ept_emulation_fault(hvf_slot *slot, uint64_t gpa, uint64_t ept_qual)
if (write && slot) {
if (slot->flags & HVF_SLOT_LOG) {
- uint64_t dirty_page_start = gpa & ~(TARGET_PAGE_SIZE - 1u);
+ uintptr_t page_size = qemu_real_host_page_size();
+ intptr_t page_mask = -(intptr_t)page_size;
+ uint64_t dirty_page_start = gpa & page_mask;
+
memory_region_set_dirty(slot->region, gpa - slot->start, 1);
- hv_vm_protect(dirty_page_start, TARGET_PAGE_SIZE,
+ hv_vm_protect(dirty_page_start, page_size,
HV_MEMORY_READ | HV_MEMORY_WRITE | HV_MEMORY_EXEC);
}
}
--
2.51.0
next prev parent reply other threads:[~2025-11-14 20:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-14 20:04 [PATCH v5 00/19] target/arm/hvf: Consolidate Philippe Mathieu-Daudé
2025-11-14 20:04 ` [PATCH v5 01/19] accel/hvf: Create hvf_protect_clean_range, hvf_unprotect_dirty_range Philippe Mathieu-Daudé
2025-11-14 20:04 ` Philippe Mathieu-Daudé [this message]
2025-11-14 20:04 ` [PATCH v5 03/19] accel/hvf: Enforce host alignment in hv_vm_protect() Philippe Mathieu-Daudé
2025-11-14 20:04 ` [PATCH v5 04/19] target/i386/hvf: Use hvf_unprotect_dirty_range Philippe Mathieu-Daudé
2025-11-14 20:04 ` [PATCH v5 05/19] target/i386/hvf: Use address_space_translate in ept_emulation_fault Philippe Mathieu-Daudé
2025-11-14 20:04 ` [PATCH v5 06/19] accel/hvf: Simplify hvf_log_* Philippe Mathieu-Daudé
2025-11-14 20:04 ` [PATCH v5 07/19] accel/hvf: Move hvf_log_sync to hvf_log_clear Philippe Mathieu-Daudé
2025-11-14 20:04 ` [PATCH v5 08/19] accel/hvf: Simplify hvf_set_phys_mem Philippe Mathieu-Daudé
2025-11-14 20:04 ` [PATCH v5 09/19] accel/hvf: Drop hvf_slot and hvf_find_overlap_slot Philippe Mathieu-Daudé
2025-11-14 20:04 ` [PATCH v5 10/19] accel/hvf: Remove mac_slots Philippe Mathieu-Daudé
2025-11-14 20:04 ` [PATCH v5 11/19] target/arm/hvf: Implement dirty page tracking Philippe Mathieu-Daudé
2025-11-14 20:04 ` [PATCH v5 12/19] accel/hvf: Skip WFI if CPU has work to do Philippe Mathieu-Daudé
2025-11-14 20:04 ` [PATCH v5 13/19] accel/hvf: Implement WFI without using pselect() Philippe Mathieu-Daudé
2025-11-14 20:04 ` [PATCH v5 14/19] accel/hvf: Have PSCI CPU_SUSPEND halt the vCPU Philippe Mathieu-Daudé
2025-11-14 20:04 ` [PATCH v5 15/19] accel: Introduce AccelOpsClass::cpu_target_realize() hook Philippe Mathieu-Daudé
2025-11-14 20:04 ` [PATCH v5 16/19] accel/hvf: Add hvf_arch_cpu_realize() stubs Philippe Mathieu-Daudé
2025-11-14 20:04 ` [PATCH v5 17/19] target/arm: Create GTimers *after* features finalized / accel realized Philippe Mathieu-Daudé
2025-11-14 20:04 ` [PATCH v5 18/19] target/arm/hvf: Really set Generic Timer counter frequency Philippe Mathieu-Daudé
2025-11-14 20:04 ` [PATCH v5 19/19] target/arm: Only allow disabling NEON when using TCG Philippe Mathieu-Daudé
2025-11-15 2:22 ` [PATCH v5 00/19] target/arm/hvf: Consolidate Akihiko Odaki
2025-11-17 9:25 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251114200422.4280-3-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=agraf@csgraf.de \
--cc=dirty@apple.com \
--cc=mads@ynddal.dk \
--cc=mohamed@unpredictable.fr \
--cc=odaki@rsg.ci.i.u-tokyo.ac.jp \
--cc=pbonzini@redhat.com \
--cc=pcc@google.com \
--cc=peter.maydell@linaro.org \
--cc=phil@philjordan.eu \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rbolshakov@ddn.com \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).