From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 66F72CEACCB for ; Fri, 14 Nov 2025 20:07:54 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vK04v-0000qo-Np; Fri, 14 Nov 2025 15:07:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vK02N-0006tB-GC for qemu-devel@nongnu.org; Fri, 14 Nov 2025 15:04:53 -0500 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vK02L-0004mL-Qk for qemu-devel@nongnu.org; Fri, 14 Nov 2025 15:04:51 -0500 Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-429c7869704so1809889f8f.2 for ; Fri, 14 Nov 2025 12:04:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763150688; x=1763755488; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OYZPdSjIdF/EKh7X/rENMynZwEwjU3Z8rLiFolDwON0=; b=vb0GeqrPZzk4buzcxOhThE+YrqagZ1nlQgVmNLW2Kwp2/Xzk03c5advi59pQDeGYO3 tgGIzxnIh8UW/WEZd/qk7qXRHTdZ2PqZrFzyzxcxCzotz5ihLE30Qd7nAWeGd9M1kBk5 kYOC0kcbXJSq1kq3x6T4Zhpldu/h6IcwADxqn362ZEEsNXbzkYYBYReMP0JE08Qj0R6n HmMPIY9hjZqOP00DqXvoKOc2ivT9V9IYsIOPVpViGbBDjoveQXLMNc65zzlEM0jm5GLm 3qrNCYfQLTPcqhaFdGuspTIta7v4U+6RfT64fAGGG/aJI1g9zwWP1qWeEnjtXi7wlgym v4mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763150688; x=1763755488; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=OYZPdSjIdF/EKh7X/rENMynZwEwjU3Z8rLiFolDwON0=; b=HuvPj4lJh/5KeZpNhEYXk4njzC5OFc3cJR48VkcC/hWL3SQzBV3s3eDeIJXgrzI+cu zYokF8XdduzdNMQlJAn8Wy3cn6InEPFqE/jq1ADVU/RSIZ3FPL3nKdn+udYBvXEVus1L 6ybsI1ozPadzxWTO4PhG6GImUrZXiEgscM4NH7uAVqkNzdc5KVYFg6ztbctqrxUajooq xW6xN/Yqz6Sh8uwoXtZZBJt0LEpm9anZIqsorpcoOWQ30bb2HHeI9MK5PTBdER5agkWR KFt7cBo9kO3Xov1wIQZc3KHi9gACBevEOmqqjQNkCjR5EwMl2fIF/0F4BtXO63qLVdLQ EBag== X-Gm-Message-State: AOJu0Yw+577FDg3VqHXQqi1HC507+xQ7RjrWJ6U3OdphkO6QAUqJc6RV /2Gu4ymIYwfazyyeQanEcNR+Ad1IHOkA3OfLW5S6UXtLFvN9o5r7gDvQroC5jqnPHLTiN69A9si Nc02Q+A7zTA== X-Gm-Gg: ASbGncuy1k2UuAUalo/NpSTq9DA51aGMXetisoefyDPy9/Gl2zG/JIF7Tyi8r/0FKcT B/nXe/Lq59HPJOg+LpQ/gXqc+lrd41bPKJWaJy4TW+xCJcyuckBT5nRBhiEnchKvyU0qacq0fWc cjq7WOX0rNpMWjfYLzKBPNck0OH2xBK1d74JSFEt/z7lN4uD9+VtGR9OGl/Mzo0SM4kyN//wtpE Z0RSJuIa6otFKCe/Yw6mOytgpeivOqloHCv1g9Ma3pzCR9ypMUdnA+DQ8dRB+d08OjBx5JOSyOX tScQAGnGB3fQQekIdQjJYd+Aznj2P0Tpc3eNEIqq7TQHxhAKW8KI6XA8w7aXtpa3WVrmroEf6Tk 0ogoD/dSMeRTNxKprZ7sgeAlnIAWd6iwcWMrLsdcxrvKga8G5sX85PV7wkoErfeN/tvCg0+/tl6 WaA6AixmCd+HiSuhGnrmky9wP/AEyxTPPzy0vNZIzcUid+CdQyg17NOyyR9IsM X-Google-Smtp-Source: AGHT+IEIqz8iRf+F3zPMn3HXphrgQtH6CH8BN6CABSXb2GhbgVTHz0nk/hAbT6A0LgT1h06eGnXWtw== X-Received: by 2002:a05:6000:1ace:b0:42b:3978:1587 with SMTP id ffacd0b85a97d-42b59381be5mr4664778f8f.36.1763150688096; Fri, 14 Nov 2025 12:04:48 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42b53e7aea7sm11727470f8f.1.2025.11.14.12.04.46 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 14 Nov 2025 12:04:47 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Alexander Graf , qemu-arm@nongnu.org, Phil Dennis-Jordan , Paolo Bonzini , Richard Henderson , Peter Collingbourne , Cameron Esfahani , Mohamed Mediouni , Peter Maydell , Akihiko Odaki , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Roman Bolshakov , Mads Ynddal Subject: [PATCH v5 03/19] accel/hvf: Enforce host alignment in hv_vm_protect() Date: Fri, 14 Nov 2025 21:04:05 +0100 Message-ID: <20251114200422.4280-4-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251114200422.4280-1-philmd@linaro.org> References: <20251114200422.4280-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=philmd@linaro.org; helo=mail-wr1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org hv_vm_protect() arguments must be aligned to host page. Suggested-by: Richard Henderson Reviewed-by: Peter Maydell Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- accel/hvf/hvf-all.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/accel/hvf/hvf-all.c b/accel/hvf/hvf-all.c index e13abddbd9c..cb029e4dd4b 100644 --- a/accel/hvf/hvf-all.c +++ b/accel/hvf/hvf-all.c @@ -11,6 +11,7 @@ #include "qemu/osdep.h" #include "qemu/error-report.h" #include "accel/accel-ops.h" +#include "exec/cpu-common.h" #include "system/address-spaces.h" #include "system/memory.h" #include "system/hvf.h" @@ -61,12 +62,15 @@ void assert_hvf_ok_impl(hv_return_t ret, const char *file, unsigned int line, static void do_hv_vm_protect(hwaddr start, size_t size, hv_memory_flags_t flags) { + intptr_t page_mask = qemu_real_host_page_mask(); hv_return_t ret; trace_hvf_vm_protect(start, size, flags, flags & HV_MEMORY_READ ? 'R' : '-', flags & HV_MEMORY_WRITE ? 'W' : '-', flags & HV_MEMORY_EXEC ? 'X' : '-'); + g_assert(!((uintptr_t)start & ~page_mask)); + g_assert(!(size & ~page_mask)); ret = hv_vm_protect(start, size, flags); assert_hvf_ok(ret); -- 2.51.0