From: Taylor Simpson <ltaylorsimpson@gmail.com>
To: qemu-devel@nongnu.org
Cc: brian.cain@oss.qualcomm.com, matheus.bernardino@oss.qualcomm.com,
sid.manning@oss.qualcomm.com, marco.liebel@oss.qualcomm.com,
richard.henderson@linaro.org, philmd@linaro.org, ale@rev.ng,
anjo@rev.ng, ltaylorsimpson@gmail.com
Subject: [PATCH 3/4] Hexagon (target/hexagon) s/gen_log_vreg_write/gen_vreg_write
Date: Fri, 14 Nov 2025 16:00:12 -0700 [thread overview]
Message-ID: <20251114230013.158098-4-ltaylorsimpson@gmail.com> (raw)
In-Reply-To: <20251114230013.158098-1-ltaylorsimpson@gmail.com>
Note there are two functions impacted
gen_log_vreg_write -> gen_vreg_write
gen_log_vreg_write_pair -> gen_vreg_write_pair
These functions don't "log" anything, they just generate the write
Signed-off-by: Taylor Simpson <ltaylorsimpson@gmail.com>
---
target/hexagon/genptr.c | 8 ++++----
target/hexagon/hex_common.py | 8 ++++----
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/target/hexagon/genptr.c b/target/hexagon/genptr.c
index bfbbd61c33..616db17907 100644
--- a/target/hexagon/genptr.c
+++ b/target/hexagon/genptr.c
@@ -1174,7 +1174,7 @@ static intptr_t vreg_src_off(DisasContext *ctx, int num)
return offset;
}
-static void gen_log_vreg_write(DisasContext *ctx, intptr_t srcoff, int num,
+static void gen_vreg_write(DisasContext *ctx, intptr_t srcoff, int num,
VRegWriteType type)
{
intptr_t dstoff;
@@ -1190,12 +1190,12 @@ static void gen_log_vreg_write(DisasContext *ctx, intptr_t srcoff, int num,
}
}
-static void gen_log_vreg_write_pair(DisasContext *ctx, intptr_t srcoff, int num,
+static void gen_vreg_write_pair(DisasContext *ctx, intptr_t srcoff, int num,
VRegWriteType type)
{
- gen_log_vreg_write(ctx, srcoff, num ^ 0, type);
+ gen_vreg_write(ctx, srcoff, num ^ 0, type);
srcoff += sizeof(MMVector);
- gen_log_vreg_write(ctx, srcoff, num ^ 1, type);
+ gen_vreg_write(ctx, srcoff, num ^ 1, type);
}
static intptr_t get_result_qreg(DisasContext *ctx, int qnum)
diff --git a/target/hexagon/hex_common.py b/target/hexagon/hex_common.py
index 1277fec9a2..6b683487bc 100755
--- a/target/hexagon/hex_common.py
+++ b/target/hexagon/hex_common.py
@@ -823,8 +823,8 @@ def decl_tcg(self, f, tag, regno):
"""))
def log_write(self, f, tag):
f.write(code_fmt(f"""\
- gen_log_vreg_write(ctx, {self.hvx_off()}, {self.reg_num},
- {hvx_newv(tag)});
+ gen_vreg_write(ctx, {self.hvx_off()}, {self.reg_num},
+ {hvx_newv(tag)});
"""))
def helper_hvx_desc(self, f):
f.write(code_fmt(f"""\
@@ -915,8 +915,8 @@ def decl_tcg(self, f, tag, regno):
"""))
def log_write(self, f, tag):
f.write(code_fmt(f"""\
- gen_log_vreg_write_pair(ctx, {self.hvx_off()}, {self.reg_num},
- {hvx_newv(tag)});
+ gen_vreg_write_pair(ctx, {self.hvx_off()}, {self.reg_num},
+ {hvx_newv(tag)});
"""))
def helper_hvx_desc(self, f):
f.write(code_fmt(f"""\
--
2.43.0
next prev parent reply other threads:[~2025-11-14 23:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-14 23:00 [PATCH 0/4] Clean up end-of-instruction processing Taylor Simpson
2025-11-14 23:00 ` [PATCH 1/4] Hexagon (target/hexagon) Remove gen_log_reg_write Taylor Simpson
2025-12-03 23:34 ` Brian Cain
2025-11-14 23:00 ` [PATCH 2/4] Hexagon (target/hexagon) s/gen_log_pred_write/gen_pred_write Taylor Simpson
2025-11-17 17:35 ` Philippe Mathieu-Daudé
2025-12-03 23:36 ` Brian Cain
2025-11-14 23:00 ` Taylor Simpson [this message]
2025-11-17 17:36 ` [PATCH 3/4] Hexagon (target/hexagon) s/gen_log_vreg_write/gen_vreg_write Philippe Mathieu-Daudé
2025-12-03 23:37 ` Brian Cain
2025-11-14 23:00 ` [PATCH 4/4] Hexagon (target/hexagon) s/log_write/gen_write Taylor Simpson
2025-11-17 17:37 ` Philippe Mathieu-Daudé
2025-12-03 23:37 ` Brian Cain
2025-11-17 9:28 ` [PATCH 0/4] Clean up end-of-instruction processing Philippe Mathieu-Daudé
2025-11-17 17:08 ` Brian Cain
2025-11-17 17:35 ` Philippe Mathieu-Daudé
2025-11-17 18:35 ` Taylor Simpson
2025-11-17 20:02 ` Taylor Simpson
2025-12-04 8:46 ` Philippe Mathieu-Daudé
2025-12-09 19:18 ` Brian Cain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251114230013.158098-4-ltaylorsimpson@gmail.com \
--to=ltaylorsimpson@gmail.com \
--cc=ale@rev.ng \
--cc=anjo@rev.ng \
--cc=brian.cain@oss.qualcomm.com \
--cc=marco.liebel@oss.qualcomm.com \
--cc=matheus.bernardino@oss.qualcomm.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=sid.manning@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).