From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: peterx@redhat.com, farosas@suse.de
Subject: [PATCH 2/3] migration: Use warn_reportf_err() where appropriate
Date: Sat, 15 Nov 2025 09:34:59 +0100 [thread overview]
Message-ID: <20251115083500.2753895-3-armbru@redhat.com> (raw)
In-Reply-To: <20251115083500.2753895-1-armbru@redhat.com>
Replace
warn_report("...: %s", ..., error_get_pretty(err));
by
warn_reportf_err(err, "...: ", ...);
Prior art: commit 5217f1887a8 (error: Use error_reportf_err() where
appropriate).
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
migration/multifd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/migration/multifd.c b/migration/multifd.c
index a529c399e4..6210454838 100644
--- a/migration/multifd.c
+++ b/migration/multifd.c
@@ -464,8 +464,8 @@ static void migration_ioc_shutdown_gracefully(QIOChannel *ioc)
*/
migration_tls_channel_end(ioc, &local_err);
if (local_err) {
- warn_report("Failed to gracefully terminate TLS connection: %s",
- error_get_pretty(local_err));
+ warn_reportf_err(local_err,
+ "Failed to gracefully terminate TLS connection: ");
}
}
--
2.49.0
next prev parent reply other threads:[~2025-11-15 9:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-15 8:34 [PATCH 0/3] migration: Error fixes and improvements Markus Armbruster
2025-11-15 8:34 ` [PATCH 1/3] migration: Plug memory leaks after migrate_set_error() Markus Armbruster
2025-11-15 8:34 ` Markus Armbruster [this message]
2025-11-17 15:47 ` [PATCH 2/3] migration: Use warn_reportf_err() where appropriate Fabiano Rosas
2025-11-15 8:35 ` [PATCH 3/3] migration/postcopy-ram: Improve error reporting after loadvm failure Markus Armbruster
2025-11-17 15:50 ` Fabiano Rosas
2025-11-17 16:03 ` [PATCH 0/3] migration: Error fixes and improvements Peter Xu
2025-11-18 7:44 ` Markus Armbruster
2025-11-18 17:35 ` Peter Xu
2025-11-19 7:45 ` Markus Armbruster
2025-11-19 20:58 ` Peter Xu
2025-11-20 10:30 ` Migration and the Job abstraction (was: [PATCH 0/3] migration: Error fixes and improvements) Markus Armbruster
2025-11-20 12:16 ` Kevin Wolf
2025-11-24 22:48 ` Peter Xu
2025-11-21 12:38 ` [PATCH 0/3] migration: Error fixes and improvements Fabiano Rosas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251115083500.2753895-3-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=farosas@suse.de \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).