From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CB7E2CCD19A for ; Mon, 17 Nov 2025 01:42:17 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vKoFK-0003BU-L4; Sun, 16 Nov 2025 20:41:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vKoEg-0002Z9-0o for qemu-devel@nongnu.org; Sun, 16 Nov 2025 20:40:55 -0500 Received: from mail-qt1-x82d.google.com ([2607:f8b0:4864:20::82d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vKoEd-0005yf-82 for qemu-devel@nongnu.org; Sun, 16 Nov 2025 20:40:53 -0500 Received: by mail-qt1-x82d.google.com with SMTP id d75a77b69052e-4edb7c8232aso57058861cf.3 for ; Sun, 16 Nov 2025 17:40:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763343649; x=1763948449; darn=nongnu.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Ihipyb7Ru3/tHKU6eXELZTfZpiyon46Jva01mBoEaT8=; b=YYn175VRWcuoDHDge++TNRYyX5xUEimMmMdu+44ZvrLB2/dGE9a//jhcIaVx/Ok+GV WlVWOGwP9zlXqXbEEuc4Qk3WwxxUl3FmSIJhFnwR6aBGDiEtfpWY3Fzstd0mxkrGmImt Fyb0ugyRhDRfB+yIZbUIa9pe29qfce2AwooLjS2t8kUjrTL4CJT8VllC4XUMzND7hVr+ oCiGo6S4ZE1cXq04oeHwUCHPuObdByRHdqp1NhYBUJKrxY/ph7ugRbBSKBuSUkFDi51z Pzk8ULrRfD5F4Zg+arIADBQRiZW+6+5cpfxzs7+1NRQoeelEfs+RUQ1tgX4W6lE6W15f Xlwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763343649; x=1763948449; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Ihipyb7Ru3/tHKU6eXELZTfZpiyon46Jva01mBoEaT8=; b=esntmJWhpIXwx4Pb3pXBEKlKa6cqKL0wXx7q5j8EuSj4nOsiB8wmTj5anj1Q0hDFjf EU4QC85OueLTb/36M/QfMkLo2WLw6x7RvgTvjjFP8yhpofTneIKwMBeCehr1VwBOi2Wo hy3IbMXkBFkG/1Q7HYxQYWXhaVGP53lGScL+LqbReq84O8WqxfrIHuYz6Du35JBYv811 jdKkmQCIINfV8f6Dww+maF0VQ9ys0N1p1C1iYKyQD7Uee1bT/oFSKUI44wLiPrYEcZcg xx6zuT1k4dDx2Q5+/vByt3aAqEdrm3RjWq7JiGje+bzUVLMKMQ0HmqSIAKBuGKavnpzh cX2Q== X-Gm-Message-State: AOJu0YxN/b2rxK+k+HBtV9YSHmGwdVcUte/mLZbpQRpGQ7GMNwVYLCx3 w8vNdG6NE0ccmIrlTLHCr3ZLM/UEq+BMlNr4kPhWWBDmvSMr5xP32PAs X-Gm-Gg: ASbGncsqbjxwko3I0/37JxJEotBBuAEBKYj7fc4+iVZ/PiIEGTsc+mVRj9G0b3MHede fN/Fvu3/aagefnJXbsTowWRbHM7unq/D/Q6XTx8x1R7EBMgf9xpxnM/niircQjYm9PbyXMgxr0/ 4T8o8r75T5n1NpkxO+p2B5AFEjFZDi3U58Nrjqj7QKA4D9vhAicFk6LGTdKri2HU6NJcHAiR2rH XEIJUFCFU+D2Ll2hjI32h97bGZ+DZherIhfBBhOXsHVA4NjAWNAziCdrC+v7jZOgkdyPoPAnCV/ cWQjj2ViJADlgST9IL1Bsbm/nEMDOx4hfHt8SoMjTPoG7LhnuF4Ycwc8qYAq1oC7MAW+bO6LDEj 0RqdfX6aFywN5Orm6uF+0+zUPTkuqN1S3L81YZKM34cqQp+8tMbA7V+dHONQgSlWku49E7jJ9xF +exmpsg2nDToESH8pDlME= X-Google-Smtp-Source: AGHT+IE8lG32RhNeLkm0p2860xTfDGao3wwHUblBvro27NZk8A1ratAQ78qSLwkIe2DQNIu8RN9cBg== X-Received: by 2002:ac8:59c1:0:b0:4ee:24d0:454f with SMTP id d75a77b69052e-4ee24d04d27mr10407171cf.37.1763343649047; Sun, 16 Nov 2025 17:40:49 -0800 (PST) Received: from [10.0.0.22] ([185.213.193.149]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4ee1c21ea34sm18246551cf.30.2025.11.16.17.40.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Nov 2025 17:40:47 -0800 (PST) From: Gabriel Brookman Date: Sun, 16 Nov 2025 20:40:24 -0500 Subject: [PATCH RFC v2 07/10] target/arm: ldg on canonical tag loads the tag MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20251116-feat-mte4-v2-7-9a7122b7fa76@gmail.com> References: <20251116-feat-mte4-v2-0-9a7122b7fa76@gmail.com> In-Reply-To: <20251116-feat-mte4-v2-0-9a7122b7fa76@gmail.com> To: qemu-devel@nongnu.org Cc: Peter Maydell , Gustavo Romero , qemu-arm@nongnu.org, Gabriel Brookman X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1763343639; l=1576; i=brookmangabriel@gmail.com; s=20251009; h=from:subject:message-id; bh=fIipJW6zdB7cgS7KaJpOQoZAsxlcOoekAcIhgxUqYiw=; b=13d11fAol537wMifs7Pn6MTr+3m2Tko6JIS2dccj+7Z4vtRK12mM2Zm1rrA6feIc0JkcGBp17 8oi1QxR2nkDAo15iGA2BK6tMO/TyDjHpageud9o192jWH2TWIa35FWf X-Developer-Key: i=brookmangabriel@gmail.com; a=ed25519; pk=m9TtPDal6WzoHNnQiHHKf8dTrv3DUCPUUTujuo8vNrw= Received-SPF: pass client-ip=2607:f8b0:4864:20::82d; envelope-from=brookmangabriel@gmail.com; helo=mail-qt1-x82d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org According to ARM ARM, section "Memory Tagging Region Types", loading tags from canonically tagged regions should use the canonical tags, not allocation tags. Signed-off-by: Gabriel Brookman --- target/arm/tcg/mte_helper.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/target/arm/tcg/mte_helper.c b/target/arm/tcg/mte_helper.c index 513ee8d6a1..ddb68e11fc 100644 --- a/target/arm/tcg/mte_helper.c +++ b/target/arm/tcg/mte_helper.c @@ -279,9 +279,14 @@ uint64_t HELPER(ldg)(CPUARMState *env, uint64_t ptr, uint64_t xt) mem = allocation_tag_mem(env, mmu_idx, ptr, MMU_DATA_LOAD, 1, MMU_DATA_LOAD, GETPC()); - /* Load if page supports tags. */ + /* Load if page supports tags. Set to canonical value if MTX is set. */ if (mem) { - rtag = load_tag1(ptr, mem); + uint64_t bit55 = extract64(ptr, 55, 1); + if (mtx_check(env, bit55)) { + rtag = 0xF * bit55; + } else { + rtag = load_tag1(ptr, mem); + } } return address_with_allocation_tag(xt, rtag); @@ -444,6 +449,11 @@ uint64_t HELPER(ldgm)(CPUARMState *env, uint64_t ptr) return 0; } + if (mtx_check(env, extract64(ptr, 55, 1))) { + shift = extract64(ptr, LOG2_TAG_GRANULE, 4) * 4; + return (~0) << shift; + } + /* * The ordering of elements within the word corresponds to * a little-endian operation. Computation of shift comes from -- 2.51.2