From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Paul Durrant" <paul@xen.org>,
"Anthony PERARD" <anthony@xenproject.org>,
"Edgar E . Iglesias" <edgar.iglesias@gmail.com>,
qemu-arm@nongnu.org, "Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Edgar E. Iglesias" <edgar.iglesias@amd.com>
Subject: [PATCH-for-10.2] hw/arm: Re-enable xenpvh machine in qemu-system-arm/aarch64 binaries
Date: Mon, 17 Nov 2025 10:12:53 +0100 [thread overview]
Message-ID: <20251117091253.56009-1-philmd@linaro.org> (raw)
While registering the ARM/Aarch64 machine interfaces
in commit 38c5ab40031 ("hw/arm: Filter machine types
for qemu-system-arm/aarch64 binaries"), we missed the
XenPV machine. Correct that.
Reported-by: Edgar E. Iglesias <edgar.iglesias@amd.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Edgar E. Iglesias <edgar.iglesias@amd.com>
---
1/ Review got likely unnoticed by Xen folks because no
Xen-specific entry in MAINTAINERS:
$ ./scripts/get_maintainer.pl -f hw/arm/xen-pvh.c
Peter Maydell <peter.maydell@linaro.org> (maintainer:ARM TCG CPUs)
qemu-arm@nongnu.org (open list:ARM TCG CPUs)
qemu-devel@nongnu.org (open list:All patches CC here)
2/ Should we restrict it to aa64 only?
---
hw/arm/xen-pvh.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/arm/xen-pvh.c b/hw/arm/xen-pvh.c
index 1a9eeb01c8e..86a02966161 100644
--- a/hw/arm/xen-pvh.c
+++ b/hw/arm/xen-pvh.c
@@ -10,6 +10,7 @@
#include "hw/boards.h"
#include "system/system.h"
#include "hw/xen/xen-pvh-common.h"
+#include "hw/arm/machines-qom.h"
#define TYPE_XEN_ARM MACHINE_TYPE_NAME("xenpvh")
@@ -95,6 +96,7 @@ static const TypeInfo xen_arm_machine_type = {
.class_init = xen_arm_machine_class_init,
.instance_size = sizeof(XenPVHMachineState),
.instance_init = xen_arm_instance_init,
+ .interfaces = arm_aarch64_machine_interfaces,
};
static void xen_arm_machine_register_types(void)
--
2.51.0
next reply other threads:[~2025-11-17 9:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-17 9:12 Philippe Mathieu-Daudé [this message]
2025-11-17 16:07 ` [PATCH-for-10.2] hw/arm: Re-enable xenpvh machine in qemu-system-arm/aarch64 binaries Edgar E. Iglesias via
2025-11-18 18:21 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251117091253.56009-1-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=anthony@xenproject.org \
--cc=edgar.iglesias@amd.com \
--cc=edgar.iglesias@gmail.com \
--cc=paul@xen.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).