* [PATCH-for-10.2] hw/southbridge/lasi: Correct LasiState parent
@ 2025-11-17 9:18 Philippe Mathieu-Daudé
2025-11-18 16:11 ` Gustavo Romero
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2025-11-17 9:18 UTC (permalink / raw)
To: qemu-devel
Cc: Soumyajyotii Ssarkar, Helge Deller, Richard Henderson,
Philippe Mathieu-Daudé
TYPE_LASI_CHIP inherits from TYPE_SYS_BUS_DEVICE, not
TYPE_PCI_HOST_BRIDGE, so its parent structure is of
SysBusDevice type.
Fixes: 376b851909d ("hppa: Add support for LASI chip with i82596 NIC")
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
include/hw/misc/lasi.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/hw/misc/lasi.h b/include/hw/misc/lasi.h
index 04312d0b589..0e95be1c32a 100644
--- a/include/hw/misc/lasi.h
+++ b/include/hw/misc/lasi.h
@@ -13,8 +13,8 @@
#define LASI_H
#include "system/address-spaces.h"
-#include "hw/pci/pci_host.h"
#include "hw/boards.h"
+#include "hw/sysbus.h"
#define TYPE_LASI_CHIP "lasi-chip"
OBJECT_DECLARE_SIMPLE_TYPE(LasiState, LASI_CHIP)
@@ -63,7 +63,7 @@ OBJECT_DECLARE_SIMPLE_TYPE(LasiState, LASI_CHIP)
#define LASI_IRQ_PS2MOU_HPA 26
struct LasiState {
- PCIHostState parent_obj;
+ SysBusDevice parent_obj;
uint32_t irr;
uint32_t imr;
--
2.51.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH-for-10.2] hw/southbridge/lasi: Correct LasiState parent
2025-11-17 9:18 [PATCH-for-10.2] hw/southbridge/lasi: Correct LasiState parent Philippe Mathieu-Daudé
@ 2025-11-18 16:11 ` Gustavo Romero
2025-11-18 17:09 ` Thomas Huth
2025-11-18 18:10 ` Philippe Mathieu-Daudé
2 siblings, 0 replies; 4+ messages in thread
From: Gustavo Romero @ 2025-11-18 16:11 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Soumyajyotii Ssarkar, Helge Deller, Richard Henderson
Hi Phil,
On 11/17/25 06:18, Philippe Mathieu-Daudé wrote:
> TYPE_LASI_CHIP inherits from TYPE_SYS_BUS_DEVICE, not
> TYPE_PCI_HOST_BRIDGE, so its parent structure is of
> SysBusDevice type.
>
> Fixes: 376b851909d ("hppa: Add support for LASI chip with i82596 NIC")
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> include/hw/misc/lasi.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
oh, right :)
Reviewed-by: Gustavo Romero <gustavo.romero@linaro.org>
> diff --git a/include/hw/misc/lasi.h b/include/hw/misc/lasi.h
> index 04312d0b589..0e95be1c32a 100644
> --- a/include/hw/misc/lasi.h
> +++ b/include/hw/misc/lasi.h
> @@ -13,8 +13,8 @@
> #define LASI_H
>
> #include "system/address-spaces.h"
> -#include "hw/pci/pci_host.h"
> #include "hw/boards.h"
> +#include "hw/sysbus.h"
>
> #define TYPE_LASI_CHIP "lasi-chip"
> OBJECT_DECLARE_SIMPLE_TYPE(LasiState, LASI_CHIP)
> @@ -63,7 +63,7 @@ OBJECT_DECLARE_SIMPLE_TYPE(LasiState, LASI_CHIP)
> #define LASI_IRQ_PS2MOU_HPA 26
>
> struct LasiState {
> - PCIHostState parent_obj;
> + SysBusDevice parent_obj;
>
> uint32_t irr;
> uint32_t imr;
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH-for-10.2] hw/southbridge/lasi: Correct LasiState parent
2025-11-17 9:18 [PATCH-for-10.2] hw/southbridge/lasi: Correct LasiState parent Philippe Mathieu-Daudé
2025-11-18 16:11 ` Gustavo Romero
@ 2025-11-18 17:09 ` Thomas Huth
2025-11-18 18:10 ` Philippe Mathieu-Daudé
2 siblings, 0 replies; 4+ messages in thread
From: Thomas Huth @ 2025-11-18 17:09 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Soumyajyotii Ssarkar, Helge Deller, Richard Henderson,
Mark Cave-Ayland
On 17/11/2025 10.18, Philippe Mathieu-Daudé wrote:
> TYPE_LASI_CHIP inherits from TYPE_SYS_BUS_DEVICE, not
> TYPE_PCI_HOST_BRIDGE, so its parent structure is of
> SysBusDevice type.
>
> Fixes: 376b851909d ("hppa: Add support for LASI chip with i82596 NIC")
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> include/hw/misc/lasi.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/hw/misc/lasi.h b/include/hw/misc/lasi.h
> index 04312d0b589..0e95be1c32a 100644
> --- a/include/hw/misc/lasi.h
> +++ b/include/hw/misc/lasi.h
> @@ -13,8 +13,8 @@
> #define LASI_H
>
> #include "system/address-spaces.h"
> -#include "hw/pci/pci_host.h"
> #include "hw/boards.h"
> +#include "hw/sysbus.h"
>
> #define TYPE_LASI_CHIP "lasi-chip"
> OBJECT_DECLARE_SIMPLE_TYPE(LasiState, LASI_CHIP)
> @@ -63,7 +63,7 @@ OBJECT_DECLARE_SIMPLE_TYPE(LasiState, LASI_CHIP)
> #define LASI_IRQ_PS2MOU_HPA 26
>
> struct LasiState {
> - PCIHostState parent_obj;
> + SysBusDevice parent_obj;
>
> uint32_t irr;
> uint32_t imr;
Looks right.
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH-for-10.2] hw/southbridge/lasi: Correct LasiState parent
2025-11-17 9:18 [PATCH-for-10.2] hw/southbridge/lasi: Correct LasiState parent Philippe Mathieu-Daudé
2025-11-18 16:11 ` Gustavo Romero
2025-11-18 17:09 ` Thomas Huth
@ 2025-11-18 18:10 ` Philippe Mathieu-Daudé
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2025-11-18 18:10 UTC (permalink / raw)
To: qemu-devel; +Cc: Soumyajyotii Ssarkar, Helge Deller, Richard Henderson
On 17/11/25 10:18, Philippe Mathieu-Daudé wrote:
> TYPE_LASI_CHIP inherits from TYPE_SYS_BUS_DEVICE, not
> TYPE_PCI_HOST_BRIDGE, so its parent structure is of
> SysBusDevice type.
>
> Fixes: 376b851909d ("hppa: Add support for LASI chip with i82596 NIC")
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> include/hw/misc/lasi.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Queued, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-11-18 18:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-17 9:18 [PATCH-for-10.2] hw/southbridge/lasi: Correct LasiState parent Philippe Mathieu-Daudé
2025-11-18 16:11 ` Gustavo Romero
2025-11-18 17:09 ` Thomas Huth
2025-11-18 18:10 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).