From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
qemu-block@nongnu.org, "Cleber Rosa" <crosa@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Michael Roth" <michael.roth@amd.com>,
"Hanna Reitz" <hreitz@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Kevin Wolf" <kwolf@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"John Snow" <jsnow@redhat.com>
Subject: [PATCH 17/22] tests: forcibly run 'make check-venv' for crash tests
Date: Mon, 17 Nov 2025 13:51:25 -0500 [thread overview]
Message-ID: <20251117185131.953681-18-jsnow@redhat.com> (raw)
In-Reply-To: <20251117185131.953681-1-jsnow@redhat.com>
In order to convert the existing Makefile target from a manual
invocation of mkvenv to one that uses the meson dependency system, we
need to not suppress ninja here.
I'm not sure if this creates problems I am not aware of; but invoking
ninja here is no longer spurious but will become necessary.
Signed-off-by: John Snow <jsnow@redhat.com>
---
.gitlab-ci.d/buildtest.yml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml
index 18d72d3058b..2cb2cf25b4a 100644
--- a/.gitlab-ci.d/buildtest.yml
+++ b/.gitlab-ci.d/buildtest.yml
@@ -101,7 +101,7 @@ crash-test-debian:
IMAGE: debian
script:
- cd build
- - make NINJA=":" check-venv
+ - make check-venv
- pyvenv/bin/python3 scripts/device-crash-test -q --tcg-only ./qemu-system-i386
build-system-fedora:
@@ -158,7 +158,7 @@ crash-test-fedora:
IMAGE: fedora
script:
- cd build
- - make NINJA=":" check-venv
+ - make check-venv
- pyvenv/bin/python3 scripts/device-crash-test -q ./qemu-system-ppc
- pyvenv/bin/python3 scripts/device-crash-test -q ./qemu-system-riscv32
--
2.51.1
next prev parent reply other threads:[~2025-11-17 18:57 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-17 18:51 [PATCH 00/22] python: drop qemu.qmp from qemu.git tree John Snow
2025-11-17 18:51 ` [PATCH 01/22] python/mkvenv: ensure HAVE_LIB variables are actually constants John Snow
2025-11-18 7:19 ` Thomas Huth
2025-11-17 18:51 ` [PATCH 02/22] python/qapi: add an ignore for Pylint 4.x John Snow
2025-11-18 7:28 ` Thomas Huth
2025-11-17 18:51 ` [PATCH 03/22] python/qapi: delint import statements John Snow
2025-11-18 7:28 ` Thomas Huth
2025-11-17 18:51 ` [PATCH 04/22] python/mkvenv: create timestamp file for each group "ensured" John Snow
2025-11-17 18:51 ` [PATCH 05/22] python/mkvenv: bump 'qemu.qmp' dependency for testdeps John Snow
2025-11-19 9:19 ` Thomas Huth
2025-11-19 21:10 ` John Snow
2025-11-17 18:51 ` [PATCH 06/22] python/mkvenv: rename 'testdeps' to 'functests' John Snow
2025-11-18 10:01 ` Thomas Huth
2025-11-18 18:22 ` John Snow
2025-11-17 18:51 ` [PATCH 07/22] python/mkvenv: add "checktests" dependency group John Snow
2025-11-18 10:01 ` Thomas Huth
2025-11-17 18:51 ` [PATCH 08/22] meson, mkvenv: add checktests and functests custom targets John Snow
2025-11-17 18:51 ` [PATCH 09/22] tests/iotests: Use configured python to run GitLab iotests John Snow
2025-11-18 7:17 ` Thomas Huth
2025-11-18 18:10 ` John Snow
2025-11-17 18:51 ` [PATCH 10/22] tests/iotests: use "make check-venv" to prepare for running iotests John Snow
2025-11-18 9:58 ` Thomas Huth
2025-11-17 18:51 ` [PATCH 11/22] python: add vendored qemu.qmp package John Snow
2025-11-19 9:29 ` Thomas Huth
2025-11-19 21:16 ` John Snow
2025-11-17 18:51 ` [PATCH 12/22] meson, mkvenv: make iotests depend on checktests group John Snow
2025-11-17 18:51 ` [PATCH 13/22] mtest2make: cleanup mtest-suites variables John Snow
2025-11-21 10:24 ` Paolo Bonzini
2025-11-17 18:51 ` [PATCH 14/22] mtest2make: add dependencies to the "speed-qualified" suite John Snow
2025-11-17 18:51 ` [PATCH 15/22] mtest2make: do not repeat the same speed over and over John Snow
2025-11-17 18:51 ` [PATCH 16/22] meson, mkvenv: make functional tests depend on functests group John Snow
2025-11-17 18:51 ` John Snow [this message]
2025-11-17 19:06 ` [PATCH 17/22] tests: forcibly run 'make check-venv' for crash tests Daniel P. Berrangé
2025-11-17 20:47 ` Paolo Bonzini
2025-11-18 21:50 ` John Snow
2025-11-19 8:05 ` Paolo Bonzini
2025-11-19 14:15 ` Thomas Huth
2025-11-19 23:03 ` John Snow
2025-11-17 18:51 ` [PATCH 18/22] python/mkvenv: add mechanism to install local package(s) John Snow
2025-11-17 18:51 ` [PATCH 19/22] mkvenv: add --no-build-isolation flag John Snow
2025-11-17 18:51 ` [PATCH 20/22] meson, mkvenv: add qemu.git/python/qemu package to pythondeps.toml John Snow
2025-11-17 18:51 ` [PATCH 21/22] tests/Makefile: replace old "check-venv" target with meson target John Snow
2025-11-17 18:51 ` [PATCH 22/22] python: delete qemu.qmp John Snow
2025-11-19 9:27 ` Thomas Huth
2025-11-19 21:14 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251117185131.953681-18-jsnow@redhat.com \
--to=jsnow@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=crosa@redhat.com \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=michael.roth@amd.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).