From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: jasowang@redhat.com, mst@redhat.com, berrange@redhat.com
Subject: [PATCH 2/3] ebpf: Clean up useless error check in ebpf_rss_set_all()
Date: Tue, 18 Nov 2025 16:47:17 +0100 [thread overview]
Message-ID: <20251118154718.3969982-3-armbru@redhat.com> (raw)
In-Reply-To: <20251118154718.3969982-1-armbru@redhat.com>
ebpf_rss_set_all() is only called when the context has an eBPF program
loaded. Replace the dead error check with an assertion.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
| 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
--git a/ebpf/ebpf_rss.c b/ebpf/ebpf_rss.c
index e793786c17..b64e9da3e3 100644
--- a/ebpf/ebpf_rss.c
+++ b/ebpf/ebpf_rss.c
@@ -247,10 +247,8 @@ bool ebpf_rss_set_all(struct EBPFRSSContext *ctx, struct EBPFRSSConfig *config,
uint16_t *indirections_table, uint8_t *toeplitz_key,
Error **errp)
{
- if (!ebpf_rss_is_loaded(ctx)) {
- error_setg(errp, "eBPF program is not loaded");
- return false;
- }
+ g_assert(ebpf_rss_is_loaded(ctx));
+
if (config == NULL) {
error_setg(errp, "eBPF config table is NULL");
return false;
--
2.49.0
next prev parent reply other threads:[~2025-11-18 15:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-18 15:47 [PATCH 0/3] ebpf: Error fixes and cleanups Markus Armbruster
2025-11-18 15:47 ` [PATCH 1/3] ebpf: Fix stubs to set an error when they return failure Markus Armbruster
2025-11-18 16:01 ` Daniel P. Berrangé
2025-11-18 15:47 ` Markus Armbruster [this message]
2025-11-18 16:01 ` [PATCH 2/3] ebpf: Clean up useless error check in ebpf_rss_set_all() Daniel P. Berrangé
2025-11-18 15:47 ` [PATCH 3/3] ebpf: Make ebpf_rss_load() return value consistent with @errp Markus Armbruster
2025-11-18 16:03 ` Daniel P. Berrangé
2025-11-18 18:31 ` [PATCH 0/3] ebpf: Error fixes and cleanups Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251118154718.3969982-3-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).