From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, richard.henderson@linaro.org, qemu-devel@nongnu.org
Subject: [PULL 13/19] qcow2: Schedule cache-clean-timer in realtime
Date: Tue, 18 Nov 2025 18:02:50 +0100 [thread overview]
Message-ID: <20251118170256.272087-14-kwolf@redhat.com> (raw)
In-Reply-To: <20251118170256.272087-1-kwolf@redhat.com>
From: Hanna Czenczek <hreitz@redhat.com>
There is no reason why the cache cleaning timer should run in virtual
time, run it in realtime instead.
Suggested-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Hanna Czenczek <hreitz@redhat.com>
Message-ID: <20251110154854.151484-14-hreitz@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
block/qcow2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/qcow2.c b/block/qcow2.c
index 05da589729..e29810d86a 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -846,7 +846,7 @@ static void coroutine_fn cache_clean_timer(void *opaque)
while (wait_ns > 0) {
qemu_co_sleep_ns_wakeable(&s->cache_clean_timer_wake,
- QEMU_CLOCK_VIRTUAL, wait_ns);
+ QEMU_CLOCK_REALTIME, wait_ns);
WITH_QEMU_LOCK_GUARD(&s->lock) {
if (s->cache_clean_interval > 0) {
--
2.51.1
next prev parent reply other threads:[~2025-11-18 17:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-18 17:02 [PULL 00/19] Block layer patches Kevin Wolf
2025-11-18 17:02 ` [PULL 01/19] block: Note on aio_co_wake use if not yet yielding Kevin Wolf
2025-11-18 17:02 ` [PULL 02/19] rbd: Run co BH CB in the coroutine’s AioContext Kevin Wolf
2025-11-18 17:02 ` [PULL 03/19] iscsi: " Kevin Wolf
2025-11-18 17:02 ` [PULL 04/19] nfs: " Kevin Wolf
2025-11-18 17:02 ` [PULL 05/19] curl: Fix coroutine waking Kevin Wolf
2025-11-18 17:02 ` [PULL 06/19] gluster: Do not move coroutine into BDS context Kevin Wolf
2025-11-18 17:02 ` [PULL 07/19] nvme: Kick and check completions in " Kevin Wolf
2025-11-18 17:02 ` [PULL 08/19] nvme: Fix coroutine waking Kevin Wolf
2025-11-18 17:02 ` [PULL 09/19] nvme: Note in which AioContext some functions run Kevin Wolf
2025-11-18 17:02 ` [PULL 10/19] block/io: Take reqs_lock for tracked_requests Kevin Wolf
2025-11-18 17:02 ` [PULL 11/19] qcow2: Re-initialize lock in invalidate_cache Kevin Wolf
2025-11-18 17:02 ` [PULL 12/19] qcow2: Fix cache_clean_timer Kevin Wolf
2025-11-18 17:02 ` Kevin Wolf [this message]
2025-11-18 17:02 ` [PULL 14/19] ssh: Run restart_coroutine in current AioContext Kevin Wolf
2025-11-18 17:02 ` [PULL 15/19] blkreplay: Run BH in coroutine’s AioContext Kevin Wolf
2025-11-18 17:02 ` [PULL 16/19] block: Note in which AioContext AIO CBs are called Kevin Wolf
2025-11-18 17:02 ` [PULL 17/19] iscsi: Create AIO BH in original AioContext Kevin Wolf
2025-11-18 17:02 ` [PULL 18/19] null-aio: Run CB " Kevin Wolf
2025-11-18 17:02 ` [PULL 19/19] win32-aio: Run CB in original context Kevin Wolf
2025-11-19 9:44 ` [PULL 00/19] Block layer patches Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251118170256.272087-14-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).