qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Subject: [PULL 02/18] hw/intc/ioapic: Fix ACCEL_KERNEL_GSI_IRQFD_POSSIBLE typo
Date: Tue, 18 Nov 2025 20:00:37 +0100	[thread overview]
Message-ID: <20251118190053.39015-3-philmd@linaro.org> (raw)
In-Reply-To: <20251118190053.39015-1-philmd@linaro.org>

From: Cédric Le Goater <clg@redhat.com>

Commit 638ac1c78457 introduced a regression in interrupt remapping
when running a VM configured with an intel-iommu device and an
assigned PCI VF. During boot, Linux reports repeated messages :

 [   15.416794] __common_interrupt: 2.37 No irq handler for vector
 [   15.417266] __common_interrupt: 2.37 No irq handler for vector
 [   15.417733] __common_interrupt: 2.37 No irq handler for vector
 [   15.418202] __common_interrupt: 2.37 No irq handler for vector
 [   15.418670] __common_interrupt: 2.37 No irq handler for vector

and may eventually hang.

The issue is caused by the incorrect use of the macro
ACCEL_KERNEL_GSI_IRQFD_POSSIBLE, which should instead be
ACCEL_GSI_IRQFD_POSSIBLE.

Fixes: 638ac1c78457 ("hw/intc: Generalize APIC helper names from kvm_* to accel_*")
Cc: Magnus Kulke <magnuskulke@linux.microsoft.com>
Signed-off-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20251106105148.737093-1-clg@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 hw/intc/ioapic.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/intc/ioapic.c b/hw/intc/ioapic.c
index e431d003117..38e43846486 100644
--- a/hw/intc/ioapic.c
+++ b/hw/intc/ioapic.c
@@ -216,7 +216,7 @@ static void ioapic_update_kvm_routes(IOAPICCommonState *s)
 #endif
 }
 
-#ifdef ACCEL_KERNEL_GSI_IRQFD_POSSIBLE
+#ifdef ACCEL_GSI_IRQFD_POSSIBLE
 static void ioapic_iec_notifier(void *private, bool global,
                                 uint32_t index, uint32_t mask)
 {
@@ -434,7 +434,7 @@ static const MemoryRegionOps ioapic_io_ops = {
 
 static void ioapic_machine_done_notify(Notifier *notifier, void *data)
 {
-#ifdef ACCEL_KERNEL_GSI_IRQFD_POSSIBLE
+#ifdef ACCEL_GSI_IRQFD_POSSIBLE
     IOAPICCommonState *s = container_of(notifier, IOAPICCommonState,
                                         machine_done);
 
-- 
2.51.0



  parent reply	other threads:[~2025-11-18 19:01 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-18 19:00 [PULL 00/18] Misc HW patches for 2025-11-18 Philippe Mathieu-Daudé
2025-11-18 19:00 ` [PULL 01/18] MAINTAINERS: Update David Hildenbrand's email address Philippe Mathieu-Daudé
2025-11-18 19:00 ` Philippe Mathieu-Daudé [this message]
2025-11-18 19:00 ` [PULL 03/18] system/qtest.c: Allow for multiple CHR_EVENT_CLOSED events Philippe Mathieu-Daudé
2025-11-18 19:00 ` [PULL 04/18] hw/sd: Fix incorrect idle state reporting in R1 response for SPI mode Philippe Mathieu-Daudé
2025-11-18 19:00 ` [PULL 05/18] hw/sd: Fix ACMD41 state machine in " Philippe Mathieu-Daudé
2025-11-18 19:00 ` [PULL 06/18] hw/dma/zynq-devcfg: Fix register memory Philippe Mathieu-Daudé
2025-11-18 19:00 ` [PULL 07/18] hw/arm: Re-enable xenpvh machine in qemu-system-arm/aarch64 binaries Philippe Mathieu-Daudé
2025-11-18 19:00 ` [PULL 08/18] hw/sd/sdcard: Avoid confusing address calculation in rpmb_calc_hmac Philippe Mathieu-Daudé
2025-11-18 19:00 ` [PULL 09/18] qga/commands: Include proper Solaris header for getloadavg() Philippe Mathieu-Daudé
2025-11-18 19:00 ` [PULL 10/18] hw/southbridge/lasi: Correct LasiState parent Philippe Mathieu-Daudé
2025-11-18 19:00 ` [PULL 11/18] buildsys: Remove dead 'mips' entry in supported_cpus[] array Philippe Mathieu-Daudé
2025-11-18 19:00 ` [PULL 12/18] migration/rdma: Check ntohll() availability with meson Philippe Mathieu-Daudé
2025-11-18 19:00 ` [PULL 13/18] docs: Correct release of MIPS deprecations / removals Philippe Mathieu-Daudé
2025-11-18 19:00 ` [PULL 14/18] docs: Mention 32-bit PPC host as removed Philippe Mathieu-Daudé
2025-11-18 19:00 ` [PULL 15/18] scripts/checkpatch: Check DEVICE_NATIVE_ENDIAN Philippe Mathieu-Daudé
2025-11-18 19:00 ` [PULL 16/18] ebpf: Fix stubs to set an error when they return failure Philippe Mathieu-Daudé
2025-11-18 19:00 ` [PULL 17/18] ebpf: Clean up useless error check in ebpf_rss_set_all() Philippe Mathieu-Daudé
2025-11-18 19:00 ` [PULL 18/18] ebpf: Make ebpf_rss_load() return value consistent with @errp Philippe Mathieu-Daudé
2025-11-19  9:45 ` [PULL 00/18] Misc HW patches for 2025-11-18 Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251118190053.39015-3-philmd@linaro.org \
    --to=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).