qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Subject: [PULL 06/18] hw/dma/zynq-devcfg: Fix register memory
Date: Tue, 18 Nov 2025 20:00:41 +0100	[thread overview]
Message-ID: <20251118190053.39015-7-philmd@linaro.org> (raw)
In-Reply-To: <20251118190053.39015-1-philmd@linaro.org>

From: Yannick Voßen <y.vossen@beckhoff.com>

Registers are always 32 bit aligned. R_MAX is not the maximum
register address, it is the maximum register number. The memory
size can be determined by 4 * R_MAX.

Currently every register with an offset bigger than 0x40 will be
ignored, because the memory size is set wrong. This effects the
MCTRL register and makes it useless. This commit restores the
correct behaviour.

Cc: qemu-stable@nongnu.org
Fixes: 034c2e69023 ("dma: Add Xilinx Zynq devcfg device model")
Signed-off-by: YannickV <Y.Vossen@beckhoff.com>
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@amd.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20251111102836.212535-9-corvin.koehne@gmail.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 hw/dma/xlnx-zynq-devcfg.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/dma/xlnx-zynq-devcfg.c b/hw/dma/xlnx-zynq-devcfg.c
index 26845713ee5..8141d460338 100644
--- a/hw/dma/xlnx-zynq-devcfg.c
+++ b/hw/dma/xlnx-zynq-devcfg.c
@@ -372,7 +372,7 @@ static void xlnx_zynq_devcfg_init(Object *obj)
                               s->regs_info, s->regs,
                               &xlnx_zynq_devcfg_reg_ops,
                               XLNX_ZYNQ_DEVCFG_ERR_DEBUG,
-                              XLNX_ZYNQ_DEVCFG_R_MAX);
+                              XLNX_ZYNQ_DEVCFG_R_MAX * 4);
     memory_region_add_subregion(&s->iomem,
                                 A_CTRL,
                                 &reg_array->mem);
-- 
2.51.0



  parent reply	other threads:[~2025-11-18 19:02 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-18 19:00 [PULL 00/18] Misc HW patches for 2025-11-18 Philippe Mathieu-Daudé
2025-11-18 19:00 ` [PULL 01/18] MAINTAINERS: Update David Hildenbrand's email address Philippe Mathieu-Daudé
2025-11-18 19:00 ` [PULL 02/18] hw/intc/ioapic: Fix ACCEL_KERNEL_GSI_IRQFD_POSSIBLE typo Philippe Mathieu-Daudé
2025-11-18 19:00 ` [PULL 03/18] system/qtest.c: Allow for multiple CHR_EVENT_CLOSED events Philippe Mathieu-Daudé
2025-11-18 19:00 ` [PULL 04/18] hw/sd: Fix incorrect idle state reporting in R1 response for SPI mode Philippe Mathieu-Daudé
2025-11-18 19:00 ` [PULL 05/18] hw/sd: Fix ACMD41 state machine in " Philippe Mathieu-Daudé
2025-11-18 19:00 ` Philippe Mathieu-Daudé [this message]
2025-11-18 19:00 ` [PULL 07/18] hw/arm: Re-enable xenpvh machine in qemu-system-arm/aarch64 binaries Philippe Mathieu-Daudé
2025-11-18 19:00 ` [PULL 08/18] hw/sd/sdcard: Avoid confusing address calculation in rpmb_calc_hmac Philippe Mathieu-Daudé
2025-11-18 19:00 ` [PULL 09/18] qga/commands: Include proper Solaris header for getloadavg() Philippe Mathieu-Daudé
2025-11-18 19:00 ` [PULL 10/18] hw/southbridge/lasi: Correct LasiState parent Philippe Mathieu-Daudé
2025-11-18 19:00 ` [PULL 11/18] buildsys: Remove dead 'mips' entry in supported_cpus[] array Philippe Mathieu-Daudé
2025-11-18 19:00 ` [PULL 12/18] migration/rdma: Check ntohll() availability with meson Philippe Mathieu-Daudé
2025-11-18 19:00 ` [PULL 13/18] docs: Correct release of MIPS deprecations / removals Philippe Mathieu-Daudé
2025-11-18 19:00 ` [PULL 14/18] docs: Mention 32-bit PPC host as removed Philippe Mathieu-Daudé
2025-11-18 19:00 ` [PULL 15/18] scripts/checkpatch: Check DEVICE_NATIVE_ENDIAN Philippe Mathieu-Daudé
2025-11-18 19:00 ` [PULL 16/18] ebpf: Fix stubs to set an error when they return failure Philippe Mathieu-Daudé
2025-11-18 19:00 ` [PULL 17/18] ebpf: Clean up useless error check in ebpf_rss_set_all() Philippe Mathieu-Daudé
2025-11-18 19:00 ` [PULL 18/18] ebpf: Make ebpf_rss_load() return value consistent with @errp Philippe Mathieu-Daudé
2025-11-19  9:45 ` [PULL 00/18] Misc HW patches for 2025-11-18 Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251118190053.39015-7-philmd@linaro.org \
    --to=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).