From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org
Cc: John Snow <jsnow@redhat.com>, Michael Roth <michael.roth@amd.com>,
Markus Armbruster <armbru@redhat.com>,
Cleber Rosa <crosa@redhat.com>, Thomas Huth <thuth@redhat.com>
Subject: [PATCH 3/3] python/qapi: delint import statements
Date: Tue, 18 Nov 2025 15:06:57 -0500 [thread overview]
Message-ID: <20251118200657.1043688-4-jsnow@redhat.com> (raw)
In-Reply-To: <20251118200657.1043688-1-jsnow@redhat.com>
Missed a spot with isort, which now causes the python-minreqs test on
GitLab to fail. Fix it.
(Hint: the commands in python/tests/qapi-isort.sh can be run without the
"-c" parameter to automatically adjust import statements according to
our style rules. Maybe I should make a pre-submit hook that makes this
adjustment automatically. What do you think?)
Fixes: 5bd89761
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
---
scripts/qapi/commands.py | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/scripts/qapi/commands.py b/scripts/qapi/commands.py
index a82b5a2a5e6..9dede747205 100644
--- a/scripts/qapi/commands.py
+++ b/scripts/qapi/commands.py
@@ -13,10 +13,7 @@
See the COPYING file in the top-level directory.
"""
-from typing import (
- List,
- Optional,
-)
+from typing import List, Optional
from .common import c_name, mcgen
from .gen import (
--
2.51.1
next prev parent reply other threads:[~2025-11-18 20:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-18 20:06 [PATCH 0/3] Python: fix tests John Snow
2025-11-18 20:06 ` [PATCH 1/3] python/mkvenv: ensure HAVE_LIB variables are actually constants John Snow
2025-11-18 20:06 ` [PATCH 2/3] python/qapi: add an ignore for Pylint 4.x John Snow
2025-11-18 20:06 ` John Snow [this message]
2025-11-18 20:24 ` [PATCH 3/3] python/qapi: delint import statements Philippe Mathieu-Daudé
2025-11-19 11:30 ` [PATCH 0/3] Python: fix tests Philippe Mathieu-Daudé
2025-11-19 11:47 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251118200657.1043688-4-jsnow@redhat.com \
--to=jsnow@redhat.com \
--cc=armbru@redhat.com \
--cc=crosa@redhat.com \
--cc=michael.roth@amd.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).