qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org, "John Snow" <jsnow@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Radoslaw Biernacki" <rad@semihalf.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Leif Lindholm" <leif.lindholm@oss.qualcomm.com>,
	"Eric Auger" <eric.auger@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Aurelien Jarno" <aurelien@aurel32.net>,
	"BALATON Zoltan" <balaton@eik.bme.hu>,
	"Glenn Miles" <milesg@linux.ibm.com>,
	"Nicholas Piggin" <npiggin@gmail.com>,
	"Harsh Prateek Bora" <harshpb@linux.ibm.com>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Alistair Francis" <alistair.francis@wdc.com>,
	"Weiwei Li" <liwei1518@gmail.com>,
	"Daniel Henrique Barboza" <dbarboza@ventanamicro.com>,
	"Liu Zhiwei" <zhiwei_liu@linux.alibaba.com>,
	"Zhao Liu" <zhao1.liu@intel.com>,
	"Jiaxun Yang" <jiaxun.yang@flygoat.com>
Subject: [PATCH for-11.0 10/15] tests/functional/ppc/test_ppe42: Fix style issues reported by pylint
Date: Wed, 19 Nov 2025 09:26:31 +0100	[thread overview]
Message-ID: <20251119082636.43286-11-thuth@redhat.com> (raw)
In-Reply-To: <20251119082636.43286-1-thuth@redhat.com>

From: Thomas Huth <thuth@redhat.com>

Pylint suggests to write some parts of the code in a slightly different
way ... thus rework the code to make the linter happy.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 tests/functional/ppc/test_ppe42.py | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/tests/functional/ppc/test_ppe42.py b/tests/functional/ppc/test_ppe42.py
index 26bbe11b2d3..7b360a40a54 100644
--- a/tests/functional/ppc/test_ppe42.py
+++ b/tests/functional/ppc/test_ppe42.py
@@ -6,8 +6,9 @@
 #
 # SPDX-License-Identifier: GPL-2.0-or-later
 
-from qemu_test import QemuSystemTest, Asset
 import asyncio
+from qemu_test import QemuSystemTest, Asset
+
 
 class Ppe42Machine(QemuSystemTest):
 
@@ -30,13 +31,13 @@ def _test_completed(self):
             raise
 
         self.log.info(output)
-        if "NIP fff80200" in output:
-            self.log.info("<test completed>")
-            return True
-        else:
+        if "NIP fff80200" not in output:
             self.log.info("<test not completed>")
             return False
 
+        self.log.info("<test completed>")
+        return True
+
     def _wait_pass_fail(self, timeout):
         while not self._test_completed():
             if timeout >= self.poll_period:
@@ -49,14 +50,13 @@ def _wait_pass_fail(self, timeout):
 
                 except asyncio.TimeoutError:
                     self.log.info("Poll period ended.")
-                    pass
 
                 except Exception as err:
                     self.log.debug(f"event_wait() failed due to {err=},"
                                     " {type(err)=}")
                     raise
 
-                if e != None:
+                if e is not None:
                     self.log.debug(f"Execution stopped: {e}")
                     self.log.debug("Exiting due to test failure")
                     self.fail("Failure detected!")
-- 
2.51.1



  parent reply	other threads:[~2025-11-19  8:28 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-19  8:26 [PATCH for-11.0 00/15] tests/functional: Check Python code with pylint Thomas Huth
2025-11-19  8:26 ` [PATCH for-11.0 01/15] tests/functional: Add a pylintrc file Thomas Huth
2025-11-19  8:26 ` [PATCH for-11.0 02/15] tests/functional/riscv64/test_sifive_u: Remove unused import statement Thomas Huth
2025-11-19  8:26 ` [PATCH for-11.0 03/15] tests/functional/arm/test_aspeed_ast2600_buildroot: Fix pylint warnings Thomas Huth
2025-11-19  8:26 ` [PATCH for-11.0 04/15] tests/functional/x86_64/test_virtio_gpu: Fix various issues reported by pylint Thomas Huth
2025-11-20 15:01   ` Zhao Liu
2025-11-19  8:26 ` [PATCH for-11.0 05/15] tests/functional/mips/test_malta: Silence warnings " Thomas Huth
2025-11-19  8:26 ` [PATCH for-11.0 06/15] tests/functional/ppc64/test_hv: " Thomas Huth
2025-11-19  8:26 ` [PATCH for-11.0 07/15] tests/functional/x86_64/test_reverse_debug: Silence pylint warning Thomas Huth
2025-11-19 10:22   ` Philippe Mathieu-Daudé
2025-11-20 15:01   ` Zhao Liu
2025-11-19  8:26 ` [PATCH for-11.0 08/15] tests/functional/x86_64/test_memlock: Silence pylint warnings Thomas Huth
2025-11-20 10:56   ` Philippe Mathieu-Daudé
2025-11-20 15:02   ` Zhao Liu
2025-11-19  8:26 ` [PATCH for-11.0 09/15] tests/functional/ppc/test_amiga: Fix issues reported by pylint and flake8 Thomas Huth
2025-11-19 10:22   ` Philippe Mathieu-Daudé
2025-11-19  8:26 ` Thomas Huth [this message]
2025-11-19 16:29   ` [PATCH for-11.0 10/15] tests/functional/ppc/test_ppe42: Fix style issues reported by pylint Miles Glenn
2025-11-20 10:55   ` Philippe Mathieu-Daudé
2025-11-19  8:26 ` [PATCH for-11.0 11/15] tests/functional/aarch64/test_virt_gpu: Fix style issues Thomas Huth
2025-11-19  8:26 ` [PATCH for-11.0 12/15] tests/functional/aarch64/test_reverse_debug: Fix issues reported by pylint Thomas Huth
2025-11-19 10:23   ` Philippe Mathieu-Daudé
2025-11-19  8:26 ` [PATCH for-11.0 13/15] tests/functional/aarch64/test_smmu: Silence warning from pylint Thomas Huth
2025-11-19  8:26 ` [PATCH for-11.0 14/15] tests/functional/aarch64/test_rme_sbsaref: Silence issues reported by pylint Thomas Huth
2025-11-19 10:24   ` Philippe Mathieu-Daudé
2025-11-19  8:26 ` [PATCH for-11.0 15/15] tests/functional: Add a generic test that checks the files with pylint Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251119082636.43286-11-thuth@redhat.com \
    --to=thuth@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=alistair.francis@wdc.com \
    --cc=aurelien@aurel32.net \
    --cc=balaton@eik.bme.hu \
    --cc=berrange@redhat.com \
    --cc=dbarboza@ventanamicro.com \
    --cc=eric.auger@redhat.com \
    --cc=harshpb@linux.ibm.com \
    --cc=jiaxun.yang@flygoat.com \
    --cc=jsnow@redhat.com \
    --cc=leif.lindholm@oss.qualcomm.com \
    --cc=liwei1518@gmail.com \
    --cc=milesg@linux.ibm.com \
    --cc=npiggin@gmail.com \
    --cc=palmer@dabbelt.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rad@semihalf.com \
    --cc=zhao1.liu@intel.com \
    --cc=zhiwei_liu@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).