From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, hreitz@redhat.com, mst@redhat.com,
imammedo@redhat.com, anisinha@redhat.com, gengdongjiu1@gmail.com,
peter.maydell@linaro.org, alistair@alistair23.me,
edgar.iglesias@gmail.com, npiggin@gmail.com,
harshpb@linux.ibm.com, palmer@dabbelt.com, liwei1518@gmail.com,
dbarboza@ventanamicro.com, zhiwei_liu@linux.alibaba.com,
sstabellini@kernel.org, anthony@xenproject.org, paul@xen.org,
berrange@redhat.com, peterx@redhat.com, farosas@suse.de,
eblake@redhat.com, vsementsov@yandex-team.ru,
eduardo@habkost.net, marcel.apfelbaum@gmail.com,
philmd@linaro.org, wangyanan55@huawei.com, zhao1.liu@intel.com,
qemu-block@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org,
qemu-riscv@nongnu.org, xen-devel@lists.xenproject.org
Subject: [PATCH 3/5] nbd/client-connection: Replace error_propagate() by assignment
Date: Wed, 19 Nov 2025 14:08:53 +0100 [thread overview]
Message-ID: <20251119130855.105479-4-armbru@redhat.com> (raw)
In-Reply-To: <20251119130855.105479-1-armbru@redhat.com>
connect_thread_func() sets a variable to null, then error_propagate()s
an Error * to it. This is a roundabout way to assign the Error * to
it, so replace it by just that.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
nbd/client-connection.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/nbd/client-connection.c b/nbd/client-connection.c
index 79ea97e4cc..6a4f080717 100644
--- a/nbd/client-connection.c
+++ b/nbd/client-connection.c
@@ -207,8 +207,7 @@ static void *connect_thread_func(void *opaque)
qemu_mutex_lock(&conn->mutex);
error_free(conn->err);
- conn->err = NULL;
- error_propagate(&conn->err, local_err);
+ conn->err = local_err;
if (ret < 0) {
object_unref(OBJECT(conn->sioc));
--
2.49.0
next prev parent reply other threads:[~2025-11-19 13:10 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-19 13:08 [PATCH 0/5] A bit of cleanup around Error Markus Armbruster
2025-11-19 13:08 ` [PATCH 1/5] hw/core/loader: Make load_elf_hdr() return bool, simplify caller Markus Armbruster
2025-11-19 15:37 ` Richard Henderson
2025-11-19 16:34 ` Vladimir Sementsov-Ogievskiy
2025-11-19 19:12 ` Markus Armbruster
2025-11-20 10:51 ` Philippe Mathieu-Daudé
2025-11-19 18:06 ` Peter Xu
2025-11-20 12:04 ` Daniel Henrique Barboza
2025-11-20 12:55 ` BALATON Zoltan
2025-11-20 19:12 ` Markus Armbruster
2025-11-20 14:53 ` Zhao Liu
2025-11-19 13:08 ` [PATCH 2/5] hw/nvram/xlnx-bbram: More idiomatic and simpler error reporting Markus Armbruster
2025-11-19 16:39 ` Vladimir Sementsov-Ogievskiy
2025-11-19 19:10 ` Markus Armbruster
2025-11-19 18:09 ` Peter Xu
2025-11-20 8:10 ` Luc Michel
2025-11-20 14:54 ` Zhao Liu
2025-11-19 13:08 ` Markus Armbruster [this message]
2025-11-19 16:43 ` [PATCH 3/5] nbd/client-connection: Replace error_propagate() by assignment Vladimir Sementsov-Ogievskiy
2025-11-19 18:09 ` Peter Xu
2025-11-20 14:55 ` Zhao Liu
2025-11-19 13:08 ` [PATCH 4/5] error: error_free(NULL) is safe, drop unnecessary conditionals Markus Armbruster
2025-11-19 15:38 ` Richard Henderson
2025-11-19 16:44 ` Vladimir Sementsov-Ogievskiy
2025-11-19 18:04 ` Peter Xu
2025-11-20 14:56 ` Zhao Liu
2025-11-19 13:08 ` [PATCH 5/5] error: Consistently name Error * objects err, and not errp Markus Armbruster
2025-11-19 13:22 ` Andrew Cooper
2025-11-19 13:35 ` Daniel P. Berrangé
2025-11-19 13:48 ` Markus Armbruster
2025-11-20 14:57 ` Zhao Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251119130855.105479-4-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=alistair@alistair23.me \
--cc=anisinha@redhat.com \
--cc=anthony@xenproject.org \
--cc=berrange@redhat.com \
--cc=dbarboza@ventanamicro.com \
--cc=eblake@redhat.com \
--cc=edgar.iglesias@gmail.com \
--cc=eduardo@habkost.net \
--cc=farosas@suse.de \
--cc=gengdongjiu1@gmail.com \
--cc=harshpb@linux.ibm.com \
--cc=hreitz@redhat.com \
--cc=imammedo@redhat.com \
--cc=kwolf@redhat.com \
--cc=liwei1518@gmail.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=npiggin@gmail.com \
--cc=palmer@dabbelt.com \
--cc=paul@xen.org \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=sstabellini@kernel.org \
--cc=vsementsov@yandex-team.ru \
--cc=wangyanan55@huawei.com \
--cc=xen-devel@lists.xenproject.org \
--cc=zhao1.liu@intel.com \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).