qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Cédric Le Goater" <clg@redhat.com>,
	"Magnus Kulke" <magnuskulke@linux.microsoft.com>
Subject: [PULL 01/10] ioapic: fix typo in irqfd check
Date: Thu, 20 Nov 2025 01:16:40 +0100	[thread overview]
Message-ID: <20251120001649.1085913-2-pbonzini@redhat.com> (raw)
In-Reply-To: <20251120001649.1085913-1-pbonzini@redhat.com>

Not registering the IEC notifier results in a regression with interrupt remapping
when running a VM configured with an intel-iommu device and an assigned
PCI VF. At boot, Linux complains with :

[   15.416794] __common_interrupt: 2.37 No irq handler for vector

Reported-by: Cédric Le Goater <clg@redhat.com>
Analyzed-by: Magnus Kulke <magnuskulke@linux.microsoft.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 hw/intc/ioapic.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/intc/ioapic.c b/hw/intc/ioapic.c
index e431d003117..38e43846486 100644
--- a/hw/intc/ioapic.c
+++ b/hw/intc/ioapic.c
@@ -216,7 +216,7 @@ static void ioapic_update_kvm_routes(IOAPICCommonState *s)
 #endif
 }
 
-#ifdef ACCEL_KERNEL_GSI_IRQFD_POSSIBLE
+#ifdef ACCEL_GSI_IRQFD_POSSIBLE
 static void ioapic_iec_notifier(void *private, bool global,
                                 uint32_t index, uint32_t mask)
 {
@@ -434,7 +434,7 @@ static const MemoryRegionOps ioapic_io_ops = {
 
 static void ioapic_machine_done_notify(Notifier *notifier, void *data)
 {
-#ifdef ACCEL_KERNEL_GSI_IRQFD_POSSIBLE
+#ifdef ACCEL_GSI_IRQFD_POSSIBLE
     IOAPICCommonState *s = container_of(notifier, IOAPICCommonState,
                                         machine_done);
 
-- 
2.51.1



  reply	other threads:[~2025-11-20  0:17 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-20  0:16 [PULL 00/10] x86, mtest2make changes for QEMU 10.2 Paolo Bonzini
2025-11-20  0:16 ` Paolo Bonzini [this message]
2025-11-20  0:16 ` [PULL 02/10] target/i386: emulate: Make sure fetch_instruction exist before calling it Paolo Bonzini
2025-11-20  0:16 ` [PULL 03/10] target/i386: Mark VPERMILPS as not valid with prefix 0 Paolo Bonzini
2025-11-20  0:16 ` [PULL 04/10] target/i386/tcg: validate segment registers Paolo Bonzini
2025-11-20  0:16 ` [PULL 05/10] target/i386: svm: fix sign extension of exit code Paolo Bonzini
2025-11-20  0:16 ` [PULL 06/10] target/i386: fix stack size when delivering real mode interrupts Paolo Bonzini
2025-11-20  0:16 ` [PULL 07/10] mtest2make: cleanup mtest-suites variables Paolo Bonzini
2025-11-20  0:16 ` [PULL 08/10] mtest2make: add dependencies to the "speed-qualified" suite Paolo Bonzini
2025-11-20  0:16 ` [PULL 09/10] mtest2make: do not repeat the same speed over and over Paolo Bonzini
2025-11-20  0:16 ` [PULL 10/10] replay: add tracing events Paolo Bonzini
2025-11-20 21:56 ` [PULL 00/10] x86, mtest2make changes for QEMU 10.2 Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251120001649.1085913-2-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=clg@redhat.com \
    --cc=magnuskulke@linux.microsoft.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).