qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Subject: [PULL 06/10] target/i386: fix stack size when delivering real mode interrupts
Date: Thu, 20 Nov 2025 01:16:45 +0100	[thread overview]
Message-ID: <20251120001649.1085913-7-pbonzini@redhat.com> (raw)
In-Reply-To: <20251120001649.1085913-1-pbonzini@redhat.com>

The stack can be 32-bit even in real mode, and in this case
the stack pointer must be updated in its entirety rather than
just the bottom 16 bits.  The same is true of real mode IRET,
for which there was even a comment suggesting the right thing
to do.

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1506
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 target/i386/tcg/seg_helper.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/target/i386/tcg/seg_helper.c b/target/i386/tcg/seg_helper.c
index 667b1c38696..227336c4ef2 100644
--- a/target/i386/tcg/seg_helper.c
+++ b/target/i386/tcg/seg_helper.c
@@ -1161,7 +1161,7 @@ static void do_interrupt_real(CPUX86State *env, int intno, int is_int,
     sa.env = env;
     sa.ra = 0;
     sa.sp = env->regs[R_ESP];
-    sa.sp_mask = 0xffff;
+    sa.sp_mask = get_sp_mask(env->segs[R_SS].flags);
     sa.ss_base = env->segs[R_SS].base;
     sa.mmu_index = x86_mmu_index_pl(env, 0);
 
@@ -1964,7 +1964,7 @@ void helper_iret_real(CPUX86State *env, int shift)
     sa.env = env;
     sa.ra = GETPC();
     sa.mmu_index = x86_mmu_index_pl(env, 0);
-    sa.sp_mask = 0xffff; /* XXXX: use SS segment size? */
+    sa.sp_mask = get_sp_mask(env->segs[R_SS].flags);
     sa.sp = env->regs[R_ESP];
     sa.ss_base = env->segs[R_SS].base;
 
-- 
2.51.1



  parent reply	other threads:[~2025-11-20  0:18 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-20  0:16 [PULL 00/10] x86, mtest2make changes for QEMU 10.2 Paolo Bonzini
2025-11-20  0:16 ` [PULL 01/10] ioapic: fix typo in irqfd check Paolo Bonzini
2025-11-20  0:16 ` [PULL 02/10] target/i386: emulate: Make sure fetch_instruction exist before calling it Paolo Bonzini
2025-11-20  0:16 ` [PULL 03/10] target/i386: Mark VPERMILPS as not valid with prefix 0 Paolo Bonzini
2025-11-20  0:16 ` [PULL 04/10] target/i386/tcg: validate segment registers Paolo Bonzini
2025-11-20  0:16 ` [PULL 05/10] target/i386: svm: fix sign extension of exit code Paolo Bonzini
2025-11-20  0:16 ` Paolo Bonzini [this message]
2025-11-20  0:16 ` [PULL 07/10] mtest2make: cleanup mtest-suites variables Paolo Bonzini
2025-11-20  0:16 ` [PULL 08/10] mtest2make: add dependencies to the "speed-qualified" suite Paolo Bonzini
2025-11-20  0:16 ` [PULL 09/10] mtest2make: do not repeat the same speed over and over Paolo Bonzini
2025-11-20  0:16 ` [PULL 10/10] replay: add tracing events Paolo Bonzini
2025-11-20 21:56 ` [PULL 00/10] x86, mtest2make changes for QEMU 10.2 Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251120001649.1085913-7-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).