From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Richard Henderson" <richard.henderson@linaro.org>,
"Zhao Liu" <zhao1.liu@intel.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PULL 05/10] tests/functional/x86_64/test_memlock: Silence pylint warnings
Date: Fri, 21 Nov 2025 10:38:07 +0100 [thread overview]
Message-ID: <20251121093812.280911-6-thuth@redhat.com> (raw)
In-Reply-To: <20251121093812.280911-1-thuth@redhat.com>
From: Thomas Huth <thuth@redhat.com>
Pylint complains about a missing "encoding" parameter for the open()
function here, and about a missing return statement in the "except"
block (which cannot happen since skipTest() never returns). Rework
the code a little bit to silence the warnings.
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-ID: <20251119082636.43286-9-thuth@redhat.com>
---
tests/functional/x86_64/test_memlock.py | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tests/functional/x86_64/test_memlock.py b/tests/functional/x86_64/test_memlock.py
index 81bce80b0c4..f970a2c3095 100755
--- a/tests/functional/x86_64/test_memlock.py
+++ b/tests/functional/x86_64/test_memlock.py
@@ -69,11 +69,13 @@ def get_process_status_values(self, pid: int) -> Dict[str, int]:
return result
def _get_raw_process_status(self, pid: int) -> str:
+ status = None
try:
- with open(f'/proc/{pid}/status', 'r') as f:
- return f.read()
+ with open(f'/proc/{pid}/status', 'r', encoding="ascii") as f:
+ status = f.read()
except FileNotFoundError:
self.skipTest("Can't open status file of the process")
+ return status
if __name__ == '__main__':
--
2.51.1
next prev parent reply other threads:[~2025-11-21 9:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-21 9:38 [PULL 00/10] Fixes for QEMU v10.2rc2 Thomas Huth
2025-11-21 9:38 ` [PULL 01/10] hw/s390x: Fix a possible crash with passed-through virtio devices Thomas Huth
2025-11-21 9:38 ` [PULL 02/10] tests/functional/arm/test_aspeed_ast2600_buildroot: Fix pylint warnings Thomas Huth
2025-11-21 9:38 ` [PULL 03/10] tests/functional/x86_64/test_virtio_gpu: Fix various issues reported by pylint Thomas Huth
2025-11-21 9:38 ` [PULL 04/10] tests/functional/x86_64/test_reverse_debug: Silence pylint warning Thomas Huth
2025-11-21 9:38 ` Thomas Huth [this message]
2025-11-21 9:38 ` [PULL 06/10] tests/functional/ppc/test_amiga: Fix issues reported by pylint and flake8 Thomas Huth
2025-11-21 9:38 ` [PULL 07/10] tests/functional/ppc/test_ppe42: Fix style issues reported by pylint Thomas Huth
2025-11-21 9:38 ` [PULL 08/10] tests/functional/aarch64/test_reverse_debug: Fix " Thomas Huth
2025-11-21 9:38 ` [PULL 09/10] tests/functional/aarch64/test_rme_sbsaref: Silence " Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251121093812.280911-6-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).