* [PATCH v2] Fix the typo of vfio-pci device's enable-migration option
@ 2025-11-21 9:43 Yanghang Liu
2025-11-21 10:31 ` Cédric Le Goater
2025-11-21 12:47 ` Michael Tokarev
0 siblings, 2 replies; 3+ messages in thread
From: Yanghang Liu @ 2025-11-21 9:43 UTC (permalink / raw)
To: qemu-devel; +Cc: clegoate
Signed-off-by: Yanghang Liu <yanghliu@redhat.com>
Reported-by: Mario Casquero <mcasquer@redhat.com>
---
hw/vfio/pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
index 8b8bc5a421..b46b1305a7 100644
--- a/hw/vfio/pci.c
+++ b/hw/vfio/pci.c
@@ -3871,7 +3871,7 @@ static void vfio_pci_class_init(ObjectClass *klass, const void *data)
"(DEBUG)");
object_class_property_set_description(klass, /* 5.2, 8.0 non-experimetal */
"enable-migration",
- "Enale device migration. Also requires a host VFIO PCI "
+ "Enable device migration. Also requires a host VFIO PCI "
"variant or mdev driver with migration support enabled");
object_class_property_set_description(klass, /* 8.1 */
"vf-token",
--
2.47.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] Fix the typo of vfio-pci device's enable-migration option
2025-11-21 9:43 [PATCH v2] Fix the typo of vfio-pci device's enable-migration option Yanghang Liu
@ 2025-11-21 10:31 ` Cédric Le Goater
2025-11-21 12:47 ` Michael Tokarev
1 sibling, 0 replies; 3+ messages in thread
From: Cédric Le Goater @ 2025-11-21 10:31 UTC (permalink / raw)
To: Yanghang Liu, qemu-devel; +Cc: Mario Casquero
Hello Yanghang,
Please add a 'vfio-pci:' prefix to the subject. Something like :
vfio/pci: Fix documentation of the "enable-migration" property
It is good practice to add a commit log, even (very) short :
The change that introduced documentation for the vfio-pci properties
contained a typo. Fix that.
> Signed-off-by: Yanghang Liu <yanghliu@redhat.com>
> Reported-by: Mario Casquero <mcasquer@redhat.com>
Add
Fixes: 4526687bf126 ("vfio: Add property documentation")
Could please resend a v3 ?
Run ./scripts/get_maintainer.pl to get all recipients.
Thanks,
C.
> ---
> hw/vfio/pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
> index 8b8bc5a421..b46b1305a7 100644
> --- a/hw/vfio/pci.c
> +++ b/hw/vfio/pci.c
> @@ -3871,7 +3871,7 @@ static void vfio_pci_class_init(ObjectClass *klass, const void *data)
> "(DEBUG)");
> object_class_property_set_description(klass, /* 5.2, 8.0 non-experimetal */
> "enable-migration",
> - "Enale device migration. Also requires a host VFIO PCI "
> + "Enable device migration. Also requires a host VFIO PCI "
> "variant or mdev driver with migration support enabled");
> object_class_property_set_description(klass, /* 8.1 */
> "vf-token",
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] Fix the typo of vfio-pci device's enable-migration option
2025-11-21 9:43 [PATCH v2] Fix the typo of vfio-pci device's enable-migration option Yanghang Liu
2025-11-21 10:31 ` Cédric Le Goater
@ 2025-11-21 12:47 ` Michael Tokarev
1 sibling, 0 replies; 3+ messages in thread
From: Michael Tokarev @ 2025-11-21 12:47 UTC (permalink / raw)
To: Yanghang Liu, qemu-devel; +Cc: clegoate, QEMU Trivial
21.11.2025 12:43, Yanghang Liu wrote:
>
> Signed-off-by: Yanghang Liu <yanghliu@redhat.com>
> Reported-by: Mario Casquero <mcasquer@redhat.com>
> ---
> hw/vfio/pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
> index 8b8bc5a421..b46b1305a7 100644
> --- a/hw/vfio/pci.c
> +++ b/hw/vfio/pci.c
> @@ -3871,7 +3871,7 @@ static void vfio_pci_class_init(ObjectClass *klass, const void *data)
> "(DEBUG)");
> object_class_property_set_description(klass, /* 5.2, 8.0 non-experimetal */
> "enable-migration",
> - "Enale device migration. Also requires a host VFIO PCI "
> + "Enable device migration. Also requires a host VFIO PCI "
> "variant or mdev driver with migration support enabled");
> object_class_property_set_description(klass, /* 8.1 */
> "vf-token",
Picked up to the trivial-patches tree.
Thanks!
/mjt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-11-22 3:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-21 9:43 [PATCH v2] Fix the typo of vfio-pci device's enable-migration option Yanghang Liu
2025-11-21 10:31 ` Cédric Le Goater
2025-11-21 12:47 ` Michael Tokarev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).