From: Mohamed Mediouni <mohamed@unpredictable.fr>
To: qemu-devel@nongnu.org, mohamed@unpredictable.fr
Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Alexander Graf" <agraf@csgraf.de>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Phil Dennis-Jordan" <phil@philjordan.eu>,
"Alex Bennée" <alex.bennee@linaro.org>,
qemu-arm@nongnu.org, "Pedro Barbuda" <pbarbuda@microsoft.com>,
"Akihiko Odaki" <odaki@rsg.ci.i.u-tokyo.ac.jp>,
"Peter Xu" <peterx@redhat.com>, "Mads Ynddal" <mads@ynddal.dk>
Subject: [PATCH v11 18/28] hw: arm: virt-acpi-build: add hack
Date: Fri, 21 Nov 2025 11:02:30 +0100 [thread overview]
Message-ID: <20251121100240.89117-19-mohamed@unpredictable.fr> (raw)
In-Reply-To: <20251121100240.89117-1-mohamed@unpredictable.fr>
Looks like in the prior Qemu ACPI table handling, GICv2 configurations
had vms->its=1...
Match that assumption to not make the test suite fail. Probably not merge-worthy...
And then maybe see what to do for older releases too?
Signed-off-by: Mohamed Mediouni <mohamed@unpredictable.fr>
---
hw/arm/virt-acpi-build.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
index 15e6239e5f..f7309cb06f 100644
--- a/hw/arm/virt-acpi-build.c
+++ b/hw/arm/virt-acpi-build.c
@@ -473,7 +473,7 @@ build_iort(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms)
nb_nodes = num_smmus + 1; /* RC and SMMUv3 */
rc_mapping_count = rc_smmu_idmaps_len;
- if (virt_is_its_enabled(vms)) {
+ if (virt_is_its_enabled(vms) || vms->gic_version == 2) {
/*
* Knowing the ID ranges from the RC to the SMMU, it's possible to
* determine the ID ranges from RC that go directly to ITS.
@@ -484,7 +484,7 @@ build_iort(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms)
rc_mapping_count += rc_its_idmaps->len;
}
} else {
- if (virt_is_its_enabled(vms)) {
+ if (virt_is_its_enabled(vms) || vms->gic_version == 2) {
nb_nodes = 2; /* RC and ITS */
rc_mapping_count = 1; /* Direct map to ITS */
} else {
@@ -499,7 +499,7 @@ build_iort(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms)
build_append_int_noprefix(table_data, IORT_NODE_OFFSET, 4);
build_append_int_noprefix(table_data, 0, 4); /* Reserved */
- if (virt_is_its_enabled(vms)) {
+ if (virt_is_its_enabled(vms) || vms->gic_version == 2) {
/* Table 12 ITS Group Format */
build_append_int_noprefix(table_data, 0 /* ITS Group */, 1); /* Type */
node_size = 20 /* fixed header size */ + 4 /* 1 GIC ITS Identifier */;
@@ -518,7 +518,7 @@ build_iort(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms)
int smmu_mapping_count, offset_to_id_array;
int irq = sdev->irq;
- if (virt_is_its_enabled(vms)) {
+ if (virt_is_its_enabled(vms) || vms->gic_version == 2) {
smmu_mapping_count = 1; /* ITS Group node */
offset_to_id_array = SMMU_V3_ENTRY_SIZE; /* Just after the header */
} else {
@@ -611,7 +611,7 @@ build_iort(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms)
}
}
- if (virt_is_its_enabled(vms)) {
+ if (virt_is_its_enabled(vms) || vms->gic_version == 2) {
/*
* Map bypassed (don't go through the SMMU) RIDs (input) to
* ITS Group node directly: RC -> ITS.
--
2.50.1 (Apple Git-155)
next prev parent reply other threads:[~2025-11-21 10:10 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-21 10:02 [PATCH v11 00/28] WHPX support for Arm Mohamed Mediouni
2025-11-21 10:02 ` [PATCH v11 01/28] target/arm/kvm: add constants for new PSCI versions Mohamed Mediouni
2025-11-21 10:02 ` [PATCH v11 02/28] accel/system: Introduce hwaccel_enabled() helper Mohamed Mediouni
2025-11-21 10:02 ` [PATCH v11 03/28] qtest: hw/arm: virt: skip ACPI test for ITS off Mohamed Mediouni
2025-11-21 10:02 ` [PATCH v11 04/28] hw/arm: virt: add GICv2m for the case when ITS is not available Mohamed Mediouni
2025-11-21 10:37 ` Akihiko Odaki
2025-11-21 10:02 ` [PATCH v11 05/28] tests: data: update AArch64 ACPI tables Mohamed Mediouni
2025-11-21 10:02 ` [PATCH v11 06/28] whpx: Move around files before introducing AArch64 support Mohamed Mediouni
2025-11-21 10:02 ` [PATCH v11 07/28] whpx: reshuffle common code Mohamed Mediouni
2025-11-21 10:02 ` [PATCH v11 08/28] whpx: ifdef out winhvemulation on non-x86_64 Mohamed Mediouni
2025-11-21 10:40 ` Akihiko Odaki
2025-11-21 10:02 ` [PATCH v11 09/28] whpx: common: add WHPX_INTERCEPT_DEBUG_TRAPS define Mohamed Mediouni
2025-11-21 10:02 ` [PATCH v11 10/28] hw, target, accel: whpx: change apic_in_platform to kernel_irqchip Mohamed Mediouni
2025-11-21 10:02 ` [PATCH v11 11/28] whpx: switch irqchip in kernel to a bool outside the struct Mohamed Mediouni
2025-11-21 10:49 ` Akihiko Odaki
2025-11-21 10:02 ` [PATCH v11 12/28] whpx: interrupt controller support Mohamed Mediouni
2025-11-21 11:00 ` Akihiko Odaki
2025-11-21 10:02 ` [PATCH v11 13/28] whpx: add arm64 support Mohamed Mediouni
2025-11-21 11:40 ` Akihiko Odaki
2025-11-21 10:02 ` [PATCH v11 14/28] whpx: change memory management logic Mohamed Mediouni
2025-11-21 12:01 ` Akihiko Odaki
2025-11-21 10:02 ` [PATCH v11 15/28] target/arm: cpu: mark WHPX as supporting PSCI 1.3 Mohamed Mediouni
2025-11-21 10:02 ` [PATCH v11 16/28] hw/arm: virt: cleanly fail on attempt to use the platform vGIC together with ITS Mohamed Mediouni
2025-11-21 10:02 ` [PATCH v11 17/28] hw: arm: virt: rework MSI-X configuration Mohamed Mediouni
2025-11-21 12:05 ` Akihiko Odaki
2025-11-21 10:02 ` Mohamed Mediouni [this message]
2025-11-21 10:02 ` [PATCH v11 19/28] docs: arm: update virt machine model description Mohamed Mediouni
2025-11-21 10:02 ` [PATCH v11 20/28] whpx: arm64: clamp down IPA size Mohamed Mediouni
2025-11-21 10:02 ` [PATCH v11 21/28] hw/arm, accel/hvf, whpx: unify get_physical_address_range between WHPX and HVF Mohamed Mediouni
2025-11-21 10:02 ` [PATCH v11 22/28] whpx: arm64: implement -cpu host Mohamed Mediouni
2025-11-21 10:02 ` [PATCH v11 23/28] target/arm: whpx: instantiate GIC early Mohamed Mediouni
2025-11-21 10:02 ` [PATCH v11 24/28] whpx: arm64: gicv3: add migration blocker Mohamed Mediouni
2025-11-21 10:02 ` [PATCH v11 25/28] whpx: enable arm64 builds Mohamed Mediouni
2025-11-21 10:02 ` [PATCH v11 26/28] whpx: apic: use non-deprecated APIs to control interrupt controller state Mohamed Mediouni
2025-11-21 10:02 ` [PATCH v11 27/28] whpx: arm64: check for physical address width after WHPX availability Mohamed Mediouni
2025-11-21 10:02 ` [PATCH v11 28/28] whpx: arm64: add partition-wide reset on the reboot path Mohamed Mediouni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251121100240.89117-19-mohamed@unpredictable.fr \
--to=mohamed@unpredictable.fr \
--cc=agraf@csgraf.de \
--cc=alex.bennee@linaro.org \
--cc=mads@ynddal.dk \
--cc=odaki@rsg.ci.i.u-tokyo.ac.jp \
--cc=pbarbuda@microsoft.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=phil@philjordan.eu \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).