From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: arei.gonglei@huawei.com, zhenwei.pi@linux.dev,
alistair.francis@wdc.com, stefanb@linux.vnet.ibm.com,
kwolf@redhat.com, hreitz@redhat.com, sw@weilnetz.de,
qemu_oss@crudebyte.com, groug@kaod.org, mst@redhat.com,
imammedo@redhat.com, anisinha@redhat.com, kraxel@redhat.com,
shentey@gmail.com, npiggin@gmail.com, harshpb@linux.ibm.com,
sstabellini@kernel.org, anthony@xenproject.org, paul@xen.org,
edgar.iglesias@gmail.com, elena.ufimtseva@oracle.com,
jag.raman@oracle.com, sgarzare@redhat.com, pbonzini@redhat.com,
fam@euphon.net, philmd@linaro.org, alex@shazbot.org,
clg@redhat.com, peterx@redhat.com, farosas@suse.de,
lizhijian@fujitsu.com, dave@treblig.org, jasowang@redhat.com,
samuel.thibault@ens-lyon.org, michael.roth@amd.com,
kkostiuk@redhat.com, zhao1.liu@intel.com, mtosatti@redhat.com,
rathc@linux.ibm.com, palmer@dabbelt.com, liwei1518@gmail.com,
dbarboza@ventanamicro.com, zhiwei_liu@linux.alibaba.com,
marcandre.lureau@redhat.com, qemu-block@nongnu.org,
qemu-ppc@nongnu.org, xen-devel@lists.xenproject.org,
kvm@vger.kernel.org, qemu-riscv@nongnu.org
Subject: [PATCH v2 09/15] blkdebug: Use error_setg_file_open() for a better error message
Date: Fri, 21 Nov 2025 13:14:32 +0100 [thread overview]
Message-ID: <20251121121438.1249498-10-armbru@redhat.com> (raw)
In-Reply-To: <20251121121438.1249498-1-armbru@redhat.com>
The error message changes from
Could not read blkdebug config file: REASON
to
Could not open 'FNAME': REASON
I think the exact file name is more useful to know than the file's
purpose.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
block/blkdebug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/blkdebug.c b/block/blkdebug.c
index c54aee0c84..8a4a8cb85e 100644
--- a/block/blkdebug.c
+++ b/block/blkdebug.c
@@ -288,7 +288,7 @@ static int read_config(BDRVBlkdebugState *s, const char *filename,
if (filename) {
f = fopen(filename, "r");
if (f == NULL) {
- error_setg_errno(errp, errno, "Could not read blkdebug config file");
+ error_setg_file_open(errp, errno, filename);
return -errno;
}
--
2.49.0
next prev parent reply other threads:[~2025-11-22 3:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-21 12:14 [PATCH v2 00/15] Error message improvements Markus Armbruster
2025-11-21 12:14 ` [PATCH v2 01/15] error: Strip trailing '\n' from error string arguments (again) Markus Armbruster
2025-11-21 12:14 ` [PATCH v2 02/15] hw/usb: Convert to qemu_create() for a better error message Markus Armbruster
2025-11-21 12:14 ` [PATCH v2 03/15] ui: Convert to qemu_create() for simplicity and consistency Markus Armbruster
2025-11-21 12:14 ` [PATCH v2 04/15] tap-solaris: Use error_setg_file_open() for better error messages Markus Armbruster
2025-11-21 12:14 ` [PATCH v2 05/15] qga: " Markus Armbruster
2025-11-21 12:14 ` [PATCH v2 06/15] hw/scsi: Use error_setg_file_open() for a better error message Markus Armbruster
2025-11-21 12:14 ` [PATCH v2 07/15] hw/virtio: " Markus Armbruster
2025-11-21 12:14 ` [PATCH v2 08/15] net/tap: " Markus Armbruster
2025-11-21 12:14 ` Markus Armbruster [this message]
2025-11-21 12:14 ` [PATCH v2 10/15] error: Use error_setg_file_open() for simplicity and consistency Markus Armbruster
2025-11-21 12:14 ` [PATCH v2 11/15] net/slirp: Improve file open error message Markus Armbruster
2025-11-21 12:14 ` [PATCH v2 12/15] error: Use error_setg_errno() to improve error messages Markus Armbruster
2025-11-21 12:14 ` [PATCH v2 13/15] error: Use error_setg_errno() for simplicity and consistency Markus Armbruster
2025-11-21 12:14 ` [PATCH v2 14/15] qga/commands-win32: Use error_setg_win32() for better error messages Markus Armbruster
2025-11-21 12:14 ` [PATCH v2 15/15] block/file-win32: Improve an error message Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251121121438.1249498-10-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=alex@shazbot.org \
--cc=alistair.francis@wdc.com \
--cc=anisinha@redhat.com \
--cc=anthony@xenproject.org \
--cc=arei.gonglei@huawei.com \
--cc=clg@redhat.com \
--cc=dave@treblig.org \
--cc=dbarboza@ventanamicro.com \
--cc=edgar.iglesias@gmail.com \
--cc=elena.ufimtseva@oracle.com \
--cc=fam@euphon.net \
--cc=farosas@suse.de \
--cc=groug@kaod.org \
--cc=harshpb@linux.ibm.com \
--cc=hreitz@redhat.com \
--cc=imammedo@redhat.com \
--cc=jag.raman@oracle.com \
--cc=jasowang@redhat.com \
--cc=kkostiuk@redhat.com \
--cc=kraxel@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kwolf@redhat.com \
--cc=liwei1518@gmail.com \
--cc=lizhijian@fujitsu.com \
--cc=marcandre.lureau@redhat.com \
--cc=michael.roth@amd.com \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=npiggin@gmail.com \
--cc=palmer@dabbelt.com \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=qemu_oss@crudebyte.com \
--cc=rathc@linux.ibm.com \
--cc=samuel.thibault@ens-lyon.org \
--cc=sgarzare@redhat.com \
--cc=shentey@gmail.com \
--cc=sstabellini@kernel.org \
--cc=stefanb@linux.vnet.ibm.com \
--cc=sw@weilnetz.de \
--cc=xen-devel@lists.xenproject.org \
--cc=zhao1.liu@intel.com \
--cc=zhenwei.pi@linux.dev \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).