From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 77785CFD36C for ; Tue, 25 Nov 2025 02:36:38 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vNiur-0003BK-F1; Mon, 24 Nov 2025 21:36:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vNiuq-00039I-7U for qemu-devel@nongnu.org; Mon, 24 Nov 2025 21:36:28 -0500 Received: from sender3-pp-f112.zoho.com ([136.143.184.112]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vNiuo-0001DL-Pj for qemu-devel@nongnu.org; Mon, 24 Nov 2025 21:36:27 -0500 ARC-Seal: i=1; a=rsa-sha256; t=1764038174; cv=none; d=zohomail.com; s=zohoarc; b=RtjI8c5uON6c0Fam+dictYbZ/LtlAbWucAhsGIlVoNgShIdr01dWNNxuFwQrHVYyijAkS1HsrhcoWp5yy3565bwGNrEqTVO5NeM1RG/VR/PAvqyhCcQtlMitRkka6IvwMjQ6Bz7ottzR2ppLv7oTEa6ZOQ3y39JBCJppCozot5A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1764038174; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=WpzIRgb3JywbC2cNpX4kON74/oST9ex6TcBqARUwepg=; b=I+i3oB0RSJZPXIWF7q3RB12dM3aUCH7kQNXrcz1HToTre/soY9n/lpCRwyf+oU8hlepAFvS7pRTJDs0UI3ki/GktJDd+VYBv2wEHjDrBnUFvj8Bp/PMkDsm79qG7lW53gT8kqQVJ/g0hStsc5CHDBEA3abTfHETrODME5yEg+7g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=dmitry.osipenko@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1764038174; s=zohomail; d=collabora.com; i=dmitry.osipenko@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To; bh=WpzIRgb3JywbC2cNpX4kON74/oST9ex6TcBqARUwepg=; b=BoZUAbLlENOkqAO0OWUFB7WqUgPNoJVsbvzNscmjisEDndXpumEc1Uh72YVBOHxr TOci8j44Rf/DMZlihWp3mKQUwHECG+zfHt75LzlV62R19bgOACYLJ3o4uc+3KZS/PkV LU5kueVq3Y1kOyM0RDXvR5L91dMYoC08ORXzpx0Q= Received: by mx.zohomail.com with SMTPS id 1764038173075839.3721336161425; Mon, 24 Nov 2025 18:36:13 -0800 (PST) From: Dmitry Osipenko To: Akihiko Odaki , Huang Rui , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Gerd Hoffmann , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Pierre-Eric Pelloux-Prayer , "Michael S . Tsirkin" , Paolo Bonzini , Yiwei Zhang , Sergio Lopez Pascual Cc: Gert Wollny , qemu-devel@nongnu.org, Gurchetan Singh , Alyssa Ross , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Alex Deucher , Stefano Stabellini , =?UTF-8?q?Christian=20K=C3=B6nig?= , Xenia Ragiadakou , Honglei Huang , Julia Zhang , Chen Jiqian , Rob Clark , Robert Beckett Subject: [RFC PATCH v4 3/7] virtio-gpu: Improve virgl_cmd_resource_map_blob() error handling Date: Tue, 25 Nov 2025 05:35:13 +0300 Message-ID: <20251125023517.177714-4-dmitry.osipenko@collabora.com> X-Mailer: git-send-email 2.51.1 In-Reply-To: <20251125023517.177714-1-dmitry.osipenko@collabora.com> References: <20251125023517.177714-1-dmitry.osipenko@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External Received-SPF: pass client-ip=136.143.184.112; envelope-from=dmitry.osipenko@collabora.com; helo=sender3-pp-f112.zoho.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Make virgl_cmd_resource_map_blob() return -1 for errors originated from external virglrenderer library and respond to guest with most appropriate error message. Suggested-by: Akihiko Odaki # guest err msg Signed-off-by: Dmitry Osipenko --- hw/display/virtio-gpu-virgl.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/hw/display/virtio-gpu-virgl.c b/hw/display/virtio-gpu-virgl.c index 2224f59cf5d7..edcdad0af232 100644 --- a/hw/display/virtio-gpu-virgl.c +++ b/hw/display/virtio-gpu-virgl.c @@ -138,7 +138,7 @@ virtio_gpu_virgl_map_resource_blob(VirtIOGPU *g, if (ret) { qemu_log_mask(LOG_GUEST_ERROR, "%s: failed to map virgl resource: %s\n", __func__, strerror(-ret)); - return ret; + return -1; } vmr = g_new0(struct virtio_gpu_virgl_hostmem_region, 1); @@ -789,7 +789,16 @@ static void virgl_cmd_resource_map_blob(VirtIOGPU *g, } ret = virtio_gpu_virgl_map_resource_blob(g, res, mblob.offset); - if (ret) { + + switch (ret) { + case 0: + break; + + case -EINVAL: + cmd->error = VIRTIO_GPU_RESP_ERR_INVALID_PARAMETER; + return; + + default: cmd->error = VIRTIO_GPU_RESP_ERR_UNSPEC; return; } -- 2.51.1