From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 328CECFD374 for ; Tue, 25 Nov 2025 02:36:51 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vNiux-0003RB-VE; Mon, 24 Nov 2025 21:36:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vNiuw-0003LD-4N for qemu-devel@nongnu.org; Mon, 24 Nov 2025 21:36:34 -0500 Received: from sender3-pp-f112.zoho.com ([136.143.184.112]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vNiuu-0001Dv-Iu for qemu-devel@nongnu.org; Mon, 24 Nov 2025 21:36:33 -0500 ARC-Seal: i=1; a=rsa-sha256; t=1764038180; cv=none; d=zohomail.com; s=zohoarc; b=fZv5H6vtwnQ++Gtj8HUG1KdQwwc1AWftOfhBXCIqR1F9vC+D7XEWEbhTe3OeNLtRp/xDfFg31A6vwEizUTo/zBCCkgwHzfki4sjLQSxNG+SZlpAZDTb8fnEC1kesApCMHN/e0/F0j/Rjl4aG2kKGpb5bpKsPjoSVqcF3H0Xjoxw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1764038180; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=Qdj+tk0Rsue/yqFxWL1SxJghCWVN4FohXqseYyvW6ug=; b=ZNMP3YlPU90j/6+yxBkfqBhfQkYssnaKhweYK+zTYoZeiSuxietXuXAeg3/2QA4eH5jZPO2RxB3DCvmjD2OXJwhyC4a99xY3ylS9EyuC380Bpz+MoQdOV0DpKQOc6LEiZoz/m4D4d0ALyiJEhXJ6x56BYaePyGubMQHAzufunjs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=dmitry.osipenko@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1764038180; s=zohomail; d=collabora.com; i=dmitry.osipenko@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To; bh=Qdj+tk0Rsue/yqFxWL1SxJghCWVN4FohXqseYyvW6ug=; b=Bb0aLQgn9lx6+/Ef4rMN2Jm6iUg9Pw1NcNXRTQpsMsWAfMSEMc6ynA8NBujqlTYZ zlnbMOsPl6vz8O27yfHp6JVvNAj6T6FbGzhJLzfI+i7xP0ihLIAkBsHEfjeIuwTMqGK UsSSsgxX35mzXfs+E+S05/LKb5PiNSnaERWTb47E= Received: by mx.zohomail.com with SMTPS id 1764038177942140.1936977372102; Mon, 24 Nov 2025 18:36:17 -0800 (PST) From: Dmitry Osipenko To: Akihiko Odaki , Huang Rui , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Gerd Hoffmann , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Pierre-Eric Pelloux-Prayer , "Michael S . Tsirkin" , Paolo Bonzini , Yiwei Zhang , Sergio Lopez Pascual Cc: Gert Wollny , qemu-devel@nongnu.org, Gurchetan Singh , Alyssa Ross , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Alex Deucher , Stefano Stabellini , =?UTF-8?q?Christian=20K=C3=B6nig?= , Xenia Ragiadakou , Honglei Huang , Julia Zhang , Chen Jiqian , Rob Clark , Robert Beckett Subject: [RFC PATCH v4 4/7] virtio-gpu: Make virtio_gpu_virgl_unmap_resource_blob() return -1 on error Date: Tue, 25 Nov 2025 05:35:14 +0300 Message-ID: <20251125023517.177714-5-dmitry.osipenko@collabora.com> X-Mailer: git-send-email 2.51.1 In-Reply-To: <20251125023517.177714-1-dmitry.osipenko@collabora.com> References: <20251125023517.177714-1-dmitry.osipenko@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External Received-SPF: pass client-ip=136.143.184.112; envelope-from=dmitry.osipenko@collabora.com; helo=sender3-pp-f112.zoho.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Make virtio_gpu_virgl_unmap_resource_blob() return -1 for more consistency of error propagation style in the code, adhering to QEMU's devel/style recommendations and preparing code for further code changes utilizing this function. Signed-off-by: Dmitry Osipenko --- hw/display/virtio-gpu-virgl.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/display/virtio-gpu-virgl.c b/hw/display/virtio-gpu-virgl.c index edcdad0af232..a7b14a312c83 100644 --- a/hw/display/virtio-gpu-virgl.c +++ b/hw/display/virtio-gpu-virgl.c @@ -199,7 +199,7 @@ virtio_gpu_virgl_unmap_resource_blob(VirtIOGPU *g, qemu_log_mask(LOG_GUEST_ERROR, "%s: failed to unmap virgl resource: %s\n", __func__, strerror(-ret)); - return ret; + return -1; } } else { *cmd_suspended = true; @@ -333,7 +333,7 @@ static void virgl_cmd_resource_unref(VirtIOGPU *g, } #if VIRGL_VERSION_MAJOR >= 1 - if (virtio_gpu_virgl_unmap_resource_blob(g, res, cmd_suspended)) { + if (virtio_gpu_virgl_unmap_resource_blob(g, res, cmd_suspended) < 0) { cmd->error = VIRTIO_GPU_RESP_ERR_UNSPEC; return; } @@ -829,7 +829,7 @@ static void virgl_cmd_resource_unmap_blob(VirtIOGPU *g, } ret = virtio_gpu_virgl_unmap_resource_blob(g, res, cmd_suspended); - if (ret) { + if (ret < 0) { cmd->error = VIRTIO_GPU_RESP_ERR_UNSPEC; return; } -- 2.51.1