qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: peterx@redhat.com, farosas@suse.de, peter.maydell@linaro.org
Subject: [PATCH] migration: Fix double-free on error path
Date: Tue, 25 Nov 2025 08:05:54 +0100	[thread overview]
Message-ID: <20251125070554.2256181-1-armbru@redhat.com> (raw)

Fixes: ffaa1b50a879 (migration: Use warn_reportf_err() where appropriate)
Resolves: Coverity CID 1643463
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 migration/multifd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/migration/multifd.c b/migration/multifd.c
index 6210454838..3203dc98e1 100644
--- a/migration/multifd.c
+++ b/migration/multifd.c
@@ -450,7 +450,7 @@ static void multifd_send_set_error(Error *err)
  */
 static void migration_ioc_shutdown_gracefully(QIOChannel *ioc)
 {
-    g_autoptr(Error) local_err = NULL;
+    Error *local_err = NULL;
 
     if (!migration_has_failed(migrate_get_current()) &&
         object_dynamic_cast((Object *)ioc, TYPE_QIO_CHANNEL_TLS)) {
-- 
2.49.0



             reply	other threads:[~2025-11-25  7:06 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-25  7:05 Markus Armbruster [this message]
2025-11-25  7:11 ` [PATCH] migration: Fix double-free on error path Markus Armbruster
2025-11-25 15:41   ` Peter Xu
2025-11-25  7:12 ` Marc-André Lureau
2025-11-25 12:59   ` Markus Armbruster
2025-11-25 15:47     ` Peter Xu
2025-11-25 18:48       ` Markus Armbruster
2025-11-25 19:32         ` Peter Xu
2025-11-26  6:12           ` Should functions that free memory clear the pointer? (was: [PATCH] migration: Fix double-free on error path) Markus Armbruster
2025-11-26  8:21             ` Should functions that free memory clear the pointer? Cédric Le Goater
2025-11-25  7:16 ` [PATCH] migration: Fix double-free on error path Philippe Mathieu-Daudé
2025-11-25  7:40 ` g_autoptr(Error) (was: [PATCH] migration: Fix double-free on error path) Markus Armbruster
2025-11-25 11:25   ` Daniel P. Berrangé
2025-11-25 11:46     ` g_autoptr(Error) Markus Armbruster
2025-11-25 16:15       ` g_autoptr(Error) Peter Xu
2025-11-25 19:02         ` g_autoptr(Error) Markus Armbruster
2025-11-25 20:49           ` g_autoptr(Error) Peter Xu
2025-11-26  8:19         ` g_autoptr(Error) Cédric Le Goater
2025-11-26 10:26           ` g_autoptr(Error) Cédric Le Goater
2025-11-26 11:46             ` g_autoptr(Error) Markus Armbruster
2025-11-26 12:00               ` g_autoptr(Error) Daniel P. Berrangé
2025-11-26 12:41                 ` g_autoptr(Error) Markus Armbruster
2025-11-26 13:27                 ` g_autoptr(Error) Peter Maydell
2025-11-26 14:01                   ` g_autoptr(Error) Markus Armbruster
2025-12-02  8:34 ` [PATCH] migration: Fix double-free on error path Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251125070554.2256181-1-armbru@redhat.com \
    --to=armbru@redhat.com \
    --cc=farosas@suse.de \
    --cc=peter.maydell@linaro.org \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).