From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9563DD0E6C5 for ; Tue, 25 Nov 2025 10:57:11 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vNqhW-0003si-9A; Tue, 25 Nov 2025 05:55:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vNqh7-0003eR-5z for qemu-devel@nongnu.org; Tue, 25 Nov 2025 05:54:51 -0500 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vNqh4-0001PZ-3d for qemu-devel@nongnu.org; Tue, 25 Nov 2025 05:54:48 -0500 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-4775895d69cso22242585e9.0 for ; Tue, 25 Nov 2025 02:54:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764068083; x=1764672883; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FtKth+b9TdPq30wZ/hp2A5R8f47SbZbi440xtKAdXk8=; b=gTyY0jpjKH1pAxxN4P4DyTapD2xBf5LYj5ID7AkL/6uTDCsecOjF4tWED2wQfOuSVk +tw58Sc4VBeuWg0wN36Txoc7FI5mu22J/M7sddl/Z2vCFTRUDSMXykacw5GAAXsuweNF 40I7WXVa++U+O1kIXczxlag0kjtiwMBmuSwwEjhf3MzN2jCkcOt1qAOW7Qkyx7llITK2 qRcSYv7KpUyOC5mgn/79tiAcMNolDzBfeoK/tEMB8FrkbIVwPA1AYw9s13RHkirMWB4N KoNiif67O5R1Dup8kEuykjo7hBXMkZgSAKRCF9mRBr8Kxp34CXEL5qYJdzicQC0dKKNS ef3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764068083; x=1764672883; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=FtKth+b9TdPq30wZ/hp2A5R8f47SbZbi440xtKAdXk8=; b=ncwtjhgVFwHqTydRpR6C5up/gvGInIho8rh1CDosmpzwcibKV6bBojnBYpBo3U+es2 sULcwz2JJCbJPKj30QlpmCeTUhcNabyEx6BeiniXRQ4Mz0qdAR1TItj7PTkbDJo9Alvr njCAY2zic1XDQmZRh+/j87b8zKWNNPPadhGBVRkBSXQoiAfCSXbmoDA5puuDlbik0t54 TctLwmUkQ7E0VVOgM7wrMx5neVXkMklmq65wSZBYq/hk3QuuRzWBuBN2gKjF7f3U6U1h LxeiesDZQsyrmH20mdhwGYq298yyFF+Mc066jf4GfJKHAbufBt/hyfHEDYGCCDoZHsdk SlWw== X-Gm-Message-State: AOJu0YxXFGB2bUulc1Eo0DCPdzf1O2HbVu40qCajFDDbRTNo8uwGEWyP JIzipRXloO/fTknipICYTL2YhzlhZCyC96W3X/cediHBaySMuBYQlu4wiKaPgqVm3eSwvJRVnlC IkFaHOWbHsQ== X-Gm-Gg: ASbGncuchvMYBC6KvtehzuxYmydfyyjeHygbRVqltyVSb5WN4PUOojBgmK/r8Q33b/V a6z8nCjZuNg/rPM78iM12HV1AMsMpFPmddyPAv0AYSgETCwM5MZJxU7kEGH1P2bLdV4l+gbK5br JNVj20/PHLRHPgHGbS5tcvxdWOH2UzJTZKcixCkkDtycnF7hA24JhhT1PkHyM1aqxy7b7o/Htzl XnekTAW5ppg7Xz8B8SrZBA/pOFcBSBAn43O1P+AcGxAEL/pmp0jRvyMcqRJ/onNgDw+fu9qvGZ0 +BHjCNWyUSYyyLbFqkrX2yFTVOvHs6uj/UJBJMM39yK1MIYUM3RxMQCN+uhjOcmJEu6C0zviZPG n5lqdjPCueveqHD68AYHzaI6dvdiAaK9NtGXYHRs/EIFGuYffe9opmc+VE6cnXceKw+KmtQaLM/ zW4xWNlIIz7j01NGroEC6e1zgNQgp92Xmq8EJLcxd4eRZsIhdf+U2pz8zD2beR X-Google-Smtp-Source: AGHT+IFaBvSEQ5Wqbc6MfyEWzq5WR0YZGeylAW80PRB1W31X6BTwbu5A//9Zo6uNtRPEWl1RL3KRcw== X-Received: by 2002:a05:6000:2004:b0:42b:3b8a:308c with SMTP id ffacd0b85a97d-42e0f34fa61mr2380260f8f.42.1764068083482; Tue, 25 Nov 2025 02:54:43 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7fb91f4sm34331366f8f.31.2025.11.25.02.54.42 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 25 Nov 2025 02:54:42 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, qemu-riscv@nongnu.org, Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Brian Cain Subject: [PATCH-for-11.0 01/12] target/hexagon: Use little-endian variant of cpu_ld/st_data*() Date: Tue, 25 Nov 2025 11:54:22 +0100 Message-ID: <20251125105434.92355-2-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251125105434.92355-1-philmd@linaro.org> References: <20251125105434.92355-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::32e; envelope-from=philmd@linaro.org; helo=mail-wm1-x32e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org We only build the Hexagon target using little endianness order, therefore the cpu_ld/st_data*() definitions expand to the little endian declarations. Use the explicit little-endian variants. Mechanical change running: $ tgt=hexagon; \ end=le; \ for op in data mmuidx_ra; do \ for ac in uw sw l q; do \ sed -i -e "s/cpu_ld${ac}_${op}/cpu_ld${ac}_${end}_${op}/" \ $(git grep -l cpu_ target/${tgt}/); \ done; for ac in w l q; do \ sed -i -e "s/cpu_st${ac}_${op}/cpu_st${ac}_${end}_${op}/" \ $(git grep -l cpu_ target/${tgt}/); \ done; done Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Brian Cain --- target/hexagon/macros.h | 6 +++--- target/hexagon/op_helper.c | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/target/hexagon/macros.h b/target/hexagon/macros.h index 088e5961ab7..6c2862a2320 100644 --- a/target/hexagon/macros.h +++ b/target/hexagon/macros.h @@ -519,9 +519,9 @@ static inline TCGv gen_read_ireg(TCGv result, TCGv val, int shift) #define fLOAD(NUM, SIZE, SIGN, EA, DST) MEM_LOAD##SIZE##SIGN(DST, EA) #else #define MEM_LOAD1 cpu_ldub_data_ra -#define MEM_LOAD2 cpu_lduw_data_ra -#define MEM_LOAD4 cpu_ldl_data_ra -#define MEM_LOAD8 cpu_ldq_data_ra +#define MEM_LOAD2 cpu_lduw_le_data_ra +#define MEM_LOAD4 cpu_ldl_le_data_ra +#define MEM_LOAD8 cpu_ldq_le_data_ra #define fLOAD(NUM, SIZE, SIGN, EA, DST) \ do { \ diff --git a/target/hexagon/op_helper.c b/target/hexagon/op_helper.c index e2e80ca7efa..08db1e9c56b 100644 --- a/target/hexagon/op_helper.c +++ b/target/hexagon/op_helper.c @@ -77,13 +77,13 @@ static void commit_store(CPUHexagonState *env, int slot_num, uintptr_t ra) cpu_stb_data_ra(env, va, env->mem_log_stores[slot_num].data32, ra); break; case 2: - cpu_stw_data_ra(env, va, env->mem_log_stores[slot_num].data32, ra); + cpu_stw_le_data_ra(env, va, env->mem_log_stores[slot_num].data32, ra); break; case 4: - cpu_stl_data_ra(env, va, env->mem_log_stores[slot_num].data32, ra); + cpu_stl_le_data_ra(env, va, env->mem_log_stores[slot_num].data32, ra); break; case 8: - cpu_stq_data_ra(env, va, env->mem_log_stores[slot_num].data64, ra); + cpu_stq_le_data_ra(env, va, env->mem_log_stores[slot_num].data64, ra); break; default: g_assert_not_reached(); -- 2.51.0