From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Subject: [PULL 9/9] hw/aspeed/{xdma, rtc, sdhci}: Fix endianness to DEVICE_LITTLE_ENDIAN
Date: Tue, 25 Nov 2025 22:48:01 +0100 [thread overview]
Message-ID: <20251125214802.1929-10-philmd@linaro.org> (raw)
In-Reply-To: <20251125214802.1929-1-philmd@linaro.org>
From: Cédric Le Goater <clg@redhat.com>
When the XDMA, RTC and SDHCI device models of the Aspeed SoCs were
first introduced, their MMIO regions inherited of a DEVICE_NATIVE_ENDIAN
endianness. It should be DEVICE_LITTLE_ENDIAN. Fix that.
Signed-off-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20251125142631.676689-1-clg@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/misc/aspeed_xdma.c | 2 +-
hw/rtc/aspeed_rtc.c | 2 +-
hw/sd/aspeed_sdhci.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/misc/aspeed_xdma.c b/hw/misc/aspeed_xdma.c
index cc03c422b0e..c448ad32ff2 100644
--- a/hw/misc/aspeed_xdma.c
+++ b/hw/misc/aspeed_xdma.c
@@ -113,7 +113,7 @@ static void aspeed_xdma_write(void *opaque, hwaddr addr, uint64_t val,
static const MemoryRegionOps aspeed_xdma_ops = {
.read = aspeed_xdma_read,
.write = aspeed_xdma_write,
- .endianness = DEVICE_NATIVE_ENDIAN,
+ .endianness = DEVICE_LITTLE_ENDIAN,
.valid.min_access_size = 4,
.valid.max_access_size = 4,
};
diff --git a/hw/rtc/aspeed_rtc.c b/hw/rtc/aspeed_rtc.c
index c4feea23a0b..6793e253f47 100644
--- a/hw/rtc/aspeed_rtc.c
+++ b/hw/rtc/aspeed_rtc.c
@@ -131,7 +131,7 @@ static void aspeed_rtc_reset(DeviceState *d)
static const MemoryRegionOps aspeed_rtc_ops = {
.read = aspeed_rtc_read,
.write = aspeed_rtc_write,
- .endianness = DEVICE_NATIVE_ENDIAN,
+ .endianness = DEVICE_LITTLE_ENDIAN,
};
static const VMStateDescription vmstate_aspeed_rtc = {
diff --git a/hw/sd/aspeed_sdhci.c b/hw/sd/aspeed_sdhci.c
index fc38ad39ce1..f5c0c4956aa 100644
--- a/hw/sd/aspeed_sdhci.c
+++ b/hw/sd/aspeed_sdhci.c
@@ -124,7 +124,7 @@ static void aspeed_sdhci_write(void *opaque, hwaddr addr, uint64_t val,
static const MemoryRegionOps aspeed_sdhci_ops = {
.read = aspeed_sdhci_read,
.write = aspeed_sdhci_write,
- .endianness = DEVICE_NATIVE_ENDIAN,
+ .endianness = DEVICE_LITTLE_ENDIAN,
.valid.min_access_size = 4,
.valid.max_access_size = 4,
};
--
2.51.0
next prev parent reply other threads:[~2025-11-25 21:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-25 21:47 [PULL 0/9] Misc HW patches for 2025-11-25 Philippe Mathieu-Daudé
2025-11-25 21:47 ` [PULL 1/9] qtest: Allow and ignore blank lines in input Philippe Mathieu-Daudé
2025-11-25 21:47 ` [PULL 2/9] hw/pci: Make msix_init take a uint32_t for nentries Philippe Mathieu-Daudé
2025-11-25 21:47 ` [PULL 3/9] docs/deprecated: Remove undeprecated SMP description Philippe Mathieu-Daudé
2025-11-25 21:47 ` [PULL 4/9] hw/usb: Convert to qemu_create() for a better error message Philippe Mathieu-Daudé
2025-11-25 21:47 ` [PULL 5/9] hw/scsi: Use error_setg_file_open() " Philippe Mathieu-Daudé
2025-11-25 21:47 ` [PULL 6/9] hw/virtio: " Philippe Mathieu-Daudé
2025-11-25 21:47 ` [PULL 7/9] replay: Improve assert in replay_char_read_all_load() Philippe Mathieu-Daudé
2025-11-25 21:48 ` [PULL 8/9] hw/core/machine: Provide a description for aux-ram-share property Philippe Mathieu-Daudé
2025-11-25 21:48 ` Philippe Mathieu-Daudé [this message]
2025-11-25 23:23 ` [PULL 0/9] Misc HW patches for 2025-11-25 Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251125214802.1929-10-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).