qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Subject: [PULL 4/9] hw/usb: Convert to qemu_create() for a better error message
Date: Tue, 25 Nov 2025 22:47:56 +0100	[thread overview]
Message-ID: <20251125214802.1929-5-philmd@linaro.org> (raw)
In-Reply-To: <20251125214802.1929-1-philmd@linaro.org>

From: Markus Armbruster <armbru@redhat.com>

The error message changes from

    open FILENAME failed

to

    Could not create 'FILENAME': REASON

where REASON is the value of strerror(errno).

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20251121121438.1249498-3-armbru@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 hw/usb/bus.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/hw/usb/bus.c b/hw/usb/bus.c
index 8dd2ce415eb..714e33989f4 100644
--- a/hw/usb/bus.c
+++ b/hw/usb/bus.c
@@ -259,10 +259,9 @@ static void usb_qdev_realize(DeviceState *qdev, Error **errp)
     }
 
     if (dev->pcap_filename) {
-        int fd = qemu_open_old(dev->pcap_filename,
-                               O_CREAT | O_WRONLY | O_TRUNC | O_BINARY, 0666);
+        int fd = qemu_create(dev->pcap_filename,
+                             O_WRONLY | O_TRUNC | O_BINARY, 0666, errp);
         if (fd < 0) {
-            error_setg(errp, "open %s failed", dev->pcap_filename);
             usb_qdev_unrealize(qdev);
             return;
         }
-- 
2.51.0



  parent reply	other threads:[~2025-11-25 21:49 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-25 21:47 [PULL 0/9] Misc HW patches for 2025-11-25 Philippe Mathieu-Daudé
2025-11-25 21:47 ` [PULL 1/9] qtest: Allow and ignore blank lines in input Philippe Mathieu-Daudé
2025-11-25 21:47 ` [PULL 2/9] hw/pci: Make msix_init take a uint32_t for nentries Philippe Mathieu-Daudé
2025-11-25 21:47 ` [PULL 3/9] docs/deprecated: Remove undeprecated SMP description Philippe Mathieu-Daudé
2025-11-25 21:47 ` Philippe Mathieu-Daudé [this message]
2025-11-25 21:47 ` [PULL 5/9] hw/scsi: Use error_setg_file_open() for a better error message Philippe Mathieu-Daudé
2025-11-25 21:47 ` [PULL 6/9] hw/virtio: " Philippe Mathieu-Daudé
2025-11-25 21:47 ` [PULL 7/9] replay: Improve assert in replay_char_read_all_load() Philippe Mathieu-Daudé
2025-11-25 21:48 ` [PULL 8/9] hw/core/machine: Provide a description for aux-ram-share property Philippe Mathieu-Daudé
2025-11-25 21:48 ` [PULL 9/9] hw/aspeed/{xdma, rtc, sdhci}: Fix endianness to DEVICE_LITTLE_ENDIAN Philippe Mathieu-Daudé
2025-11-25 23:23 ` [PULL 0/9] Misc HW patches for 2025-11-25 Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251125214802.1929-5-philmd@linaro.org \
    --to=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).