From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 611A8D10384 for ; Wed, 26 Nov 2025 07:51:40 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vOAJ2-00015f-EF; Wed, 26 Nov 2025 02:51:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vOAIC-0000W4-Uw for qemu-devel@nongnu.org; Wed, 26 Nov 2025 02:50:26 -0500 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vOAI9-0003PA-QE for qemu-devel@nongnu.org; Wed, 26 Nov 2025 02:50:24 -0500 Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-42b427cda88so4299343f8f.0 for ; Tue, 25 Nov 2025 23:50:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764143420; x=1764748220; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=idPfVbwdmuwP3E4rOS4isKmneb6eqTi31QSmeF+nOd0=; b=VUVx0g9JkPS6h+kxN+ZJYns9cQ4r4S/3q0HFTaGjwZzJSNsz/HyHKY21JSv1yT9Cp9 FfF9vuoZRPmXK2nAcI5e4mnHoI43wuG46zYxvHnfXmoC92wz21+jrilfqfStuLici6uC 9RI7bBaCFgEOFhQzzKWYtd+jFgUSNMHoV0rieWf0qqafid302BwC2LYQnHV1WIJFt7Mz 2zsjMiFYMSHF7qqT1lgVH5tZzY0RhrAMXFgb7JxLNQAXaWSOfn6v3zMdKO5v0Ug7/hYX U/KrnU8Y8unbWQ+D19qYLLat6BNKimYR3I1neTqs8Mg2T0bgNLK8ckGOpMF6Kp+RKmor YwLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764143420; x=1764748220; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=idPfVbwdmuwP3E4rOS4isKmneb6eqTi31QSmeF+nOd0=; b=kIjGVIYH4SMbRzCjPkc9w+ZR3PkB5ABUIQqHF6223FtW+wgSO6OL4kSHh0M4sSVfwc gbYmAYvAZG1gH6Vcv4SjLl/OKKrbsTAOL0B9UYdF2zc3ZIemFQBMcSnwVU6Q77gybtpe zANGUYpF63cZXIYjl97Bk6qbA6vykGLKORlr3EQm0oCyZ2mnUZSfcpCTks1LKfkWv3Ch +f7R+luQkS/NZW2ULCUROX7BK34PYCPEbrSQfJS2j95KEq6mqTt9OSvV+fLSsv5KeHus sz7CJ/0ij54p0CwDwOyGwmF3CGUNlZu3ozV/FFVxW0m/XKBxyGphUQOiKKJ8Y4PHasq8 HxFQ== X-Gm-Message-State: AOJu0YwnUUAEfUFZ2bv6c95OheplMQ8yWNWdWcL091PvAZ2gCZghIjtx 1eL/YYLEQkVJs1p998Slb2NyKhKZ/VutCHAsZBu1s70E7IYoaAUz8/nSzXNYYWE+LzxAoUio2jH F+EfxLfSfkQ== X-Gm-Gg: ASbGncsRsF9b09B2+dsYYvjDx9SpYMFqSEhmwJLCG4hPK0BFxKrIh3vMYIE5jUCiNxD VoMyNl3pXMm/tfMSNipM2aI9qf03RFJYXxQze+YQASZu8AfQBmVLlQ4dFCer3TwYLz07NDz9+Xb 4KqYnbWenBkG9kEranZlAcj3UucSWWQvn3x8gfH5kAYdXx81Ykcua4tDCcJcScLPYig20zAngZR iNzGDXvU6DyRuz1PDex+aKQYfze0069jJycsoOMFBkyUku4tyrMDlgz/o2hbE4EUdu5e4aE86Wt eGW3gqjQV4WNiHGnF6QG9+eGTvs3FxdqFLW8wJ6ZyDCEyRrIC9xGItZaW+cFbL+jWUmesgG/Qdb 3xCSJUEXomNnoLNnbB0CgsdNQh2kc4VbhQNfAj6/iqPjcJqfi1srDwU4ECg4BO8f8T+2ZZMksES lDKbvK6embhiALPt8tuI00mV1WuMYMPahZ1XFq1FwHmtX2V0QaXbpalywJtUX7 X-Google-Smtp-Source: AGHT+IFqpM8TIbsX9+OktdGWynr78Kv86N6nuOEDGHi9XeiZ/g0BxOANv1L9qpRHDbEceeh2G1vVRA== X-Received: by 2002:a05:6000:2883:b0:42b:3806:2ba6 with SMTP id ffacd0b85a97d-42cc1cbce07mr19755082f8f.25.1764143419945; Tue, 25 Nov 2025 23:50:19 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7f3635bsm39401408f8f.17.2025.11.25.23.50.18 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 25 Nov 2025 23:50:18 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, qemu-riscv@nongnu.org, Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Helge Deller Subject: [PATCH-for-11.0 v2 02/12] target/hppa: Use little-endian variant of cpu_ld/st_data*() Date: Wed, 26 Nov 2025 08:49:53 +0100 Message-ID: <20251126075003.4826-3-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251126075003.4826-1-philmd@linaro.org> References: <20251126075003.4826-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=philmd@linaro.org; helo=mail-wr1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org We only build the HPPA target using little endianness order, therefore the cpu_ld/st_data*() definitions expand to the little endian declarations. Use the explicit little-endian variants. Mechanical change running: $ tgt=hppa; \ end=be; \ for op in data mmuidx_ra; do \ for ac in uw sw l q; do \ sed -i -e "s/cpu_ld${ac}_${op}/cpu_ld${ac}_${end}_${op}/" \ $(git grep -l cpu_ target/${tgt}/); \ done; for ac in w l q; do \ sed -i -e "s/cpu_st${ac}_${op}/cpu_st${ac}_${end}_${op}/" \ $(git grep -l cpu_ target/${tgt}/); \ done; done Signed-off-by: Philippe Mathieu-Daudé --- target/hppa/op_helper.c | 44 ++++++++++++++++++++--------------------- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/target/hppa/op_helper.c b/target/hppa/op_helper.c index 0458378abb2..65faf03cd0a 100644 --- a/target/hppa/op_helper.c +++ b/target/hppa/op_helper.c @@ -107,7 +107,7 @@ static void do_stby_b(CPUHPPAState *env, target_ulong addr, target_ulong val, cpu_stb_data_ra(env, addr, val, ra); break; case 2: - cpu_stw_data_ra(env, addr, val, ra); + cpu_stw_be_data_ra(env, addr, val, ra); break; case 1: /* The 3 byte store must appear atomic. */ @@ -115,11 +115,11 @@ static void do_stby_b(CPUHPPAState *env, target_ulong addr, target_ulong val, atomic_store_mask32(env, addr, val, 0x00ffffffu, ra); } else { cpu_stb_data_ra(env, addr, val >> 16, ra); - cpu_stw_data_ra(env, addr + 1, val, ra); + cpu_stw_be_data_ra(env, addr + 1, val, ra); } break; default: - cpu_stl_data_ra(env, addr, val, ra); + cpu_stl_be_data_ra(env, addr, val, ra); break; } } @@ -132,7 +132,7 @@ static void do_stdby_b(CPUHPPAState *env, target_ulong addr, uint64_t val, cpu_stb_data_ra(env, addr, val, ra); break; case 6: - cpu_stw_data_ra(env, addr, val, ra); + cpu_stw_be_data_ra(env, addr, val, ra); break; case 5: /* The 3 byte store must appear atomic. */ @@ -140,11 +140,11 @@ static void do_stdby_b(CPUHPPAState *env, target_ulong addr, uint64_t val, atomic_store_mask32(env, addr, val, 0x00ffffffu, ra); } else { cpu_stb_data_ra(env, addr, val >> 16, ra); - cpu_stw_data_ra(env, addr + 1, val, ra); + cpu_stw_be_data_ra(env, addr + 1, val, ra); } break; case 4: - cpu_stl_data_ra(env, addr, val, ra); + cpu_stl_be_data_ra(env, addr, val, ra); break; case 3: /* The 5 byte store must appear atomic. */ @@ -152,7 +152,7 @@ static void do_stdby_b(CPUHPPAState *env, target_ulong addr, uint64_t val, atomic_store_mask64(env, addr, val, 0x000000ffffffffffull, 5, ra); } else { cpu_stb_data_ra(env, addr, val >> 32, ra); - cpu_stl_data_ra(env, addr + 1, val, ra); + cpu_stl_be_data_ra(env, addr + 1, val, ra); } break; case 2: @@ -160,8 +160,8 @@ static void do_stdby_b(CPUHPPAState *env, target_ulong addr, uint64_t val, if (parallel) { atomic_store_mask64(env, addr, val, 0x0000ffffffffffffull, 6, ra); } else { - cpu_stw_data_ra(env, addr, val >> 32, ra); - cpu_stl_data_ra(env, addr + 2, val, ra); + cpu_stw_be_data_ra(env, addr, val >> 32, ra); + cpu_stl_be_data_ra(env, addr + 2, val, ra); } break; case 1: @@ -170,12 +170,12 @@ static void do_stdby_b(CPUHPPAState *env, target_ulong addr, uint64_t val, atomic_store_mask64(env, addr, val, 0x00ffffffffffffffull, 7, ra); } else { cpu_stb_data_ra(env, addr, val >> 48, ra); - cpu_stw_data_ra(env, addr + 1, val >> 32, ra); - cpu_stl_data_ra(env, addr + 3, val, ra); + cpu_stw_be_data_ra(env, addr + 1, val >> 32, ra); + cpu_stl_be_data_ra(env, addr + 3, val, ra); } break; default: - cpu_stq_data_ra(env, addr, val, ra); + cpu_stq_be_data_ra(env, addr, val, ra); break; } } @@ -211,12 +211,12 @@ static void do_stby_e(CPUHPPAState *env, target_ulong addr, target_ulong val, if (parallel) { atomic_store_mask32(env, addr - 3, val, 0xffffff00u, ra); } else { - cpu_stw_data_ra(env, addr - 3, val >> 16, ra); + cpu_stw_be_data_ra(env, addr - 3, val >> 16, ra); cpu_stb_data_ra(env, addr - 1, val >> 8, ra); } break; case 2: - cpu_stw_data_ra(env, addr - 2, val >> 16, ra); + cpu_stw_be_data_ra(env, addr - 2, val >> 16, ra); break; case 1: cpu_stb_data_ra(env, addr - 1, val >> 24, ra); @@ -239,8 +239,8 @@ static void do_stdby_e(CPUHPPAState *env, target_ulong addr, uint64_t val, atomic_store_mask64(env, addr - 7, val, 0xffffffffffffff00ull, 7, ra); } else { - cpu_stl_data_ra(env, addr - 7, val >> 32, ra); - cpu_stw_data_ra(env, addr - 3, val >> 16, ra); + cpu_stl_be_data_ra(env, addr - 7, val >> 32, ra); + cpu_stw_be_data_ra(env, addr - 3, val >> 16, ra); cpu_stb_data_ra(env, addr - 1, val >> 8, ra); } break; @@ -250,8 +250,8 @@ static void do_stdby_e(CPUHPPAState *env, target_ulong addr, uint64_t val, atomic_store_mask64(env, addr - 6, val, 0xffffffffffff0000ull, 6, ra); } else { - cpu_stl_data_ra(env, addr - 6, val >> 32, ra); - cpu_stw_data_ra(env, addr - 2, val >> 16, ra); + cpu_stl_be_data_ra(env, addr - 6, val >> 32, ra); + cpu_stw_be_data_ra(env, addr - 2, val >> 16, ra); } break; case 5: @@ -260,24 +260,24 @@ static void do_stdby_e(CPUHPPAState *env, target_ulong addr, uint64_t val, atomic_store_mask64(env, addr - 5, val, 0xffffffffff000000ull, 5, ra); } else { - cpu_stl_data_ra(env, addr - 5, val >> 32, ra); + cpu_stl_be_data_ra(env, addr - 5, val >> 32, ra); cpu_stb_data_ra(env, addr - 1, val >> 24, ra); } break; case 4: - cpu_stl_data_ra(env, addr - 4, val >> 32, ra); + cpu_stl_be_data_ra(env, addr - 4, val >> 32, ra); break; case 3: /* The 3 byte store must appear atomic. */ if (parallel) { atomic_store_mask32(env, addr - 3, val >> 32, 0xffffff00u, ra); } else { - cpu_stw_data_ra(env, addr - 3, val >> 48, ra); + cpu_stw_be_data_ra(env, addr - 3, val >> 48, ra); cpu_stb_data_ra(env, addr - 1, val >> 40, ra); } break; case 2: - cpu_stw_data_ra(env, addr - 2, val >> 48, ra); + cpu_stw_be_data_ra(env, addr - 2, val >> 48, ra); break; case 1: cpu_stb_data_ra(env, addr - 1, val >> 56, ra); -- 2.51.0