From: Igor Mammedov <imammedo@redhat.com>
To: Gavin Shan <gshan@redhat.com>
Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org,
mchehab+huawei@kernel.org, jonathan.cameron@huawei.com,
armbru@redhat.com, mst@redhat.com, anisinha@redhat.com,
gengdongjiu1@gmail.com, peter.maydell@linaro.org,
pbonzini@redhat.com, shan.gavin@gmail.com
Subject: Re: [PATCH 3/5] target/arm/kvm: Exit on error from acpi_ghes_memory_errors()
Date: Fri, 28 Nov 2025 15:07:21 +0100 [thread overview]
Message-ID: <20251128150721.390604e9@imammedo> (raw)
In-Reply-To: <20251127004435.2098335-4-gshan@redhat.com>
On Thu, 27 Nov 2025 10:44:33 +1000
Gavin Shan <gshan@redhat.com> wrote:
> A core dump is no sense as there isn't programming bugs related to
> errors from acpi_ghes_memory_errors().
>
> Exit instead of abort when the function returns errors, and the
> excessive error message is also dropped.
>
> Suggested-by: Igor Mammedov <imammedo@redhat.com>
> Suggested-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Gavin Shan <gshan@redhat.com>
> ---
> target/arm/kvm.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/target/arm/kvm.c b/target/arm/kvm.c
> index 0d57081e69..acda0b3fb4 100644
> --- a/target/arm/kvm.c
> +++ b/target/arm/kvm.c
> @@ -2460,8 +2460,7 @@ void kvm_arch_on_sigbus_vcpu(CPUState *c, int code, void *addr)
> paddr)) {
> kvm_inject_arm_sea(c);
> } else {
> - error_report("failed to record the error");
so with message gone, user will just see qemu silently exit?
> - abort();
> + exit(1);
> }
> }
> return;
next prev parent reply other threads:[~2025-11-28 14:08 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-27 0:44 [PATCH 0/5] acpi/ghes: Error object handling improvement Gavin Shan
2025-11-27 0:44 ` [PATCH 1/5] acpi/ghes: Automate data block cleanup in acpi_ghes_memory_errors() Gavin Shan
2025-11-27 8:06 ` Markus Armbruster
2025-12-01 9:32 ` Igor Mammedov
2025-11-27 0:44 ` [PATCH 2/5] acpi/ghes: Abort in acpi_ghes_memory_errors() if necessary Gavin Shan
2025-12-01 9:37 ` Igor Mammedov
2025-11-27 0:44 ` [PATCH 3/5] target/arm/kvm: Exit on error from acpi_ghes_memory_errors() Gavin Shan
2025-11-28 14:07 ` Igor Mammedov [this message]
2025-11-28 14:54 ` Markus Armbruster
2025-12-01 10:06 ` Igor Mammedov
2025-11-27 0:44 ` [PATCH 4/5] acpi/ghes: Bail early on error from get_ghes_source_offsets() Gavin Shan
2025-11-27 8:10 ` Markus Armbruster
2025-12-01 10:10 ` Igor Mammedov
2025-12-01 14:15 ` Gavin Shan
2025-11-27 0:44 ` [PATCH 5/5] acpi/ghes: Use error_fatal in acpi_ghes_memory_errors() Gavin Shan
2025-11-27 8:14 ` Markus Armbruster
2025-11-29 1:23 ` Gavin Shan
2025-12-01 10:12 ` Igor Mammedov
2025-11-28 14:09 ` [PATCH 0/5] acpi/ghes: Error object handling improvement Igor Mammedov
2025-11-29 1:21 ` Gavin Shan
2025-12-01 9:31 ` Igor Mammedov
2025-12-01 12:17 ` Mauro Carvalho Chehab
2025-12-01 14:13 ` Gavin Shan
2025-12-01 14:31 ` Mauro Carvalho Chehab
2025-12-01 14:37 ` Gavin Shan
2025-12-02 12:10 ` Igor Mammedov
2025-12-02 13:20 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251128150721.390604e9@imammedo \
--to=imammedo@redhat.com \
--cc=anisinha@redhat.com \
--cc=armbru@redhat.com \
--cc=gengdongjiu1@gmail.com \
--cc=gshan@redhat.com \
--cc=jonathan.cameron@huawei.com \
--cc=mchehab+huawei@kernel.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=shan.gavin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).