* [PATCH 2/2] hw/9pfs: Correct typo
@ 2025-12-02 13:21 AlanoSong
2025-12-02 19:53 ` Thomas Huth
2025-12-03 12:12 ` Christian Schoenebeck
0 siblings, 2 replies; 4+ messages in thread
From: AlanoSong @ 2025-12-02 13:21 UTC (permalink / raw)
To: qemu-devel; +Cc: sstabellini, anthony, Alano Song
Correct comment typo in xen_9pfs_bh()
Signed-off-by: Alano Song <AlanoSong@163.com>
---
hw/9pfs/xen-9p-backend.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/9pfs/xen-9p-backend.c b/hw/9pfs/xen-9p-backend.c
index 79359d911a..ca0fff5fa9 100644
--- a/hw/9pfs/xen-9p-backend.c
+++ b/hw/9pfs/xen-9p-backend.c
@@ -310,7 +310,7 @@ static void xen_9pfs_bh(void *opaque)
again:
wait = ring->co != NULL && qemu_coroutine_entered(ring->co);
- /* paired with the smb_wmb barriers in xen_9pfs_init_in_iov_from_pdu */
+ /* paired with the smp_wmb barriers in xen_9pfs_init_in_iov_from_pdu */
smp_rmb();
if (wait) {
cpu_relax();
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 2/2] hw/9pfs: Correct typo
2025-12-02 13:21 [PATCH 2/2] hw/9pfs: Correct typo AlanoSong
@ 2025-12-02 19:53 ` Thomas Huth
2025-12-03 12:12 ` Christian Schoenebeck
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Huth @ 2025-12-02 19:53 UTC (permalink / raw)
To: AlanoSong, qemu-devel; +Cc: sstabellini, anthony, QEMU Trivial
On 02/12/2025 14.21, AlanoSong@163.com wrote:
> Correct comment typo in xen_9pfs_bh()
>
> Signed-off-by: Alano Song <AlanoSong@163.com>
> ---
> hw/9pfs/xen-9p-backend.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/9pfs/xen-9p-backend.c b/hw/9pfs/xen-9p-backend.c
> index 79359d911a..ca0fff5fa9 100644
> --- a/hw/9pfs/xen-9p-backend.c
> +++ b/hw/9pfs/xen-9p-backend.c
> @@ -310,7 +310,7 @@ static void xen_9pfs_bh(void *opaque)
>
> again:
> wait = ring->co != NULL && qemu_coroutine_entered(ring->co);
> - /* paired with the smb_wmb barriers in xen_9pfs_init_in_iov_from_pdu */
> + /* paired with the smp_wmb barriers in xen_9pfs_init_in_iov_from_pdu */
> smp_rmb();
> if (wait) {
> cpu_relax();
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 2/2] hw/9pfs: Correct typo
2025-12-02 13:21 [PATCH 2/2] hw/9pfs: Correct typo AlanoSong
2025-12-02 19:53 ` Thomas Huth
@ 2025-12-03 12:12 ` Christian Schoenebeck
2025-12-03 13:25 ` Alano Song
1 sibling, 1 reply; 4+ messages in thread
From: Christian Schoenebeck @ 2025-12-03 12:12 UTC (permalink / raw)
To: qemu-devel
Cc: sstabellini, anthony, Alano Song, AlanoSong, QEMU Trivial,
Thomas Huth
On Tuesday, 2 December 2025 14:21:32 CET AlanoSong@163.com wrote:
> Correct comment typo in xen_9pfs_bh()
>
> Signed-off-by: Alano Song <AlanoSong@163.com>
Please send a set of associated patches with a cover letter next time. It
makes it easier for people when they are threaded together.
I assume this patch can also be pushed through qemu-trivial, so:
Reviewed-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
Otherwise let me know and I'll push it through my 9p queue.
/Christian
> ---
> hw/9pfs/xen-9p-backend.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/9pfs/xen-9p-backend.c b/hw/9pfs/xen-9p-backend.c
> index 79359d911a..ca0fff5fa9 100644
> --- a/hw/9pfs/xen-9p-backend.c
> +++ b/hw/9pfs/xen-9p-backend.c
> @@ -310,7 +310,7 @@ static void xen_9pfs_bh(void *opaque)
>
> again:
> wait = ring->co != NULL && qemu_coroutine_entered(ring->co);
> - /* paired with the smb_wmb barriers in xen_9pfs_init_in_iov_from_pdu */
> + /* paired with the smp_wmb barriers in xen_9pfs_init_in_iov_from_pdu
> */ smp_rmb();
> if (wait) {
> cpu_relax();
^ permalink raw reply [flat|nested] 4+ messages in thread* Re:Re: [PATCH 2/2] hw/9pfs: Correct typo
2025-12-03 12:12 ` Christian Schoenebeck
@ 2025-12-03 13:25 ` Alano Song
0 siblings, 0 replies; 4+ messages in thread
From: Alano Song @ 2025-12-03 13:25 UTC (permalink / raw)
To: Christian Schoenebeck
Cc: qemu-devel, sstabellini, anthony, QEMU Trivial, Thomas Huth
[-- Attachment #1: Type: text/plain, Size: 1289 bytes --]
At 2025-12-03 20:12:30, "Christian Schoenebeck" <qemu_oss@crudebyte.com> wrote:
>On Tuesday, 2 December 2025 14:21:32 CET AlanoSong@163.com wrote:
>> Correct comment typo in xen_9pfs_bh()
>>
>> Signed-off-by: Alano Song <AlanoSong@163.com>
>
>Please send a set of associated patches with a cover letter next time. It
>makes it easier for people when they are threaded together.
>
>I assume this patch can also be pushed through qemu-trivial, so:
>
>Reviewed-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
>
>Otherwise let me know and I'll push it through my 9p queue.
>
>/Christian
>
Sorry for the oversight, I'll be more careful next time.
>> ---
>> hw/9pfs/xen-9p-backend.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/9pfs/xen-9p-backend.c b/hw/9pfs/xen-9p-backend.c
>> index 79359d911a..ca0fff5fa9 100644
>> --- a/hw/9pfs/xen-9p-backend.c
>> +++ b/hw/9pfs/xen-9p-backend.c
>> @@ -310,7 +310,7 @@ static void xen_9pfs_bh(void *opaque)
>>
>> again:
>> wait = ring->co != NULL && qemu_coroutine_entered(ring->co);
>> - /* paired with the smb_wmb barriers in xen_9pfs_init_in_iov_from_pdu */
>> + /* paired with the smp_wmb barriers in xen_9pfs_init_in_iov_from_pdu
>> */ smp_rmb();
>> if (wait) {
>> cpu_relax();
>
>
[-- Attachment #2: Type: text/html, Size: 1709 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-12-03 13:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-02 13:21 [PATCH 2/2] hw/9pfs: Correct typo AlanoSong
2025-12-02 19:53 ` Thomas Huth
2025-12-03 12:12 ` Christian Schoenebeck
2025-12-03 13:25 ` Alano Song
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).