From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4788BD116F3 for ; Wed, 3 Dec 2025 06:11:58 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vQg3v-00056N-Sm; Wed, 03 Dec 2025 01:10:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vQg3t-00053w-E1 for qemu-devel@nongnu.org; Wed, 03 Dec 2025 01:10:01 -0500 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vQg3r-0000kY-Jj for qemu-devel@nongnu.org; Wed, 03 Dec 2025 01:10:01 -0500 Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-42e2e08b27eso1630187f8f.1 for ; Tue, 02 Dec 2025 22:09:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764742198; x=1765346998; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cHfjTNJ4DNmllXF9FNZFtldAjCRS1zE4NJobhra0HGY=; b=l2XigEqQdz92EICntFS7uhYFuWKDekkNXp4+Vm3ukZIMM8Jp2mcLJ9tpZVZ6A6EbGm G0bctUVU9OiTZnyPfVw7EP9HzoRaSeJVnYdwLokypPGvYQ7KdJVvM2GkZ2noc3qAkBav XEdxuH/L0oFV+ZRAueVzasMUv0R9M/pQI3QuOWgE/QrXHLfdzCWNhDXwDUxixv8ua9mv dE2ABc6adSs7O/sMPRhA/Mat7sE+w/ut4kxzqsJXyp8Q07gW5uTvBpXXW5MnWJ/D1acW 89WN4XFJF0hEfr46GNE7vBVH8LzRFBUaaENlxSahJFMN4Et6cq7Z7OwFWZ9oJQjPSKhI t2+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764742198; x=1765346998; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=cHfjTNJ4DNmllXF9FNZFtldAjCRS1zE4NJobhra0HGY=; b=ZknVkMVK4jeouqgPElGDZgkHQpAiY3LpFPoel9l5DzlNHUU77D8VEh5Wb6qX0mF8Z4 t8Ih1SsZ+BZ1ARPm376zuNIK8uGm+Fvs2kOZ2n2N1yXKKBzdLZxEMEcMnmmMteGrBADr Fx0BQeZEX93gFInriDb9Glvrm9h/cQMi1GmXj1iXsZND3cRK7hR8DuVXTw1WQr3UxCME pCBenw2azkfLs8KN45s16oQi3bri9v0SmWDxPXbppJYMk+7nyH9vmBUYJsCcg4lAxTwK zFdSpATX19IHNCB9JKx01vlD/gcWI6d1xatF8C2YsHQt6L6EM1gmS1WBbxhQsGNRyj2J Us+g== X-Forwarded-Encrypted: i=1; AJvYcCUH3+1D7UyY9U/Gz9OEVuwVod7NxQYmQkAXjFOOR5SMEz4widlzxM1kW1W9lW5D6nImynkXuxuqg3b/@nongnu.org X-Gm-Message-State: AOJu0YzdTdepWOczLaEsbr0wFpO1E5XRfZINs24VAFmh4DvMp3ph+kWv xfhtEmwQbDppidAwHVntymMXB1jLbfAEC7l+OU8tMC9gaVfjxRR9VO2YtZnfLainawobg4ZNMWu Dw32qwRE= X-Gm-Gg: ASbGncuG/BSEVOWy6tkGE0aIxB22TjBYYpyj3z6zPL9ZTQ835MfIy0CoLaz8+vY/5aL trJAgzfpQiPwk8eRj6vQkUPLmZWCZr5kS14k4PQX5pQflvB9aJVOcN/UZLkHfH8mVhcbrSy8Lpi +zyPcMLngpS3lXYZYqFlfhsDIcVq+JOuP6xVflwe70+GV+6PD+8gWsUjFou1EDPEG7SFuT8piXu XUTdQhjRIuAGDCNBf7dK2fAAo7/acDoy+j9M20L87lhSafBvQ0Gly5BF0SBHaXHxZpcax9Z/rkd YAR8Dk7YXr9bwM0lLhoiGHbCouXambpchlzhRjQMeVrurtRF1qgxwopvfiF2baGnnHGYu7TKePh hsDTgjEU/ye88silidm5yg1MK5gl3sKnM1kjwaSS2dGQ86dZEwpUxD9FbGqvDkOJOtFcaPxkc3A wxQScwFemELEUXTPB4mw+WwKKfsPZd6fe7uS+IL2aAUietp4Q/wkDxg5dB0oId X-Google-Smtp-Source: AGHT+IEXrG8Si7AT2Cc6U+aSqmTwXk/o9+TllQfQZrLykuMH28UNBbl33EUUCCsdH3rcHz/u08XJnQ== X-Received: by 2002:a05:6000:184a:b0:42b:4185:e590 with SMTP id ffacd0b85a97d-42f731d18f4mr829824f8f.58.1764742198168; Tue, 02 Dec 2025 22:09:58 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42e1c5d6133sm40172746f8f.16.2025.12.02.22.09.57 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 02 Dec 2025 22:09:57 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Zhao Liu , qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, Igor Mammedov , Xiaoyao Li , Mark Cave-Ayland , qemu-riscv@nongnu.org, qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Artyom Tarasenko Subject: [PATCH-for-11.0 v6 02/13] hw/sparc/sun4m: Use fw_cfg_init_mem_nodma() Date: Wed, 3 Dec 2025 07:09:30 +0100 Message-ID: <20251203060942.57851-3-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251203060942.57851-1-philmd@linaro.org> References: <20251203060942.57851-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::42e; envelope-from=philmd@linaro.org; helo=mail-wr1-x42e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Use fw_cfg_init_mem_nodma() instead of open-coding it. Signed-off-by: Philippe Mathieu-Daudé --- hw/sparc/sun4m.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/hw/sparc/sun4m.c b/hw/sparc/sun4m.c index 53d7ae08ae9..85c8d727594 100644 --- a/hw/sparc/sun4m.c +++ b/hw/sparc/sun4m.c @@ -1051,17 +1051,7 @@ static void sun4m_hw_init(MachineState *machine) ecc_init(hwdef->ecc_base, slavio_irq[28], hwdef->ecc_version); - dev = qdev_new(TYPE_FW_CFG_MEM); - fw_cfg = FW_CFG(dev); - qdev_prop_set_uint32(dev, "data_width", 1); - qdev_prop_set_bit(dev, "dma_enabled", false); - object_property_add_child(OBJECT(qdev_get_machine()), TYPE_FW_CFG, - OBJECT(fw_cfg)); - s = SYS_BUS_DEVICE(dev); - sysbus_realize_and_unref(s, &error_fatal); - sysbus_mmio_map(s, 0, CFG_ADDR); - sysbus_mmio_map(s, 1, CFG_ADDR + 2); - + fw_cfg = fw_cfg_init_mem_nodma(CFG_ADDR, CFG_ADDR + 2, 1); fw_cfg_add_i16(fw_cfg, FW_CFG_NB_CPUS, (uint16_t)smp_cpus); fw_cfg_add_i16(fw_cfg, FW_CFG_MAX_CPUS, (uint16_t)max_cpus); fw_cfg_add_i64(fw_cfg, FW_CFG_RAM_SIZE, (uint64_t)machine->ram_size); -- 2.51.0