From: "Cédric Le Goater" <clg@redhat.com>
To: qemu-devel@nongnu.org
Cc: "John Levon" <john.levon@nutanix.com>,
"Cédric Le Goater" <clg@redhat.com>,
"Mark Cave-Ayland" <mark.caveayland@nutanix.com>
Subject: [PULL 3/6] vfio-user: clarify partial message handling
Date: Wed, 3 Dec 2025 16:12:46 +0100 [thread overview]
Message-ID: <20251203151249.2707207-4-clg@redhat.com> (raw)
In-Reply-To: <20251203151249.2707207-1-clg@redhat.com>
From: John Levon <john.levon@nutanix.com>
Improve a comment for this.
Signed-off-by: John Levon <john.levon@nutanix.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>
Link: https://lore.kernel.org/qemu-devel/20251203100316.3604456-3-john.levon@nutanix.com
Signed-off-by: Cédric Le Goater <clg@redhat.com>
---
hw/vfio-user/proxy.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/hw/vfio-user/proxy.c b/hw/vfio-user/proxy.c
index 75845d7c89ecbc2534c6f1e3271d6a0dfff8e5cb..82c76c66654a1b7e03b281bdac5f602846b33ac6 100644
--- a/hw/vfio-user/proxy.c
+++ b/hw/vfio-user/proxy.c
@@ -362,7 +362,10 @@ static int vfio_user_recv_one(VFIOUserProxy *proxy, Error **errp)
while (msgleft > 0) {
ret = qio_channel_read(proxy->ioc, data, msgleft, errp);
- /* prepare to complete read on next iternation */
+ /*
+ * We'll complete this read on the next go around; keep track of the
+ * partial message until then.
+ */
if (ret == QIO_CHANNEL_ERR_BLOCK) {
proxy->part_recv = msg;
proxy->recv_left = msgleft;
--
2.52.0
next prev parent reply other threads:[~2025-12-03 15:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-03 15:12 [PULL 0/6] vfio queue Cédric Le Goater
2025-12-03 15:12 ` [PULL 1/6] docs/interop/vfio-user: update protocol specification Cédric Le Goater
2025-12-03 15:12 ` [PULL 2/6] vfio-user: simplify vfio_user_process() Cédric Le Goater
2025-12-03 15:12 ` Cédric Le Goater [this message]
2025-12-03 15:12 ` [PULL 4/6] vfio-user: refactor out header handling Cédric Le Goater
2025-12-03 15:12 ` [PULL 5/6] vfio-user: simplify vfio_user_recv_one() Cédric Le Goater
2025-12-03 15:12 ` [PULL 6/6] vfio-user: recycle msg on failure Cédric Le Goater
2025-12-04 19:37 ` [PULL 0/6] vfio queue Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251203151249.2707207-4-clg@redhat.com \
--to=clg@redhat.com \
--cc=john.levon@nutanix.com \
--cc=mark.caveayland@nutanix.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).