From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Alexandre Iooss" <erdnaxe@crans.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Markus Armbruster" <armbru@redhat.com>,
"Mahmoud Mandour" <ma.mandourr@gmail.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Pierrick Bouvier" <pierrick.bouvier@linaro.org>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Julian Ganz" <neither@nut.email>
Subject: [PATCH v2 11/11] plugins/core: allow reading of registers during discon events
Date: Thu, 4 Dec 2025 19:49:02 +0000 [thread overview]
Message-ID: <20251204194902.1340008-12-alex.bennee@linaro.org> (raw)
In-Reply-To: <20251204194902.1340008-1-alex.bennee@linaro.org>
We have protections that prevent callbacks that didn't declare
themselves as wanting to access registers. However for discontinuities
the system state is fully rectified so they should always be able to
read the register values.
a1688bc86ce (plugins: add hooks for new discontinuity related callbacks)
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Cc: Julian Ganz <neither@nut.email>
---
plugins/core.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/plugins/core.c b/plugins/core.c
index 8f8bc7219c2..b4b783008f7 100644
--- a/plugins/core.c
+++ b/plugins/core.c
@@ -119,6 +119,7 @@ static void plugin_vcpu_cb__discon(CPUState *cpu,
struct qemu_plugin_cb *cb, *next;
uint64_t to = cpu->cc->get_pc(cpu);
+ qemu_plugin_set_cb_flags(cpu, QEMU_PLUGIN_CB_RW_REGS);
if (cpu->cpu_index < plugin.num_vcpus) {
/* iterate safely; plugins might uninstall themselves at any time */
QLIST_FOREACH_SAFE_RCU(cb, &plugin.cb_lists[ev], entry, next) {
@@ -127,6 +128,7 @@ static void plugin_vcpu_cb__discon(CPUState *cpu,
func(cb->ctx->id, cpu->cpu_index, type, from, to);
}
}
+ qemu_plugin_set_cb_flags(cpu, QEMU_PLUGIN_CB_NO_REGS);
}
/*
--
2.47.3
prev parent reply other threads:[~2025-12-04 19:50 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-04 19:48 [PATCH v2 00/11] Final fixes for 10.2 (build, docs, dockerfiles, plugins) Alex Bennée
2025-12-04 19:48 ` [PATCH v2 01/11] gitlab: drop --disable-pie from aarch64-all-linux-static build Alex Bennée
2025-12-05 7:53 ` Thomas Huth
2025-12-04 19:48 ` [PATCH v2 02/11] gitlab: drop explicit pxe-test from the build-tci job Alex Bennée
2025-12-05 7:54 ` Thomas Huth
2025-12-04 19:48 ` [PATCH v2 03/11] tests/tcg: honour the available QEMU binaries when running check-tcg Alex Bennée
2025-12-04 19:48 ` [PATCH v2 04/11] tests/lcitool: add bzip2 to the minimal dependency list Alex Bennée
2025-12-05 6:14 ` Thomas Huth
2025-12-04 19:48 ` [PATCH v2 05/11] tests/lcitool: add nettle to the minimal deps Alex Bennée
2025-12-05 6:37 ` Thomas Huth
2025-12-05 12:48 ` Alex Bennée
2025-12-08 9:11 ` Daniel P. Berrangé
2025-12-08 9:17 ` Thomas Huth
2025-12-04 19:48 ` [PATCH v2 06/11] tests/docker: transition debian-all-test-cross to lcitool Alex Bennée
2025-12-04 19:48 ` [PATCH v2 07/11] tests/docker: drop --disable-[tools|system] from all-test-cross Alex Bennée
2025-12-05 6:40 ` Thomas Huth
2025-12-04 19:48 ` [PATCH v2 08/11] docs/devel: update build environment setup documentation Alex Bennée
2025-12-04 19:49 ` [PATCH v2 09/11] docs/devel: Correct typo Alex Bennée
2025-12-08 9:21 ` Philippe Mathieu-Daudé
2025-12-04 19:49 ` [PATCH v2 10/11] MAINTAINERS: update the custom runner entries Alex Bennée
2025-12-05 6:09 ` Thomas Huth
2025-12-08 9:20 ` Philippe Mathieu-Daudé
2025-12-04 19:49 ` Alex Bennée [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251204194902.1340008-12-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=erdnaxe@crans.org \
--cc=ma.mandourr@gmail.com \
--cc=neither@nut.email \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).