From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 76FAED3B7DE for ; Mon, 8 Dec 2025 07:54:07 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vSW3r-0008Dj-2P; Mon, 08 Dec 2025 02:53:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vSW3p-0008D6-DB for qemu-devel@nongnu.org; Mon, 08 Dec 2025 02:53:33 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vSW3n-0001nb-Th for qemu-devel@nongnu.org; Mon, 08 Dec 2025 02:53:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1765180410; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=5FCNdQc5rek9IhJxh9mu71vmxwNVngIrfmjR/BH34BQ=; b=HEgvuSzVHH+8eBq6tHCKcjtkHmADQrd1oKtRb2vyudrKLuFsIyHEbNsf9LvPK64vmLwvqJ c7+QQbXdm0Ga+nPTQe8V2gIX93lAsM1m6snNYlI+fkEeyaJg/oirFDyAUvBpxJfF5Llgub VVSh1PtlNUOFeCwaIy/NzqcLEKmtk0o= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-635-ez9VM8r7PZCEO3dc-DJw-A-1; Mon, 08 Dec 2025 02:53:27 -0500 X-MC-Unique: ez9VM8r7PZCEO3dc-DJw-A-1 X-Mimecast-MFC-AGG-ID: ez9VM8r7PZCEO3dc-DJw-A_1765180406 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A7F471956061; Mon, 8 Dec 2025 07:53:25 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.44.22.8]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 330BA1956095; Mon, 8 Dec 2025 07:53:21 +0000 (UTC) From: Thomas Huth To: Kevin Wolf , qemu-block@nongnu.org, Eric Blake Cc: qemu-devel@nongnu.org, Hanna Reitz , Fiona Ebner , qemu-trivial@nongnu.org Subject: [PATCH] tests/qemu-iotests: Fix check for existing file in _require_disk_usage() Date: Mon, 8 Dec 2025 08:53:20 +0100 Message-ID: <20251208075320.35682-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.01, RCVD_IN_SBL_CSS=3.335, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org From: Thomas Huth Looks like the "$" has been forgotten here to get the contents of the FILENAME variable. Fixes: c49dda7254d ("iotests: Filter out ZFS in several tests") Signed-off-by: Thomas Huth --- tests/qemu-iotests/common.rc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc index 10d83d8361b..c0f8f0f8dfa 100644 --- a/tests/qemu-iotests/common.rc +++ b/tests/qemu-iotests/common.rc @@ -1008,7 +1008,7 @@ _require_disk_usage() else FILENAME="$TEST_IMG_FILE" fi - if [ -e "FILENAME" ]; then + if [ -e "$FILENAME" ]; then echo "unwilling to overwrite existing file" exit 1 fi -- 2.52.0