From: frank.chang@sifive.com
To: qemu-devel@nongnu.org
Cc: Palmer Dabbelt <palmer@dabbelt.com>,
Alistair Francis <alistair.francis@wdc.com>,
Weiwei Li <liwei1518@gmail.com>,
Daniel Henrique Barboza <dbarboza@ventanamicro.com>,
Liu Zhiwei <zhiwei_liu@linux.alibaba.com>,
qemu-riscv@nongnu.org (open list:RISC-V TCG CPUs),
Frank Chang <frank.chang@sifive.com>
Subject: [PATCH v3 0/6] Fix Zjpm implementation
Date: Fri, 12 Dec 2025 00:38:19 +0800 [thread overview]
Message-ID: <20251211163826.3998266-1-frank.chang@sifive.com> (raw)
From: Frank Chang <frank.chang@sifive.com>
The current Zjpm implementation has the following issues:
1. The address is shifted before obtaining the correct PMLEN value.
2. riscv_pm_get_pmm() does not handle effective privilege mode correctly.
3. mstatus.MPRV does not affect virtual-machine load/store instructions.
4. Sign extension for virtual-machine load/store instructions (HLV.* and
HSV.*) must be performed when vsatp.MODE != Bare.
This patchset fixes the above issues and also renames
riscv_pm_get_virt_pmm() to riscv_pm_get_vm_ldst_pmm(), as the helper
is only used when checking the PMM configuration for virtual-machine
load/store instructions, rather than for VS/VU modes.
Changelog:
v3:
* Move riscv_cpu_eff_priv() to the header file and declare it as a
static inline function.
* Fix the MXR check bugs pointed out by Radim Krčmář.
v2:
* Check effective privilege mode in riscv_pm_get_pmm().
* Fix pointer masking for virtual-machine load/store instructions
(HLV.* and HSV.*).
* Rename riscv_pm_get_virt_pmm() to riscv_pm_get_vm_ldst_pmm().
Frank Chang (5):
target/riscv: Add a helper to return the current effective priv mode
target/riscv: Fix pointer masking PMM field selection logic
target/riscv: Fix pointer masking for virtual-machine load/store insns
target/riscv: Rename riscv_pm_get_virt_pmm() to
riscv_pm_get_vm_ldst_pmm()
target/riscv: Fix pointer masking translation mode check bug
Yong-Xuan Wang (1):
target/riscv: fix address masking
target/riscv/cpu.h | 41 +++++++++++++-
target/riscv/cpu_helper.c | 110 +++++++++++++++++++++++++++----------
target/riscv/internals.h | 8 +--
target/riscv/tcg/tcg-cpu.c | 4 +-
4 files changed, 124 insertions(+), 39 deletions(-)
--
2.43.0
next reply other threads:[~2025-12-11 16:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-11 16:38 frank.chang [this message]
2025-12-11 16:38 ` [PATCH v3 1/6] target/riscv: fix address masking frank.chang
2025-12-11 16:38 ` [PATCH v3 2/6] target/riscv: Add a helper to return the current effective priv mode frank.chang
2025-12-11 16:38 ` [PATCH v3 3/6] target/riscv: Fix pointer masking PMM field selection logic frank.chang
2025-12-11 16:38 ` [PATCH v3 4/6] target/riscv: Fix pointer masking for virtual-machine load/store insns frank.chang
2025-12-11 16:38 ` [PATCH v3 5/6] target/riscv: Rename riscv_pm_get_virt_pmm() to riscv_pm_get_vm_ldst_pmm() frank.chang
2025-12-11 16:38 ` [PATCH v3 6/6] target/riscv: Fix pointer masking translation mode check bug frank.chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251211163826.3998266-1-frank.chang@sifive.com \
--to=frank.chang@sifive.com \
--cc=alistair.francis@wdc.com \
--cc=dbarboza@ventanamicro.com \
--cc=liwei1518@gmail.com \
--cc=palmer@dabbelt.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).