From: Matthew Penney <matt@matthewpenney.net>
To: qemu-devel@nongnu.org
Cc: "Matthew Penney" <matt@matthewpenney.net>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
lvivier@redhat.com, amit@kernel.org,
"Michael S. Tsirkin" <mst@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: [PATCH v2] hw/char: clear dangling GLib event source tag
Date: Thu, 05 Mar 2026 21:33:32 +0000 [thread overview]
Message-ID: <20260305213308.96441-1-matt@matthewpenney.net> (raw)
Clear dangling GLib event source tag when virtio-console is
unrealized. This prevents a stale tag from being used, and
maintains consistency with the rest of virtio-console.
v2:
Use g_clear_handle_id() per advice from Marc-André Lureau
Signed-off-by: Matthew Penney <matt@matthewpenney.net>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
hw/char/virtio-console.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/char/virtio-console.c b/hw/char/virtio-console.c
index 25db0f019b..efe7cd6772 100644
--- a/hw/char/virtio-console.c
+++ b/hw/char/virtio-console.c
@@ -257,7 +257,7 @@ static void virtconsole_unrealize(DeviceState *dev)
VirtConsole *vcon = VIRTIO_CONSOLE(dev);
if (vcon->watch) {
- g_source_remove(vcon->watch);
+ g_clear_handle_id(&vcon->watch, g_source_remove);
}
}
--
2.53.0
next reply other threads:[~2026-03-05 21:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-05 21:33 Matthew Penney [this message]
2026-03-20 9:21 ` [PATCH v2] hw/char: clear dangling GLib event source tag Matthew Penney
2026-03-24 14:43 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260305213308.96441-1-matt@matthewpenney.net \
--to=matt@matthewpenney.net \
--cc=amit@kernel.org \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox