From: Stefan Hajnoczi <stefanha@redhat.com>
To: Zhang Chen <zhangckid@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>,
"Dr . David Alan Gilbert" <dave@treblig.org>,
Eric Blake <eblake@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH V5 05/13] virtio-vq-mapping: track iothread-vq-mapping references using device path
Date: Mon, 9 Mar 2026 16:21:39 +0800 [thread overview]
Message-ID: <20260309082139.GD39949@fedora> (raw)
In-Reply-To: <20260305142459.52559-6-zhangckid@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1257 bytes --]
On Thu, Mar 05, 2026 at 10:24:51PM +0800, Zhang Chen wrote:
> Replace raw object_ref/unref calls with iothread_get/put_aio_context
> in iothread-vq-mapping. This allows tracking IOThread users via
> the device's canonical QOM path, improving lifecycle traceability
> for virtio-blk and virtio-scsi devices.
>
> Signed-off-by: Zhang Chen <zhangckid@gmail.com>
> ---
> hw/block/virtio-blk.c | 10 +++++++++-
> hw/scsi/virtio-scsi-dataplane.c | 11 +++++++++--
> hw/virtio/iothread-vq-mapping.c | 11 +++++------
> include/hw/virtio/iothread-vq-mapping.h | 6 +++++-
> 4 files changed, 28 insertions(+), 10 deletions(-)
>
> diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
> index ddf0e9ee53..b6f74df68f 100644
> --- a/hw/block/virtio-blk.c
> +++ b/hw/block/virtio-blk.c
> @@ -1453,14 +1453,19 @@ static bool virtio_blk_vq_aio_context_init(VirtIOBlock *s, Error **errp)
> s->vq_aio_context = g_new(AioContext *, conf->num_queues);
>
> if (conf->iothread_vq_mapping_list) {
> + char *path = object_get_canonical_path(OBJECT(vdev));
The g_free() calls can be avoided with:
g_autofree char *path = ...;
The same applies throughout the rest of this patch series.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-03-09 8:22 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-05 14:24 [PATCH V5 00/13] iothread: Support tracking and querying IOThread holders Zhang Chen
2026-03-05 14:24 ` [PATCH V5 01/13] qapi/misc: Fix missed query-iothreads items Zhang Chen
2026-03-05 14:24 ` [PATCH V5 02/13] iothread: introduce iothread_ref/unref to track attached devices Zhang Chen
2026-03-09 7:49 ` Stefan Hajnoczi
2026-03-10 9:49 ` Zhang Chen
2026-03-05 14:24 ` [PATCH V5 03/13] iothread: tracking iothread users with holder name Zhang Chen
2026-03-09 8:02 ` Stefan Hajnoczi
2026-03-10 9:49 ` Zhang Chen
2026-03-09 8:33 ` Stefan Hajnoczi
2026-03-10 9:51 ` Zhang Chen
2026-03-05 14:24 ` [PATCH V5 04/13] blockdev: Update " Zhang Chen
2026-03-09 8:15 ` Stefan Hajnoczi
2026-03-10 10:02 ` Zhang Chen
2026-03-12 5:24 ` Stefan Hajnoczi
2026-03-12 7:05 ` Zhang Chen
2026-03-12 7:44 ` Stefan Hajnoczi
2026-03-12 9:16 ` Markus Armbruster
2026-03-17 13:25 ` Zhang Chen
2026-03-18 6:19 ` Markus Armbruster
2026-03-18 9:13 ` Stefan Hajnoczi
2026-03-05 14:24 ` [PATCH V5 05/13] virtio-vq-mapping: track iothread-vq-mapping references using device path Zhang Chen
2026-03-09 8:21 ` Stefan Hajnoczi [this message]
2026-03-10 10:03 ` Zhang Chen
2026-03-05 14:24 ` [PATCH V5 06/13] virtio: use iothread_get/put_aio_context for thread pinning Zhang Chen
2026-03-09 8:27 ` Stefan Hajnoczi
2026-03-10 10:07 ` Zhang Chen
2026-03-05 14:24 ` [PATCH V5 07/13] net/colo: track IOThread references using path-based holder Zhang Chen
2026-03-09 8:44 ` Stefan Hajnoczi
2026-03-10 10:15 ` Zhang Chen
2026-03-12 5:36 ` Stefan Hajnoczi
2026-03-12 6:31 ` Zhang Chen
2026-03-12 7:36 ` Stefan Hajnoczi
2026-03-12 8:45 ` Zhang Chen
2026-03-05 14:24 ` [PATCH V5 08/13] block/export: Update tracking iothread users with holder name Zhang Chen
2026-03-09 8:52 ` Stefan Hajnoczi
2026-03-05 14:24 ` [PATCH V5 09/13] monitor: " Zhang Chen
2026-03-09 8:56 ` Stefan Hajnoczi
2026-03-10 10:24 ` Zhang Chen
2026-03-05 14:24 ` [PATCH V5 10/13] virtio-balloon: " Zhang Chen
2026-03-05 14:24 ` [PATCH V5 11/13] vfio-user/proxy: " Zhang Chen
2026-03-05 14:24 ` [PATCH V5 12/13] xen-block: " Zhang Chen
2026-03-05 14:24 ` [PATCH V5 13/13] qapi: examine IOThread attachment status via query-iothreads Zhang Chen
2026-03-18 6:09 ` Markus Armbruster
2026-03-18 13:25 ` Zhang Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260309082139.GD39949@fedora \
--to=stefanha@redhat.com \
--cc=armbru@redhat.com \
--cc=dave@treblig.org \
--cc=eblake@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=zhangckid@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox