public inbox for qemu-devel@nongnu.org
 help / color / mirror / Atom feed
From: Roman Kiryanov <rkir@google.com>
To: philmd@linaro.org, manos.pitsidianakis@linaro.org
Cc: qemu-devel@nongnu.org, whollins@google.com, jansene@google.com,
	 jpcottin@google.com, Roman Kiryanov <rkir@google.com>
Subject: [PATCH 1/3] virtio-snd: remove the unused field
Date: Tue, 10 Mar 2026 23:56:30 +0000	[thread overview]
Message-ID: <20260310235632.3987668-2-rkir@google.com> (raw)
In-Reply-To: <20260310235632.3987668-1-rkir@google.com>

VirtIOSoundPCMStream::positions is set but
never read from. It can be added back once
required.

Signed-off-by: Roman Kiryanov <rkir@google.com>
---
 hw/audio/virtio-snd.c         | 3 ---
 include/hw/audio/virtio-snd.h | 2 --
 2 files changed, 5 deletions(-)

diff --git a/hw/audio/virtio-snd.c b/hw/audio/virtio-snd.c
index fb5cff3866..bd6a5d71bb 100644
--- a/hw/audio/virtio-snd.c
+++ b/hw/audio/virtio-snd.c
@@ -462,9 +462,6 @@ static uint32_t virtio_snd_pcm_prepare(VirtIOSound *s, uint32_t stream_id)
     stream->info.formats = supported_formats;
     stream->info.rates = supported_rates;
     stream->params = *params;
-
-    stream->positions[0] = VIRTIO_SND_CHMAP_FL;
-    stream->positions[1] = VIRTIO_SND_CHMAP_FR;
     stream->as = as;
 
     if (stream->info.direction == VIRTIO_SND_D_OUTPUT) {
diff --git a/include/hw/audio/virtio-snd.h b/include/hw/audio/virtio-snd.h
index e28f1be5db..f8bb5c95b9 100644
--- a/include/hw/audio/virtio-snd.h
+++ b/include/hw/audio/virtio-snd.h
@@ -137,8 +137,6 @@ struct VirtIOSoundPCMStream {
     virtio_snd_pcm_info info;
     virtio_snd_pcm_set_params params;
     uint32_t id;
-    /* channel position values (VIRTIO_SND_CHMAP_XXX) */
-    uint8_t positions[VIRTIO_SND_CHMAP_MAX_SIZE];
     VirtIOSound *s;
     bool flushing;
     audsettings as;
-- 
2.53.0.473.g4a7958ca14-goog



  reply	other threads:[~2026-03-10 23:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-10 23:56 [PATCH 0/3] virtio-snd: snapshot prep cleanups Roman Kiryanov
2026-03-10 23:56 ` Roman Kiryanov [this message]
2026-03-10 23:56 ` [PATCH 2/3] virtio-snd: remove virtio_snd_pcm_set_params from VirtIOSoundPCMStream Roman Kiryanov
2026-03-10 23:56 ` [PATCH 3/3] virtio-snd: introduce VirtIOPcmParams Roman Kiryanov
2026-03-24 21:04 ` [PATCH 0/3] virtio-snd: snapshot prep cleanups Roman Kiryanov
2026-03-25  8:48 ` Marc-André Lureau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260310235632.3987668-2-rkir@google.com \
    --to=rkir@google.com \
    --cc=jansene@google.com \
    --cc=jpcottin@google.com \
    --cc=manos.pitsidianakis@linaro.org \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=whollins@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox