public inbox for qemu-devel@nongnu.org
 help / color / mirror / Atom feed
* [PULL 0/1] ppc-for-11.0-hardfreeze queue
@ 2026-03-17 15:07 Harsh Prateek Bora
  2026-03-17 15:07 ` [PULL 1/1] ppc/pnv: fix dumpdtb option Harsh Prateek Bora
  2026-03-18 10:11 ` [PULL 0/1] ppc-for-11.0-hardfreeze queue Peter Maydell
  0 siblings, 2 replies; 3+ messages in thread
From: Harsh Prateek Bora @ 2026-03-17 15:07 UTC (permalink / raw)
  To: qemu-devel

The following changes since commit 6667668e0cf369e47aa9dd0bae40989896e9ed9f:

  Merge tag 'pr-plugins-20260316' of https://gitlab.com/pbo-linaro/qemu into staging (2026-03-17 10:20:30 +0000)

are available in the Git repository at:

  https://gitlab.com/harshpb/qemu.git tags/pull-ppc-for-11.0-hardfreeze-20260317

for you to fetch changes up to a16d4c2f162a86db1f84ef0836d42eabaf57fe69:

  ppc/pnv: fix dumpdtb option (2026-03-17 20:31:42 +0530)

----------------------------------------------------------------
ppc queue for 11.0

* ppc/powernv: fix dumpdtb option

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEa4EM1tK+EPOIPSFCRUTplPnWj7sFAmm5bZ4ACgkQRUTplPnW
j7vZvQ/9HlYrlHQD3eQSEyUlVoEkR4piSh/D8sdigOOOdYhPEQZ6spluHg3OLEml
MvDv2Uz1t8GVKzGuZ19Y18H8wOW0zbjsOa9bfbtO7Mral7LIMbBFLej391czQVQC
NQ64Wms2B2TwjKDam8msekMkME646m5SanzgT1hGkKmIAKKSCBLwA9Na1HfxdcwQ
1TcDpjHBLg0x3OOmkh7V1PYyb7RSIAFRcYEkPnvgEWvIOaGubTVpB7/syb2n+cdq
ToPy0MvoIdlPID0wFd0t7t3tRPah/ubXD4ubrOEvWLDZ40BtLiB3p1Ou+MUU6lj1
GfPx7gjW4QG4o5aV4MmsAKxEP6K3RfJcRVjJUa3tl8oJvggS9uwvewEqHT07XBWc
NmxdEGzgkLCUXAVZLkKjqInz5VJlHROUWpsS8bq1edK09wju1o1CR0B0WDK//Cek
oqfZtb/6XHvmFrNnJprJvPNOWuhash1XRbL+iyfYxJJwuqIZPkQWjABeD7Fu8/aZ
Gpw3/2V+CiWJvThe9Z/vIEw/ksl1qigdNCtdVMeO9S8pQAtORZnUvNzWN5QKaVvL
VjxsFXhiEEn6bdoycJE0V6mfuPGaKcvE/APTDA4dT1b4du8IaUiiqGvGvVY+F1vg
p7ZpDlJmKd48jbkXnim8YiyXZO3sUUk7tw0N/xwPvCj+56nTv64=
=OUEg
-----END PGP SIGNATURE-----

----------------------------------------------------------------
Shivang Upadhyay (1):
      ppc/pnv: fix dumpdtb option

 hw/ppc/pnv.c | 25 ++++++-------------------
 1 file changed, 6 insertions(+), 19 deletions(-)


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PULL 1/1] ppc/pnv: fix dumpdtb option
  2026-03-17 15:07 [PULL 0/1] ppc-for-11.0-hardfreeze queue Harsh Prateek Bora
@ 2026-03-17 15:07 ` Harsh Prateek Bora
  2026-03-18 10:11 ` [PULL 0/1] ppc-for-11.0-hardfreeze queue Peter Maydell
  1 sibling, 0 replies; 3+ messages in thread
From: Harsh Prateek Bora @ 2026-03-17 15:07 UTC (permalink / raw)
  To: qemu-devel
  Cc: Shivang Upadhyay, Aditya Gupta, Peter Maydell, BALATON Zoltan,
	qemu-stable

From: Shivang Upadhyay <shivangu@linux.ibm.com>

The '-machine dumpdtb' command line option stopped working on
PowerPC/pnv systems after recent design change [1].

Fixing this by generating fdt blob in `pnv_init`.

[1] https://lore.kernel.org/qemu-devel/20250206151214.2947842-1-peter.maydell@linaro.org/

Cc: Aditya Gupta <adityag@linux.ibm.com>
Cc: Harsh Prateek Bora <harshpb@linux.ibm.com>
Cc: Peter Maydell <peter.maydell@linaro.org>
Cc: BALATON Zoltan <balaton@eik.bme.hu>
Cc: qemu-stable@nongnu.org
Fixes: 8fd2518ef2f8d34 ("hw: Centralize handling of -machine dumpdtb option")
Signed-off-by: Shivang Upadhyay <shivangu@linux.ibm.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Aditya Gupta <adityag@linux.ibm.com>
Link: https://lore.kernel.org/qemu-devel/20260311143549.118720-1-shivangu@linux.ibm.com
Signed-off-by: Harsh Prateek Bora <harshpb@linux.ibm.com>
---
 hw/ppc/pnv.c | 25 ++++++-------------------
 1 file changed, 6 insertions(+), 19 deletions(-)

diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c
index 1513575b8f..7e54b6bc60 100644
--- a/hw/ppc/pnv.c
+++ b/hw/ppc/pnv.c
@@ -773,26 +773,8 @@ static void pnv_reset(MachineState *machine, ResetType type)
         }
     }
 
-    if (machine->fdt) {
-        fdt = machine->fdt;
-    } else {
-        fdt = pnv_dt_create(machine);
-        /* Pack resulting tree */
-        _FDT((fdt_pack(fdt)));
-    }
-
+    fdt = machine->fdt;
     cpu_physical_memory_write(PNV_FDT_ADDR, fdt, fdt_totalsize(fdt));
-
-    /* Update machine->fdt with latest fdt */
-    if (machine->fdt != fdt) {
-        /*
-         * Set machine->fdt for 'dumpdtb' QMP/HMP command. Free
-         * the existing machine->fdt to avoid leaking it during
-         * a reset.
-         */
-        g_free(machine->fdt);
-        machine->fdt = fdt;
-    }
 }
 
 static ISABus *pnv_chip_power8_isa_create(PnvChip *chip, Error **errp)
@@ -1261,6 +1243,11 @@ static void pnv_init(MachineState *machine)
     if (pmc->i2c_init) {
         pmc->i2c_init(pnv);
     }
+
+    if (!machine->fdt) {
+        machine->fdt = pnv_dt_create(machine);
+        _FDT((fdt_pack(machine->fdt)));
+    }
 }
 
 /*
-- 
2.52.0



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PULL 0/1] ppc-for-11.0-hardfreeze queue
  2026-03-17 15:07 [PULL 0/1] ppc-for-11.0-hardfreeze queue Harsh Prateek Bora
  2026-03-17 15:07 ` [PULL 1/1] ppc/pnv: fix dumpdtb option Harsh Prateek Bora
@ 2026-03-18 10:11 ` Peter Maydell
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2026-03-18 10:11 UTC (permalink / raw)
  To: Harsh Prateek Bora; +Cc: qemu-devel

On Tue, 17 Mar 2026 at 15:08, Harsh Prateek Bora <harshpb@linux.ibm.com> wrote:
>
> The following changes since commit 6667668e0cf369e47aa9dd0bae40989896e9ed9f:
>
>   Merge tag 'pr-plugins-20260316' of https://gitlab.com/pbo-linaro/qemu into staging (2026-03-17 10:20:30 +0000)
>
> are available in the Git repository at:
>
>   https://gitlab.com/harshpb/qemu.git tags/pull-ppc-for-11.0-hardfreeze-20260317
>
> for you to fetch changes up to a16d4c2f162a86db1f84ef0836d42eabaf57fe69:
>
>   ppc/pnv: fix dumpdtb option (2026-03-17 20:31:42 +0530)
>
> ----------------------------------------------------------------
> ppc queue for 11.0
>
> * ppc/powernv: fix dumpdtb option



Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/11.0
for any user-visible changes.

-- PMM


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-03-18 10:12 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-17 15:07 [PULL 0/1] ppc-for-11.0-hardfreeze queue Harsh Prateek Bora
2026-03-17 15:07 ` [PULL 1/1] ppc/pnv: fix dumpdtb option Harsh Prateek Bora
2026-03-18 10:11 ` [PULL 0/1] ppc-for-11.0-hardfreeze queue Peter Maydell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox