From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5EB5CFEDA03 for ; Tue, 17 Mar 2026 18:24:18 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w2Z52-0003tb-DF; Tue, 17 Mar 2026 14:23:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w2Z4x-0003nh-Bw for qemu-devel@nongnu.org; Tue, 17 Mar 2026 14:23:43 -0400 Received: from smtp-out1.suse.de ([2a07:de40:b251:101:10:150:64:1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w2Z4u-00035E-IC for qemu-devel@nongnu.org; Tue, 17 Mar 2026 14:23:42 -0400 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 878564D3BD; Tue, 17 Mar 2026 18:23:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1773771808; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mc6OQGr9KDCwK2JPTsR63nsrSMYSrNNoCmK5GBWbLyc=; b=DISzavzuNkrIIwy6Pfmjmmbn1a5iNQOFGPimXjKVytjcw4ArIBf0N5iARuFaXtjflbfbyI tswBapgNOAPGCyw+ITyvkiaIP2d8MDPBf+1wERJVN66F9HfrsqiWXLBvIH+vx+REw4Y+TM 5nbwDUTCn/PW7O2GGFSHwF2jaBYFVaU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1773771808; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mc6OQGr9KDCwK2JPTsR63nsrSMYSrNNoCmK5GBWbLyc=; b=duP4ySXLpqUqTstf9r14ITTNiQCFD/sOD4e4tHBE8OPity87iOFzDUTQtj4LDY918gxEwf ueiJYlFybpJb2eCw== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1773771808; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mc6OQGr9KDCwK2JPTsR63nsrSMYSrNNoCmK5GBWbLyc=; b=DISzavzuNkrIIwy6Pfmjmmbn1a5iNQOFGPimXjKVytjcw4ArIBf0N5iARuFaXtjflbfbyI tswBapgNOAPGCyw+ITyvkiaIP2d8MDPBf+1wERJVN66F9HfrsqiWXLBvIH+vx+REw4Y+TM 5nbwDUTCn/PW7O2GGFSHwF2jaBYFVaU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1773771808; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mc6OQGr9KDCwK2JPTsR63nsrSMYSrNNoCmK5GBWbLyc=; b=duP4ySXLpqUqTstf9r14ITTNiQCFD/sOD4e4tHBE8OPity87iOFzDUTQtj4LDY918gxEwf ueiJYlFybpJb2eCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 625ED4273B; Tue, 17 Mar 2026 18:23:27 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id +FF5Ch+cuWnXdQAAD6G6ig (envelope-from ); Tue, 17 Mar 2026 18:23:27 +0000 From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: Peter Xu , Prasad Pandit Subject: [PULL 03/10] tests/qtest/migration: Fix leak in CPR exec test Date: Tue, 17 Mar 2026 15:23:13 -0300 Message-ID: <20260317182320.31991-4-farosas@suse.de> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260317182320.31991-1-farosas@suse.de> References: <20260317182320.31991-1-farosas@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_DN_SOME(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,suse.de:email,imap1.dmz-prg2.suse.org:helo]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FUZZY_RATELIMITED(0.00)[rspamd.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCPT_COUNT_THREE(0.00)[3]; RCVD_TLS_ALL(0.00)[] Received-SPF: pass client-ip=2a07:de40:b251:101:10:150:64:1; envelope-from=farosas@suse.de; helo=smtp-out1.suse.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org The string was being dup'ed only to get around the const of the qdict_get_str() return value. Reviewed-by: Peter Xu Reviewed-by: Prasad Pandit Link: https://lore.kernel.org/qemu-devel/20260311213418.16951-4-farosas@suse.de Signed-off-by: Fabiano Rosas --- tests/qtest/migration/cpr-tests.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/qtest/migration/cpr-tests.c b/tests/qtest/migration/cpr-tests.c index 0d97b5b89f..63ca5f3996 100644 --- a/tests/qtest/migration/cpr-tests.c +++ b/tests/qtest/migration/cpr-tests.c @@ -154,15 +154,16 @@ static void set_cpr_exec_args(QTestState *who, MigrateCommon *args) static void wait_for_migration_event(QTestState *who, const char *waitfor) { QDict *rsp, *data; - char *status; bool done = false; while (!done) { + const char *status; + rsp = qtest_qmp_eventwait_ref(who, "MIGRATION"); g_assert(qdict_haskey(rsp, "data")); data = qdict_get_qdict(rsp, "data"); g_assert(qdict_haskey(data, "status")); - status = g_strdup(qdict_get_str(data, "status")); + status = qdict_get_str(data, "status"); g_assert(strcmp(status, "failed")); done = !strcmp(status, waitfor); qobject_unref(rsp); -- 2.51.0