public inbox for qemu-devel@nongnu.org
 help / color / mirror / Atom feed
* [PULL 0/1] Plugins update for 2026-03-17
@ 2026-03-17 19:13 Pierrick Bouvier
  2026-03-17 19:13 ` [PULL 1/1] plugins/api-system: Handle migrate_add_blocker() failure Pierrick Bouvier
  2026-03-18 13:26 ` [PULL 0/1] Plugins update for 2026-03-17 Peter Maydell
  0 siblings, 2 replies; 3+ messages in thread
From: Pierrick Bouvier @ 2026-03-17 19:13 UTC (permalink / raw)
  To: qemu-devel, peter.maydell, richard.henderson, pbonzini, stefanha
  Cc: pierrick.bouvier

The following changes since commit 6667668e0cf369e47aa9dd0bae40989896e9ed9f:

  Merge tag 'pr-plugins-20260316' of https://gitlab.com/pbo-linaro/qemu into staging (2026-03-17 10:20:30 +0000)

are available in the Git repository at:

  https://gitlab.com/pbo-linaro/qemu tags/pr-plugins-20260317

for you to fetch changes up to db52193355cf75394a39ca9f70b1325d4bbe18d6:

  plugins/api-system: Handle migrate_add_blocker() failure (2026-03-17 12:13:16 -0700)

----------------------------------------------------------------
Changes:
- [PATCH v2 v2] plugins/api-system: Handle migrate_add_blocker() failure (Trieu Huynh <vikingtc4@gmail.com>)
  Link: https://lore.kernel.org/qemu-devel/20260317134733.126584-1-vikingtc4@gmail.com

----------------------------------------------------------------
Trieu Huynh (1):
      plugins/api-system: Handle migrate_add_blocker() failure

 plugins/api-system.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PULL 1/1] plugins/api-system: Handle migrate_add_blocker() failure
  2026-03-17 19:13 [PULL 0/1] Plugins update for 2026-03-17 Pierrick Bouvier
@ 2026-03-17 19:13 ` Pierrick Bouvier
  2026-03-18 13:26 ` [PULL 0/1] Plugins update for 2026-03-17 Peter Maydell
  1 sibling, 0 replies; 3+ messages in thread
From: Pierrick Bouvier @ 2026-03-17 19:13 UTC (permalink / raw)
  To: qemu-devel, peter.maydell, richard.henderson, pbonzini, stefanha
  Cc: pierrick.bouvier

From: Trieu Huynh <vikingtc4@gmail.com>

migrate_add_blocker() can fail (e.g. if migration is already in
progress), in which case it returns a negative value and populates
its errp argument with the reason.

The previous code ignored the return value. Pass &error_fatal so
that on failure QEMU exits cleanly with an informative error message
rather than continuing in an inconsistent state.

Resolves: CID 1645470
Signed-off-by: Trieu Huynh <vikingtc4@gmail.com>
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Tested-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Link: https://lore.kernel.org/qemu-devel/20260317134733.126584-1-vikingtc4@gmail.com
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
---
 plugins/api-system.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/plugins/api-system.c b/plugins/api-system.c
index 9a70b9caa6c..fbf905cd63e 100644
--- a/plugins/api-system.c
+++ b/plugins/api-system.c
@@ -108,7 +108,7 @@ const void *qemu_plugin_request_time_control(void)
         has_control = true;
         error_setg(&migration_blocker,
                    "TCG plugin time control does not support migration");
-        migrate_add_blocker(&migration_blocker, NULL);
+        migrate_add_blocker(&migration_blocker, &error_fatal);
         return &has_control;
     }
     return NULL;
-- 
2.47.3



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PULL 0/1] Plugins update for 2026-03-17
  2026-03-17 19:13 [PULL 0/1] Plugins update for 2026-03-17 Pierrick Bouvier
  2026-03-17 19:13 ` [PULL 1/1] plugins/api-system: Handle migrate_add_blocker() failure Pierrick Bouvier
@ 2026-03-18 13:26 ` Peter Maydell
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2026-03-18 13:26 UTC (permalink / raw)
  To: Pierrick Bouvier; +Cc: qemu-devel, richard.henderson, pbonzini, stefanha

On Tue, 17 Mar 2026 at 19:14, Pierrick Bouvier
<pierrick.bouvier@linaro.org> wrote:
>
> The following changes since commit 6667668e0cf369e47aa9dd0bae40989896e9ed9f:
>
>   Merge tag 'pr-plugins-20260316' of https://gitlab.com/pbo-linaro/qemu into staging (2026-03-17 10:20:30 +0000)
>
> are available in the Git repository at:
>
>   https://gitlab.com/pbo-linaro/qemu tags/pr-plugins-20260317
>
> for you to fetch changes up to db52193355cf75394a39ca9f70b1325d4bbe18d6:
>
>   plugins/api-system: Handle migrate_add_blocker() failure (2026-03-17 12:13:16 -0700)
>
> ----------------------------------------------------------------
> Changes:
> - [PATCH v2 v2] plugins/api-system: Handle migrate_add_blocker() failure (Trieu Huynh <vikingtc4@gmail.com>)
>   Link: https://lore.kernel.org/qemu-devel/20260317134733.126584-1-vikingtc4@gmail.com
>
> ----------------------------------------------------------------
> Trieu Huynh (1):
>       plugins/api-system: Handle migrate_add_blocker() failure



Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/11.0
for any user-visible changes.

-- PMM


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-03-18 13:29 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-17 19:13 [PULL 0/1] Plugins update for 2026-03-17 Pierrick Bouvier
2026-03-17 19:13 ` [PULL 1/1] plugins/api-system: Handle migrate_add_blocker() failure Pierrick Bouvier
2026-03-18 13:26 ` [PULL 0/1] Plugins update for 2026-03-17 Peter Maydell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox