From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Pierrick Bouvier" <pierrick.bouvier@linaro.org>,
"Ilya Leoshkevich" <iii@linux.ibm.com>,
"Anton Johansson" <anjo@rev.ng>,
"Eric Farman" <farman@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
"Matthew Rosato" <mjrosato@linux.ibm.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Halil Pasic" <pasic@linux.ibm.com>,
qemu-s390x@nongnu.org, "David Hildenbrand" <david@kernel.org>,
"Cornelia Huck" <cohuck@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PATCH 2/5] target/s390x: Replace legacy ld/st_phys -> address_space_ld/st (mmu)
Date: Thu, 19 Mar 2026 19:52:00 +0100 [thread overview]
Message-ID: <20260319185203.11799-3-philmd@linaro.org> (raw)
In-Reply-To: <20260319185203.11799-1-philmd@linaro.org>
Prefer the address_space_ld/st API over the legacy ld_phys()
because it allow checking for bus access fault.
This code however doesn't check for fault, so we simply inline
the calls (not specifying any memory transaction attribute nor
expecting transation result). No logical change intended.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
target/s390x/mmu_helper.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/target/s390x/mmu_helper.c b/target/s390x/mmu_helper.c
index 246573ff642..255271b9d34 100644
--- a/target/s390x/mmu_helper.c
+++ b/target/s390x/mmu_helper.c
@@ -44,8 +44,9 @@ static void trigger_access_exception(CPUS390XState *env, uint32_t type,
} else {
CPUState *cs = env_cpu(env);
if (type != PGM_ADDRESSING) {
- stq_be_phys(cs->as, env->psa + offsetof(LowCore, trans_exc_code),
- tec);
+ address_space_stq_be(cs->as,
+ env->psa + offsetof(LowCore, trans_exc_code),
+ tec, MEMTXATTRS_UNSPECIFIED, NULL);
}
trigger_pgm_exception(env, type);
}
--
2.53.0
next prev parent reply other threads:[~2026-03-19 18:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-19 18:51 [PATCH 0/5] target/s390x: Forbid to use legacy ldst_phys() API Philippe Mathieu-Daudé
2026-03-19 18:51 ` [PATCH 1/5] target/s390x: Replace legacy ld/st_phys -> address_space_ld/st (cpu) Philippe Mathieu-Daudé
2026-03-19 18:52 ` Philippe Mathieu-Daudé [this message]
2026-03-19 18:52 ` [PATCH 3/5] target/s390x: Replace legacy ld/st_phys -> address_space_ld/st (tcg) Philippe Mathieu-Daudé
2026-03-19 18:52 ` [PATCH 4/5] target/s390x: Replace legacy ld/st_phys -> address_space_ld/st (kvm) Philippe Mathieu-Daudé
2026-03-19 18:52 ` [PATCH 5/5] configs/targets: Restrict the legacy ldst_phys() API on s390x target Philippe Mathieu-Daudé
2026-03-20 19:28 ` [PATCH 0/5] target/s390x: Forbid to use legacy ldst_phys() API Matthew Rosato
2026-03-21 15:26 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260319185203.11799-3-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=anjo@rev.ng \
--cc=borntraeger@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@kernel.org \
--cc=farman@linux.ibm.com \
--cc=iii@linux.ibm.com \
--cc=mjrosato@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox