From: Jaehoon Kim <jhkim@linux.ibm.com>
To: qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: mjrosato@linux.ibm.com, farman@linux.ibm.com,
pbonzini@redhat.com, stefanha@redhat.com, fam@euphon.net,
armbru@redhat.com, eblake@redhat.com, berrange@redhat.com,
eduardo@habkost.net, dave@treblig.org, sw@weilnetz.de,
Jaehoon Kim <jhkim@linux.ibm.com>
Subject: [PATCH RFC v2 1/3] aio-poll: avoid unnecessary polling time computation
Date: Mon, 23 Mar 2026 08:54:49 -0500 [thread overview]
Message-ID: <20260323135451.579655-2-jhkim@linux.ibm.com> (raw)
In-Reply-To: <20260323135451.579655-1-jhkim@linux.ibm.com>
Nodes are no longer added to poll_aio_handlers when adaptive polling is
disabled, preventing unnecessary try_poll_mode() calls. Additionally,
aio_poll() skips try_poll_mode() when timeout is 0.
This avoids iterating over all nodes to compute max_ns unnecessarily
when polling is disabled or timeout is 0.
Signed-off-by: Jaehoon Kim <jhkim@linux.ibm.com>
---
util/aio-posix.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/util/aio-posix.c b/util/aio-posix.c
index 488d964611..b02beb0505 100644
--- a/util/aio-posix.c
+++ b/util/aio-posix.c
@@ -307,9 +307,8 @@ static bool aio_dispatch_handler(AioContext *ctx, AioHandler *node)
* fdmon_supports_polling(), but only until the fd fires for the first
* time.
*/
- if (!QLIST_IS_INSERTED(node, node_deleted) &&
- !QLIST_IS_INSERTED(node, node_poll) &&
- node->io_poll) {
+ if (ctx->poll_max_ns && !QLIST_IS_INSERTED(node, node_deleted) &&
+ !QLIST_IS_INSERTED(node, node_poll) && node->io_poll) {
trace_poll_add(ctx, node, node->pfd.fd, revents);
if (ctx->poll_started && node->io_poll_begin) {
node->io_poll_begin(node->opaque);
@@ -631,7 +630,7 @@ static void adjust_polling_time(AioContext *ctx, AioPolledEvent *poll,
bool aio_poll(AioContext *ctx, bool blocking)
{
AioHandlerList ready_list = QLIST_HEAD_INITIALIZER(ready_list);
- bool progress;
+ bool progress = false;
bool use_notify_me;
int64_t timeout;
int64_t start = 0;
@@ -656,7 +655,9 @@ bool aio_poll(AioContext *ctx, bool blocking)
}
timeout = blocking ? aio_compute_timeout(ctx) : 0;
- progress = try_poll_mode(ctx, &ready_list, &timeout);
+ if ((ctx->poll_max_ns != 0) && (timeout != 0)) {
+ progress = try_poll_mode(ctx, &ready_list, &timeout);
+ }
assert(!(timeout && progress));
/*
--
2.50.1
next prev parent reply other threads:[~2026-03-23 13:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 13:54 [PATCH RFC v2 0/3] improve aio-polling efficiency Jaehoon Kim
2026-03-23 13:54 ` Jaehoon Kim [this message]
2026-03-25 17:22 ` [PATCH RFC v2 1/3] aio-poll: avoid unnecessary polling time computation Stefan Hajnoczi
2026-03-23 13:54 ` [PATCH RFC v2 2/3] aio-poll: refine iothread polling using weighted handler intervals Jaehoon Kim
2026-03-25 20:37 ` Stefan Hajnoczi
2026-03-23 13:54 ` [PATCH RFC v2 3/3] qapi/iothread: introduce poll-weight parameter for aio-poll Jaehoon Kim
2026-03-25 14:04 ` Markus Armbruster
2026-03-25 16:52 ` Stefan Hajnoczi
2026-03-25 16:56 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260323135451.579655-2-jhkim@linux.ibm.com \
--to=jhkim@linux.ibm.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=dave@treblig.org \
--cc=eblake@redhat.com \
--cc=eduardo@habkost.net \
--cc=fam@euphon.net \
--cc=farman@linux.ibm.com \
--cc=mjrosato@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox