From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B37A2FEC107 for ; Tue, 24 Mar 2026 19:44:27 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w57fY-0003FI-Dt; Tue, 24 Mar 2026 15:44:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w57fW-0003E2-5V for qemu-devel@nongnu.org; Tue, 24 Mar 2026 15:44:02 -0400 Received: from smtp-out1.suse.de ([2a07:de40:b251:101:10:150:64:1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1w57fU-0008AH-M9 for qemu-devel@nongnu.org; Tue, 24 Mar 2026 15:44:01 -0400 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 350414D258; Tue, 24 Mar 2026 19:43:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1774381429; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7yWIcZLxTYk0vijj26b8iV73kdeke7MYyK4wz5guLbw=; b=MOWOSWiHG05+qmxDk1TXjZlVm7pMV3BCTPmOTwkiiS3r1vEn87sCbVmSVIdE1xxRM6hjVr WrcGhJ2Pi7I3JwnurhsT1GPMDfyCz6XD5MvpJ6Mngn8/cebjhsThPLYa/y8i0S+26ZGzL7 4oelo8AxOhUEao6jA1VdWQgFTi6xxko= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1774381429; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7yWIcZLxTYk0vijj26b8iV73kdeke7MYyK4wz5guLbw=; b=5GiRSDis07n3YgaHMeUJqGr8XLWyNjDiEvVCkoQ9kPulT2swhrIxg9utKx3Xe26hFZZzmQ Kegr6vVwh831dWBA== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1774381429; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7yWIcZLxTYk0vijj26b8iV73kdeke7MYyK4wz5guLbw=; b=MOWOSWiHG05+qmxDk1TXjZlVm7pMV3BCTPmOTwkiiS3r1vEn87sCbVmSVIdE1xxRM6hjVr WrcGhJ2Pi7I3JwnurhsT1GPMDfyCz6XD5MvpJ6Mngn8/cebjhsThPLYa/y8i0S+26ZGzL7 4oelo8AxOhUEao6jA1VdWQgFTi6xxko= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1774381429; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7yWIcZLxTYk0vijj26b8iV73kdeke7MYyK4wz5guLbw=; b=5GiRSDis07n3YgaHMeUJqGr8XLWyNjDiEvVCkoQ9kPulT2swhrIxg9utKx3Xe26hFZZzmQ Kegr6vVwh831dWBA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 0E46E43FE4; Tue, 24 Mar 2026 19:43:47 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 0EjMM3PpwmlkMQAAD6G6ig (envelope-from ); Tue, 24 Mar 2026 19:43:47 +0000 From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: Peter Xu , Alexander Mikhalitsyn , Juraj Marcin Subject: [RFC PATCH v1 08/17] vmstate: Don't recompute size and n_elems in vmstate_size Date: Tue, 24 Mar 2026 16:43:23 -0300 Message-ID: <20260324194333.30004-9-farosas@suse.de> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260324194333.30004-1-farosas@suse.de> References: <20260324194333.30004-1-farosas@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_DN_SOME(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,suse.de:email]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FUZZY_RATELIMITED(0.00)[rspamd.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCPT_COUNT_THREE(0.00)[4]; RCVD_TLS_ALL(0.00)[] Received-SPF: pass client-ip=2a07:de40:b251:101:10:150:64:1; envelope-from=farosas@suse.de; helo=smtp-out1.suse.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org The caller already has the size and number of elements available. Pass them in. Subsequent commits will add other callers. Signed-off-by: Fabiano Rosas --- migration/vmstate.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/migration/vmstate.c b/migration/vmstate.c index 0975d10793..8437b5ef3e 100644 --- a/migration/vmstate.c +++ b/migration/vmstate.c @@ -101,11 +101,10 @@ static int vmstate_size(void *opaque, const VMStateField *field) } static void vmstate_handle_alloc(void *ptr, const VMStateField *field, - void *opaque) + int size, int n_elems) { if (field->flags & VMS_POINTER && field->flags & VMS_ALLOC) { - gsize size = vmstate_size(opaque, field); - size *= vmstate_n_elems(opaque, field); + size *= n_elems; if (size) { *(void **)ptr = g_malloc(size); } @@ -248,7 +247,7 @@ bool vmstate_load_vmsd(QEMUFile *f, const VMStateDescription *vmsd, int i, n_elems = vmstate_n_elems(opaque, field); int size = vmstate_size(opaque, field); - vmstate_handle_alloc(first_elem, field, opaque); + vmstate_handle_alloc(first_elem, field, size, n_elems); if (field->flags & VMS_POINTER) { first_elem = *(void **)first_elem; assert(first_elem || !n_elems || !size); -- 2.51.0