From: Pierrick Bouvier <pierrick.bouvier@linaro.org>
To: qemu-devel@nongnu.org, peter.maydell@linaro.org,
richard.henderson@linaro.org, pbonzini@redhat.com,
stefanha@redhat.com
Cc: pierrick.bouvier@linaro.org
Subject: [PULL 2/3] include/plugins/qemu-plugin.h: add note about endianness of value returned by qemu_plugin_mem_get_value
Date: Wed, 25 Mar 2026 14:52:21 -0700 [thread overview]
Message-ID: <20260325215222.3678982-3-pierrick.bouvier@linaro.org> (raw)
In-Reply-To: <20260325215222.3678982-1-pierrick.bouvier@linaro.org>
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Link: https://lore.kernel.org/qemu-devel/20260325024252.3369186-3-pierrick.bouvier@linaro.org
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
---
include/plugins/qemu-plugin.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/include/plugins/qemu-plugin.h b/include/plugins/qemu-plugin.h
index 2ce7a7fb6c3..4eb1d2cd85c 100644
--- a/include/plugins/qemu-plugin.h
+++ b/include/plugins/qemu-plugin.h
@@ -374,7 +374,8 @@ enum qemu_plugin_mem_value_type {
*
* @type: the memory access size
* @data: the value accessed during the memory operation (value after
- * read/write)
+ * read/write). It's directly stored following host endianness, so no
+ * further swap is needed.
*/
typedef struct {
enum qemu_plugin_mem_value_type type;
@@ -682,7 +683,7 @@ bool qemu_plugin_mem_is_store(qemu_plugin_meminfo_t info);
* qemu_plugin_mem_get_value() - return last value loaded/stored
* @info: opaque memory transaction handle
*
- * Returns: memory value
+ * Returns: memory value in host-endian order (no further swap is necessary).
*/
QEMU_PLUGIN_API
qemu_plugin_mem_value qemu_plugin_mem_get_value(qemu_plugin_meminfo_t info);
--
2.47.3
next prev parent reply other threads:[~2026-03-25 21:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-25 21:52 [PULL 0/3] plugins: fix endianness for qemu_plugin_mem_get_value() Pierrick Bouvier
2026-03-25 21:52 ` [PULL 1/3] tcg: Pass host-endian values to plugin_gen_mem_callbacks_* Pierrick Bouvier
2026-03-25 21:52 ` Pierrick Bouvier [this message]
2026-03-25 21:52 ` [PULL 3/3] tests/tcg/plugins/mem.c: fix endian swap in update_region_info Pierrick Bouvier
2026-03-26 14:58 ` [PULL 0/3] plugins: fix endianness for qemu_plugin_mem_get_value() Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260325215222.3678982-3-pierrick.bouvier@linaro.org \
--to=pierrick.bouvier@linaro.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox